From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8AC662BBD for ; Fri, 31 Mar 2017 11:14:00 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC321C0092B5; Fri, 31 Mar 2017 09:13:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CC321C0092B5 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=maxime.coquelin@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CC321C0092B5 Received: from [10.36.112.26] (ovpn-112-26.ams2.redhat.com [10.36.112.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A315018A6F; Fri, 31 Mar 2017 09:13:58 +0000 (UTC) To: Yuanhan Liu , dev@dpdk.org References: <1490253059-28112-1-git-send-email-yuanhan.liu@linux.intel.com> <1490705142-893-1-git-send-email-yuanhan.liu@linux.intel.com> <1490705142-893-21-git-send-email-yuanhan.liu@linux.intel.com> Cc: Harris James R , Liu Changpeng From: Maxime Coquelin Message-ID: <830d2611-0baa-efdc-5355-5a67a65f85bb@redhat.com> Date: Fri, 31 Mar 2017 11:13:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490705142-893-21-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 31 Mar 2017 09:14:00 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 20/22] vhost: workaround the build dependency on mbuf header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 09:14:00 -0000 On 03/28/2017 02:45 PM, Yuanhan Liu wrote: > rte_mbuf struct is something more likely will be used only in vhost-user > net driver, while we have made vhost-user generic enough that it can > be used for implementing other drivers (such as vhost-user SCSI), they > have also include . Otherwise, the build will be broken. > > We could workaround it by using forward declaration, so that other > non-net drivers won't need include . > > Signed-off-by: Yuanhan Liu > --- > lib/librte_vhost/rte_vhost.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Maxime Coquelin Thanks, Maxime