From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Pass CC option when building kernel modules
Date: Wed, 08 Oct 2014 19:15:04 +0200 [thread overview]
Message-ID: <8311103.0CSzmCek1E@xps13> (raw)
In-Reply-To: <1412611022-8278-1-git-send-email-sergio.gonzalez.monroy@intel.com>
2014-10-06 16:57, Sergio Gonzalez Monroy:
> At least on kernels 3.15 or newer, DPDK build is broken for CLANG target.
> The issue is that the kernel build system sets the flags before including
> DPDK makefile and therefore assumes the incorrect compiler.
>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> --- a/mk/rte.module.mk
> +++ b/mk/rte.module.mk
> @@ -78,7 +78,7 @@ build: _postbuild
> $(MODULE).ko: $(SRCS_LINKS)
> @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
> - CROSS_COMPILE=$(CROSS)
> + CC=$(KERNELCC) CROSS_COMPILE=$(CROSS)
> --- a/mk/target/generic/rte.vars.mk
> +++ b/mk/target/generic/rte.vars.mk
> @@ -149,4 +149,6 @@ endif
> export CFLAGS
> export LDFLAGS
>
> +else # ! ifeq ($(KERNELRELEASE),)
> +CC = $(KERNELCC)
> endif
Why is it needed here? Setting CC in rte.module.mk is not sufficient?
Thanks
--
Thomas
next prev parent reply other threads:[~2014-10-08 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 15:57 Sergio Gonzalez Monroy
2014-10-06 16:12 ` Bruce Richardson
2014-10-08 17:15 ` Thomas Monjalon [this message]
2014-10-09 8:10 ` Bruce Richardson
2014-10-09 10:04 ` Sergio Gonzalez Monroy
2014-10-09 10:08 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2014-10-13 16:08 ` De Lara Guarch, Pablo
2014-10-15 14:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8311103.0CSzmCek1E@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).