From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/hash: lock-free rw concurrency test ext bkt
Date: Tue, 2 Apr 2019 19:44:27 +0000 [thread overview]
Message-ID: <83121B26-F2A5-4342-ADE1-E77651808A59@arm.com> (raw)
In-Reply-To: <2434371.7uYfYzBtHE@xps>
Hi Thomas,
Thank you for the review!
> On Apr 1, 2019, at 7:57 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 02/04/2019 01:08, Dharmik Thakkar:
>> Add unit test to check for hash lookup and bulk-lookup perf for
>> extendable bucket feature.
>> It is tested with both lock-free enabled and lock-free disabled case.
>>
>> Test includes:
>>
>> - hash lookup on keys in ext bkt
>> - hash delete causing key-shifts of keys from ext bkt to secondary bkt
>>
>> Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
>> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
>> ---
>> v4:
>> - Add Acked-by tag.
>
> FYI, no need to send a new version just for this.
Sure, thanks!
>
> Please run devtools/test-meson-builds.sh.
> When building build-clang-static, I see this error:
>
> app/test/test_hash_readwrite_lf.c:670:13: error:
> variable 'key_cnt' is used uninitialized whenever 'if' condition is false
Will resolve and update.
next prev parent reply other threads:[~2019-04-02 19:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 22:35 [dpdk-dev] [PATCH 0/2] hash: add lock free support for " Dharmik Thakkar
2019-03-20 22:35 ` Dharmik Thakkar
2019-03-20 22:35 ` [dpdk-dev] [PATCH 1/2] hash: add lock free support for extendable bucket Dharmik Thakkar
2019-03-20 22:35 ` Dharmik Thakkar
2019-03-22 23:48 ` Wang, Yipeng1
2019-03-22 23:48 ` Wang, Yipeng1
2019-03-25 20:10 ` Dharmik Thakkar
2019-03-25 20:10 ` Dharmik Thakkar
2019-03-20 22:35 ` [dpdk-dev] [PATCH 2/2] test/hash: lock-free rw concurrency test ext bkt Dharmik Thakkar
2019-03-20 22:35 ` Dharmik Thakkar
2019-03-25 21:08 ` [dpdk-dev] [PATCH v2 0/2] hash: add lock free support for " Dharmik Thakkar
2019-03-25 21:08 ` Dharmik Thakkar
2019-03-25 21:08 ` [dpdk-dev] [PATCH v2 1/2] hash: add lock free support for extendable bucket Dharmik Thakkar
2019-03-25 21:08 ` Dharmik Thakkar
2019-04-01 18:20 ` Wang, Yipeng1
2019-04-01 18:20 ` Wang, Yipeng1
2019-04-01 20:16 ` Dharmik Thakkar
2019-04-01 20:16 ` Dharmik Thakkar
2019-03-25 21:08 ` [dpdk-dev] [PATCH v2 2/2] test/hash: lock-free rw concurrency test ext bkt Dharmik Thakkar
2019-03-25 21:08 ` Dharmik Thakkar
2019-04-01 18:55 ` Wang, Yipeng1
2019-04-01 18:55 ` Wang, Yipeng1
2019-04-01 20:06 ` Dharmik Thakkar
2019-04-01 20:06 ` Dharmik Thakkar
2019-04-01 22:18 ` [dpdk-dev] [PATCH v3 0/2] hash: add lock free support for " Dharmik Thakkar
2019-04-01 22:18 ` Dharmik Thakkar
2019-04-01 22:18 ` [dpdk-dev] [PATCH v3 1/2] hash: add lock free support for extendable bucket Dharmik Thakkar
2019-04-01 22:18 ` Dharmik Thakkar
2019-04-01 22:18 ` [dpdk-dev] [PATCH v3 2/2] test/hash: lock-free rw concurrency test ext bkt Dharmik Thakkar
2019-04-01 22:18 ` Dharmik Thakkar
2019-04-01 22:52 ` Wang, Yipeng1
2019-04-01 22:52 ` Wang, Yipeng1
2019-04-01 23:08 ` [dpdk-dev] [PATCH v4 0/2] hash: add lock free support for " Dharmik Thakkar
2019-04-01 23:08 ` Dharmik Thakkar
2019-04-01 23:08 ` [dpdk-dev] [PATCH v4 1/2] hash: add lock free support for extendable bucket Dharmik Thakkar
2019-04-01 23:08 ` Dharmik Thakkar
2019-04-01 23:08 ` [dpdk-dev] [PATCH v4 2/2] test/hash: lock-free rw concurrency test ext bkt Dharmik Thakkar
2019-04-01 23:08 ` Dharmik Thakkar
2019-04-02 0:57 ` Thomas Monjalon
2019-04-02 0:57 ` Thomas Monjalon
2019-04-02 19:44 ` Dharmik Thakkar [this message]
2019-04-02 19:44 ` Dharmik Thakkar
2019-04-02 19:44 ` [dpdk-dev] [PATCH v5 0/2] hash: add lock free support for " Dharmik Thakkar
2019-04-02 19:44 ` Dharmik Thakkar
2019-04-02 19:44 ` [dpdk-dev] [PATCH v5 1/2] hash: add lock free support for extendable bucket Dharmik Thakkar
2019-04-02 19:44 ` Dharmik Thakkar
2019-04-02 19:44 ` [dpdk-dev] [PATCH v5 2/2] test/hash: lock-free rw concurrency test ext bkt Dharmik Thakkar
2019-04-02 19:44 ` Dharmik Thakkar
2019-04-03 18:56 ` [dpdk-dev] [PATCH v5 0/2] hash: add lock free support for " Thomas Monjalon
2019-04-03 18:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83121B26-F2A5-4342-ADE1-E77651808A59@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).