From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50050.outbound.protection.outlook.com [40.107.5.50]) by dpdk.org (Postfix) with ESMTP id AACB67D52 for ; Tue, 2 Apr 2019 21:44:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXCwnO14C57YM/RxHmPfQKsOU4mVq7U0CrdRu3G9c5Q=; b=o9QxLcDL5TkCDQ58lBHImex1kl0CKOX36zvaXpqDlpNVsPia4R62PbvwGef6A5347KanNk0lCWm0UMiDAYbuG6VcJuMrCoR6kWMGQacP3ENaF4Q9j6wUcjiVAQrNTevQMbb3tn5Fmo5u+qe1i6P05WEgwiW3e2Qlm8W0tdrbxVc= Received: from AM0PR08MB3379.eurprd08.prod.outlook.com (20.177.109.142) by AM0PR08MB3841.eurprd08.prod.outlook.com (20.178.23.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.19; Tue, 2 Apr 2019 19:44:28 +0000 Received: from AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::287d:1c71:2689:7bfe]) by AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::287d:1c71:2689:7bfe%5]) with mapi id 15.20.1750.017; Tue, 2 Apr 2019 19:44:28 +0000 From: Dharmik Thakkar To: "thomas@monjalon.net" CC: "dev@dpdk.org" , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v4 2/2] test/hash: lock-free rw concurrency test ext bkt Thread-Index: AQHU6N/clgNnWq5z/EK9vZvxBErC56YoDGGAgAE61YA= Date: Tue, 2 Apr 2019 19:44:27 +0000 Message-ID: <83121B26-F2A5-4342-ADE1-E77651808A59@arm.com> References: <20190401221836.16599-1-dharmik.thakkar@arm.com> <20190401230830.17931-1-dharmik.thakkar@arm.com> <20190401230830.17931-3-dharmik.thakkar@arm.com> <2434371.7uYfYzBtHE@xps> In-Reply-To: <2434371.7uYfYzBtHE@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dharmik.Thakkar@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac8c4976-2343-40c9-7a97-08d6b7a39e22 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR08MB3841; x-ms-traffictypediagnostic: AM0PR08MB3841: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(376002)(396003)(136003)(199004)(189003)(106356001)(14444005)(25786009)(476003)(305945005)(11346002)(478600001)(76176011)(486006)(81166006)(6486002)(72206003)(99286004)(256004)(68736007)(229853002)(6506007)(7736002)(102836004)(2616005)(6512007)(66066001)(53546011)(26005)(3846002)(86362001)(446003)(2906002)(6116002)(5640700003)(82746002)(1730700003)(5660300002)(71200400001)(36756003)(71190400001)(93886005)(83716004)(186003)(6436002)(8676002)(4326008)(8936002)(2501003)(54906003)(81156014)(53936002)(316002)(97736004)(105586002)(4744005)(6246003)(33656002)(2351001)(6916009)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3841; H:AM0PR08MB3379.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: e0LHU3BKutnIMXoVcsGBeucOBbE/edn4mz8BRiXfXpYFIA7Y3fhTzq6vo2RzU1gTau/Cv+KR7IQ3TNAfqVM+Dy25ckTPizuilTzjzVwWKfGtEX4mlZW82Yxnofpq6pqAsUYw7m1wHtaiALkSjxzCc96iNyaHywfyoxT3q0ux5w9+kdQjYDnR50ph9k59PM8CdRpNY26BqP3jEUbk2A4mXekYfEvMTJim8Jkk9FRTrZEvm0YQXEhsseCf069UltXpT4y/pPF4lU11xJQ0m3Pt2K9P/UgNqvNpSVyMve9dMkJuJubgS1kFNj/IszrYLQNfxmZCpMZUD4Zr6wobxcFhvqwMC2s9jiJRM72asNYIJtRblliFz4RLR32yjpGn7xozUylRpQiT5uUkxBtEjw6uifIFUoC37SElTaqYJH2hUmc= Content-Type: text/plain; charset="us-ascii" Content-ID: <8DD09FD39CC64941B3B0A78F3D2D7478@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac8c4976-2343-40c9-7a97-08d6b7a39e22 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 19:44:27.8774 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3841 Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/hash: lock-free rw concurrency test ext bkt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 19:44:29 -0000 Hi Thomas, Thank you for the review! > On Apr 1, 2019, at 7:57 PM, Thomas Monjalon wrote: >=20 > 02/04/2019 01:08, Dharmik Thakkar: >> Add unit test to check for hash lookup and bulk-lookup perf for >> extendable bucket feature. >> It is tested with both lock-free enabled and lock-free disabled case. >>=20 >> Test includes: >>=20 >> - hash lookup on keys in ext bkt >> - hash delete causing key-shifts of keys from ext bkt to secondary bkt >>=20 >> Suggested-by: Honnappa Nagarahalli >> Signed-off-by: Dharmik Thakkar >> Acked-by: Yipeng Wang >> --- >> v4: >> - Add Acked-by tag. >=20 > FYI, no need to send a new version just for this. Sure, thanks! >=20 > Please run devtools/test-meson-builds.sh. > When building build-clang-static, I see this error: >=20 > app/test/test_hash_readwrite_lf.c:670:13: error: > variable 'key_cnt' is used uninitialized whenever 'if' condition is false Will resolve and update. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 98096A0679 for ; Tue, 2 Apr 2019 21:44:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33D741B11A; Tue, 2 Apr 2019 21:44:31 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50050.outbound.protection.outlook.com [40.107.5.50]) by dpdk.org (Postfix) with ESMTP id AACB67D52 for ; Tue, 2 Apr 2019 21:44:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXCwnO14C57YM/RxHmPfQKsOU4mVq7U0CrdRu3G9c5Q=; b=o9QxLcDL5TkCDQ58lBHImex1kl0CKOX36zvaXpqDlpNVsPia4R62PbvwGef6A5347KanNk0lCWm0UMiDAYbuG6VcJuMrCoR6kWMGQacP3ENaF4Q9j6wUcjiVAQrNTevQMbb3tn5Fmo5u+qe1i6P05WEgwiW3e2Qlm8W0tdrbxVc= Received: from AM0PR08MB3379.eurprd08.prod.outlook.com (20.177.109.142) by AM0PR08MB3841.eurprd08.prod.outlook.com (20.178.23.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.19; Tue, 2 Apr 2019 19:44:28 +0000 Received: from AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::287d:1c71:2689:7bfe]) by AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::287d:1c71:2689:7bfe%5]) with mapi id 15.20.1750.017; Tue, 2 Apr 2019 19:44:28 +0000 From: Dharmik Thakkar To: "thomas@monjalon.net" CC: "dev@dpdk.org" , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v4 2/2] test/hash: lock-free rw concurrency test ext bkt Thread-Index: AQHU6N/clgNnWq5z/EK9vZvxBErC56YoDGGAgAE61YA= Date: Tue, 2 Apr 2019 19:44:27 +0000 Message-ID: <83121B26-F2A5-4342-ADE1-E77651808A59@arm.com> References: <20190401221836.16599-1-dharmik.thakkar@arm.com> <20190401230830.17931-1-dharmik.thakkar@arm.com> <20190401230830.17931-3-dharmik.thakkar@arm.com> <2434371.7uYfYzBtHE@xps> In-Reply-To: <2434371.7uYfYzBtHE@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dharmik.Thakkar@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac8c4976-2343-40c9-7a97-08d6b7a39e22 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR08MB3841; x-ms-traffictypediagnostic: AM0PR08MB3841: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(376002)(396003)(136003)(199004)(189003)(106356001)(14444005)(25786009)(476003)(305945005)(11346002)(478600001)(76176011)(486006)(81166006)(6486002)(72206003)(99286004)(256004)(68736007)(229853002)(6506007)(7736002)(102836004)(2616005)(6512007)(66066001)(53546011)(26005)(3846002)(86362001)(446003)(2906002)(6116002)(5640700003)(82746002)(1730700003)(5660300002)(71200400001)(36756003)(71190400001)(93886005)(83716004)(186003)(6436002)(8676002)(4326008)(8936002)(2501003)(54906003)(81156014)(53936002)(316002)(97736004)(105586002)(4744005)(6246003)(33656002)(2351001)(6916009)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3841; H:AM0PR08MB3379.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: e0LHU3BKutnIMXoVcsGBeucOBbE/edn4mz8BRiXfXpYFIA7Y3fhTzq6vo2RzU1gTau/Cv+KR7IQ3TNAfqVM+Dy25ckTPizuilTzjzVwWKfGtEX4mlZW82Yxnofpq6pqAsUYw7m1wHtaiALkSjxzCc96iNyaHywfyoxT3q0ux5w9+kdQjYDnR50ph9k59PM8CdRpNY26BqP3jEUbk2A4mXekYfEvMTJim8Jkk9FRTrZEvm0YQXEhsseCf069UltXpT4y/pPF4lU11xJQ0m3Pt2K9P/UgNqvNpSVyMve9dMkJuJubgS1kFNj/IszrYLQNfxmZCpMZUD4Zr6wobxcFhvqwMC2s9jiJRM72asNYIJtRblliFz4RLR32yjpGn7xozUylRpQiT5uUkxBtEjw6uifIFUoC37SElTaqYJH2hUmc= Content-Type: text/plain; charset="UTF-8" Content-ID: <8DD09FD39CC64941B3B0A78F3D2D7478@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac8c4976-2343-40c9-7a97-08d6b7a39e22 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 19:44:27.8774 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3841 Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/hash: lock-free rw concurrency test ext bkt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402194427.Kc9cjP2N0fx9u_lyNLp2pbMnkJE0K4p95H7mPNdDvGQ@z> Hi Thomas, Thank you for the review! > On Apr 1, 2019, at 7:57 PM, Thomas Monjalon wrote: >=20 > 02/04/2019 01:08, Dharmik Thakkar: >> Add unit test to check for hash lookup and bulk-lookup perf for >> extendable bucket feature. >> It is tested with both lock-free enabled and lock-free disabled case. >>=20 >> Test includes: >>=20 >> - hash lookup on keys in ext bkt >> - hash delete causing key-shifts of keys from ext bkt to secondary bkt >>=20 >> Suggested-by: Honnappa Nagarahalli >> Signed-off-by: Dharmik Thakkar >> Acked-by: Yipeng Wang >> --- >> v4: >> - Add Acked-by tag. >=20 > FYI, no need to send a new version just for this. Sure, thanks! >=20 > Please run devtools/test-meson-builds.sh. > When building build-clang-static, I see this error: >=20 > app/test/test_hash_readwrite_lf.c:670:13: error: > variable 'key_cnt' is used uninitialized whenever 'if' condition is false Will resolve and update.