From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 191CA5F11 for ; Mon, 3 Sep 2018 17:39:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2018 08:39:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,325,1531810800"; d="scan'208";a="86800539" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 03 Sep 2018 08:39:17 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.210]) by fmsmsx107.amr.corp.intel.com ([169.254.6.151]) with mapi id 14.03.0319.002; Mon, 3 Sep 2018 08:39:15 -0700 From: "Wiles, Keith" To: Ilya Maximets CC: "dev@dpdk.org" , "Wu, Jingjing" , "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Xing, Beilei" , "Zhang, Qi Z" , "Wang, Xiao W" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [RFC 2/2] drivers/net: use sleep delay by default for intel NICs Thread-Index: AQHUQ5s5HFpVM2Ft1U6850iJHABsoqTfJqoA Date: Mon, 3 Sep 2018 15:39:15 +0000 Message-ID: <832A4FA5-2615-4CD1-8B48-0176557BE6E6@intel.com> References: <20180831124517.27619-1-i.maximets@samsung.com> <20180831124404eucas1p20daff43600dfe450c9106616f886eab4~P_LLRV5aM1664316643eucas1p2w@eucas1p2.samsung.com> <20180903153131eucas1p122e24d751d0f87d0cff88f3360c50e37~Q7ZOaSu4X0341203412eucas1p1A@eucas1p1.samsung.com> In-Reply-To: <20180903153131eucas1p122e24d751d0f87d0cff88f3360c50e37~Q7ZOaSu4X0341203412eucas1p1A@eucas1p1.samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.220.39] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC 2/2] drivers/net: use sleep delay by default for intel NICs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 15:39:24 -0000 > On Sep 3, 2018, at 4:33 PM, Ilya Maximets wrote: >=20 > On 03.09.2018 18:14, Wiles, Keith wrote: >>=20 >>=20 >>> On Aug 31, 2018, at 1:45 PM, Ilya Maximets wro= te: >>>=20 >>> NICs uses different delays up to a second during their >>> configuration. It makes no sense to busy-wait so long wasting >>> CPU cycles and preventing any other threads to execute on the >>> same CPU core. These busy polling are the rudiments that came >>> from the kernel drivers where you can not sleep in interrupt >>> context, but as we're in userspace, we're able and should >>> sleep to allow other threads to run. >>> Delays never called on rx/tx path, so this should not affect >>> performance. >>=20 >> I have a question, the only thread being effected by the busy wait is th= e thread assigned to the core or the master lcore in the case of rte_eal_in= it(). It should not effect other threads running on other cores, right? If = you do have other threads running in the same code then I see the need, ple= ase help me understand the use and how it is effecting DPDK. >=20 > Originally, this patch comes from this issue: > http://mails.dpdk.org/archives/dev/2018-August/110640.html >=20 > non-EAL threads is one of the answers. > For example, main thread in OVS periodically checks the link statuses > and hangs there busy waiting on different NIC configuration operations. We have link state get no wait why is that not working instead of wait poll= ing the line state? > Also, main OVS tread is responsible for port configuration and > re-configuration. There are few other in-dpdk threads like interrupts > handling thread (alarm handling thread). vhost_thread is working on > the same lcores and wants some time to work too. >=20 > In case of hyperthreading busy-waiting will significantly affect > threads on the siblings. >=20 > Best regards, Ilya Maximets. >=20 >>>=20 >>> Signed-off-by: Ilya Maximets >>> --- >>> drivers/net/avf/Makefile | 1 + >>> drivers/net/avf/base/avf_osdep.h | 4 ++-- >>> drivers/net/e1000/Makefile | 1 + >>> drivers/net/e1000/base/e1000_osdep.h | 2 +- >>> drivers/net/i40e/base/i40e_osdep.h | 6 +++--- >>> drivers/net/ifc/base/ifcvf_osdep.h | 2 +- >>> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 +- >>> 7 files changed, 10 insertions(+), 8 deletions(-) >>>=20 >>> diff --git a/drivers/net/avf/Makefile b/drivers/net/avf/Makefile >>> index 3f815bbc4..8ee707529 100644 >>> --- a/drivers/net/avf/Makefile >>> +++ b/drivers/net/avf/Makefile >>> @@ -9,6 +9,7 @@ include $(RTE_SDK)/mk/rte.vars.mk >>> LIB =3D librte_pmd_avf.a >>>=20 >>> CFLAGS +=3D -O3 >>> +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API >>> LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring >>> LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash >>> LDLIBS +=3D -lrte_bus_pci >>> diff --git a/drivers/net/avf/base/avf_osdep.h b/drivers/net/avf/base/av= f_osdep.h >>> index 9ef45968e..442a5acd0 100644 >>> --- a/drivers/net/avf/base/avf_osdep.h >>> +++ b/drivers/net/avf/base/avf_osdep.h >>> @@ -93,8 +93,8 @@ typedef uint64_t u64; >>> #define avf_memset(a, b, c, d) memset((a), (b), (c)) >>> #define avf_memcpy(a, b, c, d) rte_memcpy((a), (b), (c)) >>>=20 >>> -#define avf_usec_delay(x) rte_delay_us(x) >>> -#define avf_msec_delay(x) rte_delay_us(1000*(x)) >>> +#define avf_usec_delay(x) rte_delay_us_sleep(x) >>> +#define avf_msec_delay(x) avf_usec_delay(1000 * (x)) >>>=20 >>> #define AVF_PCI_REG(reg) rte_read32(reg) >>> #define AVF_PCI_REG_ADDR(a, reg) \ >>> diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000/Makefile >>> index 9c87e883b..0ed627656 100644 >>> --- a/drivers/net/e1000/Makefile >>> +++ b/drivers/net/e1000/Makefile >>> @@ -10,6 +10,7 @@ LIB =3D librte_pmd_e1000.a >>>=20 >>> CFLAGS +=3D -O3 >>> CFLAGS +=3D $(WERROR_FLAGS) >>> +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API >>> LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring >>> LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs >>> LDLIBS +=3D -lrte_bus_pci >>> diff --git a/drivers/net/e1000/base/e1000_osdep.h b/drivers/net/e1000/b= ase/e1000_osdep.h >>> index b8868049f..5958ea157 100644 >>> --- a/drivers/net/e1000/base/e1000_osdep.h >>> +++ b/drivers/net/e1000/base/e1000_osdep.h >>> @@ -48,7 +48,7 @@ >>>=20 >>> #include "../e1000_logs.h" >>>=20 >>> -#define DELAY(x) rte_delay_us(x) >>> +#define DELAY(x) rte_delay_us_sleep(x) >>> #define usec_delay(x) DELAY(x) >>> #define usec_delay_irq(x) DELAY(x) >>> #define msec_delay(x) DELAY(1000*(x)) >>> diff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base= /i40e_osdep.h >>> index 8e5c593c9..a6072e153 100644 >>> --- a/drivers/net/i40e/base/i40e_osdep.h >>> +++ b/drivers/net/i40e/base/i40e_osdep.h >>> @@ -233,9 +233,9 @@ struct i40e_spinlock { >>> #define i40e_memcpy(a, b, c, d) rte_memcpy((a), (b), (c)) >>>=20 >>> #define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d)) >>> -#define DELAY(x) rte_delay_us(x) >>> -#define i40e_usec_delay(x) rte_delay_us(x) >>> -#define i40e_msec_delay(x) rte_delay_us(1000*(x)) >>> +#define DELAY(x) rte_delay_us_sleep(x) >>> +#define i40e_usec_delay(x) DELAY(x) >>> +#define i40e_msec_delay(x) DELAY(1000 * (x)) >>> #define udelay(x) DELAY(x) >>> #define msleep(x) DELAY(1000*(x)) >>> #define usleep_range(min, max) msleep(DIV_ROUND_UP(min, 1000)) >>> diff --git a/drivers/net/ifc/base/ifcvf_osdep.h b/drivers/net/ifc/base/= ifcvf_osdep.h >>> index cf151ef52..6aef25ea4 100644 >>> --- a/drivers/net/ifc/base/ifcvf_osdep.h >>> +++ b/drivers/net/ifc/base/ifcvf_osdep.h >>> @@ -17,7 +17,7 @@ >>> #define DEBUGOUT(S, args...) RTE_LOG(DEBUG, PMD, S, ##args) >>> #define STATIC static >>>=20 >>> -#define msec_delay rte_delay_ms >>> +#define msec_delay(x) rte_delay_us_sleep(1000 * (x)) >>>=20 >>> #define IFCVF_READ_REG8(reg) rte_read8(reg) >>> #define IFCVF_WRITE_REG8(val, reg) rte_write8((val), (reg)) >>> diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/b= ase/ixgbe_osdep.h >>> index bb5dfd2af..94ede9bc2 100644 >>> --- a/drivers/net/ixgbe/base/ixgbe_osdep.h >>> +++ b/drivers/net/ixgbe/base/ixgbe_osdep.h >>> @@ -51,7 +51,7 @@ >>>=20 >>> #define ASSERT(x) if(!(x)) rte_panic("IXGBE: x") >>>=20 >>> -#define DELAY(x) rte_delay_us(x) >>> +#define DELAY(x) rte_delay_us_sleep(x) >>> #define usec_delay(x) DELAY(x) >>> #define msec_delay(x) DELAY(1000*(x)) >>>=20 >>> --=20 >>> 2.17.1 >>>=20 >>=20 >> Regards, >> Keith Regards, Keith