From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 4EF401BAFB for ; Fri, 11 Jan 2019 20:50:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 11:50:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,466,1539673200"; d="scan'208";a="133787764" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 11 Jan 2019 11:50:58 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 11 Jan 2019 11:50:58 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.160]) by fmsmsx115.amr.corp.intel.com ([169.254.4.199]) with mapi id 14.03.0415.000; Fri, 11 Jan 2019 11:50:58 -0800 From: "Wiles, Keith" To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs Thread-Index: AQHUqdiP/O6PEJxiYUy96F/HcDLXhqWq/HSAgAADcICAAAB3gA== Date: Fri, 11 Jan 2019 19:50:57 +0000 Message-ID: <832D25F2-DEC4-4404-8A9F-4043D7609936@intel.com> References: <20190111180659.5972-1-stephen@networkplumber.org> <20190111180659.5972-4-stephen@networkplumber.org> <14FED5CB-5C2B-452D-BD47-6303EF67F90A@intel.com> <20190111114917.06da84bb@hermes.lan> In-Reply-To: <20190111114917.06da84bb@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.35.122] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 19:50:59 -0000 > On Jan 11, 2019, at 1:49 PM, Stephen Hemminger wrote: >=20 > On Fri, 11 Jan 2019 19:37:00 +0000 > "Wiles, Keith" wrote: >=20 >>> +/* make sure name is a possible Linux network device name */ >>> +static bool is_valid_iface(const char *name) =20 >>=20 >> I am sorry, but the function name must be on the next line as per the st= yle. I know you do not like it, but that is what the style states. >=20 > I am surprised because most of the DPDK follows kernel style. > And in kernel style one line is preferred if line is not too long. Last time I looked at the DPDK coding style it is not the case. We do not r= eally follow Linux coding style only started with it and made changes :-( Regards, Keith