From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B491744079; Mon, 20 May 2024 19:51:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E1B040687; Mon, 20 May 2024 19:51:47 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2074.outbound.protection.outlook.com [40.107.236.74]) by mails.dpdk.org (Postfix) with ESMTP id 0860B402EF for ; Mon, 20 May 2024 19:51:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nkrG7wvPA+vjMX5fIl0gY5eWhbCgQ8tPOQJ0hTCLRfjb7i8DkR7JCdpr5W7z3eiVuEpo1geK2nemImiygGDEKCi7I6HlyN68l8LfnELAtcFuJnSmppS4W2kv8OGOm9I+jaCwMA1qYM6Oh546Hrw7CIMzfYALeoU2RyUha9TyWB6oRdIekcZkPkFby0GnKkvCTUpJlmhrg4wDxSBvghwdBiPvPEouUC2WHWwV7a9VrAm8kiN4mc41uJ7V5tq4scZFlm3XXBEIkDtKjpM1zLY/oT2oAttGnNKPHYD7hC6BZ14XO9Di6rIzvPzQxIQ8l0GjDp/rlDHxrGHw6TVd9gdhIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ssU+XDS2/cKgsfMRwKrTrpg31l32+aTG00c6ANv1g3I=; b=MVV1qVubBEAa37fTU74uKTsYH+rH3BYi7kG/es7C+6kZcn8ZW9O8arbW8b+eTlETuJ6tUh0Efjz5KjMPAzgGZ3vJ535VHoZevKMsaA2AEty47XbFSXIvyQkvHYBGhD13WwQ4wy0xeky+wHgtqRUnsZPRM0ua3pGjHERl1WyL1dnK8I7YQ15fb7dwI/+H+nrRb26MY+ujEtSI7X1paYlIHthzzALxzAu37z2xYUtE71xkxYHcuCxZZjnci2U7p4drvXPXVMActP4/H/kvKDve12zflFweReun/VcxCwXk6AxQK3IiqlwZcCTnGSgRHHKiR+lJ3kV5LFULSo/MVvMWuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ssU+XDS2/cKgsfMRwKrTrpg31l32+aTG00c6ANv1g3I=; b=Dy6bDhheHqAqfuwgTCKkR/EYudoVpa8HP2ZKkruEFoNAMKnKApzVkcKOGu7tQyWpXZfdX0t1DWoNkSHLTzRUmCfdryJVoMVp9fHCKHWq7b1bfCmU+4AbWbw0bnupq44zJgL62mhaN6Qah4qJ/CFfsc5Nn/uMzeOu4/b68qEwkE0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB8223.namprd12.prod.outlook.com (2603:10b6:208:3f3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 17:51:43 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 17:51:41 +0000 Message-ID: <832e7060-1d2d-4a70-a32c-b4ce729fb357@amd.com> Date: Mon, 20 May 2024 18:51:37 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 09/12] net/tap: simplify internals To: Stephen Hemminger , dev@dpdk.org References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-10-stephen@networkplumber.org> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240502213618.11391-10-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0331.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::31) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB8223:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a6c3f79-7587-43a9-e7f1-08dc78f58159 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WXY3SWw1UkhzdjQrVk1melVRZ3AzY2czNE5XZi9hYXpqN2VUeXpWbzNkUGZw?= =?utf-8?B?YmFJMnZCN29sT2t4cXcxWEJBZVBVZW9VUi9KOTU1V3lIZnkzWkFFRTAzNE13?= =?utf-8?B?TE9pZk5ybndqeUM5aUI0Y1ZackZWdFQ0cCtINVl6R0FtVEhzRmVzYy9tT0x6?= =?utf-8?B?dkcxenUydDZqTDhXRnN4WXZDSnp0d0srdG03SXc3cm1LczZJVXJtOTNJZGx0?= =?utf-8?B?dGI4aUYzV3hvUWUwZi9VcGRyQ2c5aGpxZGtObno4QmJUSEdYL3NDamJoc0dY?= =?utf-8?B?V3pYZXpOVGlPMGpQQStjMC9GUXFqMzBnOTYvRnBZa2E2QnlDamhJSTJMSVIy?= =?utf-8?B?RS9xU2hpdlYrY09NZ2poSXdMRHloaXlkK0hUVHVVd0Z4VitsbXZVcWRRaGxu?= =?utf-8?B?djlsdy8vTm5MUkRBWFRCQ0lwTlVEZ21wTitRWk1xWEQ4bU02VUp2MmZQSjFx?= =?utf-8?B?VFhJcCt5azNoR2wyNHJZY0FsY0h4cElXdUhSSDBtWkdKVGM4Y2ZsRHNVMnhm?= =?utf-8?B?ZGFjb3JuZlJoY3pvMjdNTUxsK2FTWXB6eExrb3F3aGlkd0JFR1VsTHN0ZVc5?= =?utf-8?B?ckM3QVpTMjRiWU82WnhhbUZKYi9aZjIveW15ZFY1YklRVGR6S3JJTVJuQnhV?= =?utf-8?B?MVZNNDRDQ3VCYjNJVm1jeklVaHZkaG0yTXRRejZuQUYzd1lYWVZVK2NVVG8r?= =?utf-8?B?aDlhNGR0R0dTdURJdWdFVEtGSzI5ZFp2T3cxeDNmZVgyMXlKRE5lVnFKbDNG?= =?utf-8?B?TkhwSFltdmdPQ2VRY0xNbnVSU2RhQXBnYXJuV3VRam93YzQ3RTY2SHBIUm9a?= =?utf-8?B?WGtkdW5BbURnbitwaWIycXpCK0QwdkdFbTRISm5rZzZJYWtFYWJUcmFBQXBr?= =?utf-8?B?bDFnQm1RYmtGY0ZyY0o4M1BKWm9Gb0JkWXBDK0lIcGFseTBiNWc5REpEMDZQ?= =?utf-8?B?VWdsdWNwem1iOEhUMm45bTVHc1lPRzFET3A0K2ErN053RWdPYTJkazNBaVhp?= =?utf-8?B?UmhxSEtFU3VPVU1uZlJnbnZiSWZnZzBiZE16dGdvTzgraE5oN2t4cTNzQmQ3?= =?utf-8?B?S1NTMTkxSlo5TUZ2bWxBc2J1YVJQRVRFVTk4K1U4TnhCcno4T0NmSGYyVXE2?= =?utf-8?B?aE9JZVBuWVp0bkgrajlCZ3dHQ2N0dWV3RXZ3ZDBFOThCWTJjV1pidUpsZUpv?= =?utf-8?B?SVU1dUhiZzE3WXJzS2doaG0yVVR1TWI1ekhxMDUxUWtxM2hKcFpkNkpFemdZ?= =?utf-8?B?aXVKcThOVkpFbWFvVzlybjMvSEZkSjlDcGtzQTJqdCtwNGFXRTBtZ0tibmlS?= =?utf-8?B?L0JPUTA3Ris4alN3bk9sckhRaFRTTnRRbUpNKzA3Qjl5Z3gxcDA3d1djVUdy?= =?utf-8?B?OGpKT215YWFoc2xnZ1RtQ3pRV0U1ay9xR3IyUU9QckJvemd5L2QxdlN3NlV2?= =?utf-8?B?M3ZvNEtFeXJFa2w0RzNkcXdQVmVobTdqampYNVpYRG5PWVY0VTF2bFd1anVw?= =?utf-8?B?TUkvRXJDOEcwUXo2bkNCbDAwdFpvbndFa0tld1gvSVRqZTByeEtoTHlET01y?= =?utf-8?B?aGNEZG9oSEdhK0RLZWkyVXNNc1NWRG1EdkNka3VpZzNlWStSTTNnSm43d2p3?= =?utf-8?B?RkpBQmJUUjg0S045REMyRHJYRU44eUE3bGM0ODJMWTJ6emlobjlJdWhjaUhU?= =?utf-8?B?clZjV2w1NVlLWHBMcTNaK2xka09FNENjQ2UybHRScDBlZVUrVXE2ZldRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHdadkJWZ0lCeTUwcTZtZjl2eEFwbzQyV0N0c1pyWnpMV3ArTkVGZXZzT1ly?= =?utf-8?B?aXhUK2NTaHEvNyt1TlMyMzFUMWxXOVFPc20weFlrUDVnbW5PYjBzNktwakZ2?= =?utf-8?B?UFdqZmpsbFJFbmJJSytzVzEzODFkTDVqSXpnR1FzeUdWLzI4NkxDVjIxQ1hU?= =?utf-8?B?OWVkOUNOYkU0cWgyRHhkbnZMRmhReEJHREwrQmhrejFLUjZTemRuSy84Qk9W?= =?utf-8?B?cTZ0ZXE1a2wxZkNYNlFDb1JPYkFuQlhiWXZWNzFNUUpaRFp3ZVpHRVNvZEVi?= =?utf-8?B?MlV4Y2V6QkJJVG5sbzdwcVhFd0RtNVljbitCdWFVcm1tTjJmei92cW9DWURu?= =?utf-8?B?SyswZG1NTlB4dTRqNDhYbmIyUEtGUjQ2cmo5VXRnWHpNWExUcndQam93TVMr?= =?utf-8?B?aHF1NGI5WFFXTkdrM25wVitDdEZiYzVUQm9XV25FZTBBS2d0cm9xMU5jRFBF?= =?utf-8?B?RERteGRSRFQrcWw1VFVRS0dOK2Q5MVJFeURSSHhnVDMzOUcxMlRjbjd0SGx0?= =?utf-8?B?ak93UGNjdzVkRy9YVlQ1SWFHRFNSZ3dqRFBpVmR2cTc3Zmszd3FQME1NRkc3?= =?utf-8?B?Q3kvcC9rV21MTEd4bGNHN0JlazBMWmNqb2hnMVluWkpIbXhRWWh3ZGlobnY3?= =?utf-8?B?Qi9rd1FnY3dOOW1SUG1JL3hPM1RuelJzLzVkUTFrVmo2S2ZmV2N2bnFQMlI4?= =?utf-8?B?TVpqK2N3Y1poMDRZZGhsQVZuVzlYcm81RkVqTHRmeit1OUcxMExEcnRsbU84?= =?utf-8?B?Mlp2MkhIN2VKOXdJVU0xSWh2RkhDKy90azh3K1QxN29STFJldXIyU0ZqTU9Z?= =?utf-8?B?cmJROVc0b0xmd3BrVmwrRGo3alVGbkIrNEFTUTVjcWttZWY1SjVKMTdIOVZp?= =?utf-8?B?emNodG43U3R2MzZwc083QVk1WVlwMnhGOHpVRnFDMzAwc054M1l3QS9FKzdy?= =?utf-8?B?UXBhTEVFNEFNWHRjREtjdnZPTnE1YnE3R1EzOVRBbnluRjJ6SWZTbzBTMHNs?= =?utf-8?B?alNsWGRUUmFvUVpobWM2NDZpYU1SRDN0UFVBemd5VVVtbldPRm5pWHIzWEtN?= =?utf-8?B?MGtZRnBzUFJPQ1ppRUVzQVRkazRzVVJFU2hrbUhnaldKT0lEUS9CNXFlV3Fq?= =?utf-8?B?aVVSbml2NUFRdXZQalhYMlBWclpmcytGODc5dU5HV04wVWdVSXFIdXd3aWJD?= =?utf-8?B?VldGamExbllzK0hxZHBnZ2ZZUmNyTHhpYjNGSFpPN2dsR1M1clU3bWt3bVBy?= =?utf-8?B?ZEJuMkVFdHJsRXZyTWZmREFTVjdJeEgwa2grcDgrQk16S2M2MG9nSU5TRTBP?= =?utf-8?B?d0NLd0haVXliMmJWcEw2a29jOTd6bDFITGpkQ0R4RzIxYjN4N1crYTFlWkYz?= =?utf-8?B?TDRNdGpZS2Myai9qeitEZEVyeVVvNHhzRUFCOExJeXVNd3FSYyt3T08xZU9q?= =?utf-8?B?b0U4L0p5KzU5ZnhZVjlJSkh1bDF6b0FENDNNRGhSTzNYWDVmTWNpZERNUlN6?= =?utf-8?B?TDl4MFRwZW16SzNHRFNwbVM2cys2M1B3WUphb0FvWkZaRzYvQ1FjTUlTYlRq?= =?utf-8?B?WUptQmoxOW1KUXp3QzdxN0FhWDhZd2EvMERJNXVNSW9XckVEbCtvdmhqZVJQ?= =?utf-8?B?UEJPdjZlYnp2WG5KejUyMERnYldkeG9TNWRZUHA4enFSajlDdUVod2dYcFV5?= =?utf-8?B?bzh4VUl5ZnpPaDZOT0k1MXh1V1ppeHE5ZGFjWW5uRjZOZEF1cS9ubVJhZU9j?= =?utf-8?B?R0daVUNVRHh6OXRjU1FsUm8rV05Ra1ROMjgveU1WZVpSYzBJWlZUelVyMk8z?= =?utf-8?B?VW1MKzhydFJDSXBaWTZRNk1nRHAxOGwrZ0cwZW45WWVUMUY0RkVZVkNqNFll?= =?utf-8?B?elg0RDk4YW4vNXVqY214K1NMUzN1OVJuZ1NzUTU0RUpXZm9jMVV3TGVFRU9t?= =?utf-8?B?d3JjclA3ZXE3cVJFdHpKMllGbkZtU1ZGSjY1Q0tPNGNnVHlsejZLckVMK2hE?= =?utf-8?B?akJFL2MvRkNjZmJtUmVYVGhFY1V2M0dVTzVrODN3bDU2NU1BenRaWFRQbTdK?= =?utf-8?B?dkVTcCs3WEVRemQ3T09lRDJHRVhSb2QzeXFrSjJWZlRmQUhLZ0ZLMkg2K25N?= =?utf-8?Q?Jd+UUqiGfFWC3rUmHkvzXketD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a6c3f79-7587-43a9-e7f1-08dc78f58159 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 17:51:41.3937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kDhQQL3VHyePhAwNlzfsF02QQHQGr6KKL4PzDiLSihmaqLsWNyEmaQgRnuZlqcIL X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8223 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > The names of Linux network devices are IFNAMSIZ(16) not the > same as DPDK which has up to 64 characters. Don't need to > hold onto the whole ifreq to save the remote interface flags. > > Make sure packet and byte counters are read once, so that global > and per-queue values add up. No need for separate rx_nombuf counter > since there is an alloc_failed value in ethdev. > > Keep only the statistics that are used. I.e no ipackets on > tx queues etc. > This patch does multiple things, although each not very complex, I think splitting the patch makes it simpler to review. > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth_tap.c | 138 ++++++++++++++++++---------------- > drivers/net/tap/rte_eth_tap.h | 22 +++--- > 2 files changed, 83 insertions(+), 77 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index d847565073..3614aaf1dc 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -46,6 +46,11 @@ > #include > #include > > +/* Used to snapshot statistics */ > +#ifndef READ_ONCE > +#define READ_ONCE(var) (*((volatile typeof(var) *)(&(var)))) > +#endif > + > Why 'READ_ONCE' is required? As it is a function that provides pointer as parameter, won't stat values will be read from memory anyway? <...> > @@ -748,9 +754,8 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > } > } > > - txq->stats.opackets += num_packets; > - txq->stats.errs += nb_pkts - num_tx; > As I commented before, we can't just drop this. Please check code in the function that has comment: "/* stats.errs will be incremented */" That code relies on this update, if we remove here something should replace it. <...> > struct pmd_internals { > struct rte_eth_dev *dev; /* Ethernet device. */ > - char remote_iface[RTE_ETH_NAME_MAX_LEN]; /* Remote netdevice name */ > - char name[RTE_ETH_NAME_MAX_LEN]; /* Internal Tap device name */ > + char remote_iface[IFNAMSIZ]; /* Remote netdevice name */ > + char name[IFNAMSIZ]; /* Internal Tap device name */ > int type; /* Type field - TUN|TAP */ > int persist; /* 1 if keep link up, else 0 */ > struct rte_ether_addr eth_addr; /* Mac address of the device port */ > - struct ifreq remote_initial_flags;/* Remote netdevice flags on init */ > + uint16_t remote_flags; /* Remote netdevice flags on init */ > int remote_if_index; /* remote netdevice IF_INDEX */ > int if_index; /* IF_INDEX for the port */ > int ioctl_sock; /* socket for ioctl calls */ > + int ka_fd; /* keep-alive file descriptor */ > > #ifdef HAVE_TCA_FLOWER > int nlsk_fd; /* Netlink socket fd */ > @@ -88,12 +85,11 @@ struct pmd_internals { > /* implicit rte_flow rules set when a remote device is active */ > LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows; > #endif > + struct rte_intr_handle *intr_handle; /* LSC interrupt handle. */ > + struct rte_mempool *gso_ctx_mp; /* Mempool for GSO packets */ > > struct rx_queue rxq[RTE_PMD_TAP_MAX_QUEUES]; /* List of RX queues */ > struct tx_queue txq[RTE_PMD_TAP_MAX_QUEUES]; /* List of TX queues */ > - struct rte_intr_handle *intr_handle; /* LSC interrupt handle. */ > - int ka_fd; /* keep-alive file descriptor */ > - struct rte_mempool *gso_ctx_mp; /* Mempool for GSO packets */ > }; > > Are the order of fields changed intentionally, for a specific reason?