From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id 03D0C5AA1 for ; Tue, 27 Jan 2015 10:29:48 +0100 (CET) Received: by mail-we0-f169.google.com with SMTP id u56so13766582wes.0 for ; Tue, 27 Jan 2015 01:29:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=48wjYYlDuDnr0Jjb2oF6WRUpUOgnx7ffkVukMVplQcc=; b=lpghuAW64JKFxMKabr/XFSwuvdDQF3bfQwFdpTBXeKFWEXXTgxfOkysVCZQYKypIym EF7TExe0I88FT1tbmKOYLp7IZKLZz7bBUcNQ+nc930gOjFmAddP7ppJ5ZpPJ0SiBstyN L9HNjL8iUnHycpyHnu9bF9Y8xwBEYYwUHqNxGLMl5u0dpaHe9FNzahGuD6X6DEKg3VT8 IYHKxk7hwB0suYhh/KPZqiQRQ9kIYiLVd+IZeHZEPsYRwWuDlT6oy6eiAaIsgFm6naNU wtgt3iMA+obJ7N5DrWrn0ps2BNr20BL2mQk8q/qJgFcBmFXHMG+e68e4SvIkpaTHktHe stxw== X-Gm-Message-State: ALoCoQmDt3q+hibfIW2AcDyqEWvbToWwtq2BLsFtGaA/jiuJlhj3YQiQTwC9QI0njPPkYrWaBDiO X-Received: by 10.180.74.109 with SMTP id s13mr4947759wiv.33.1422350987788; Tue, 27 Jan 2015 01:29:47 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id eu8sm1346129wib.21.2015.01.27.01.29.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 01:29:47 -0800 (PST) From: Thomas Monjalon To: Cian Ferriter Date: Tue, 27 Jan 2015 10:29:21 +0100 Message-ID: <8331960.qMyqHR1SLh@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1421939108-28666-1-git-send-email-cian.ferriter@intel.com> References: <1421939108-28666-1-git-send-email-cian.ferriter@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: change socket_id passed to rte_memzone_reserve X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 09:29:48 -0000 Hi, 2015-01-22 15:05, Cian Ferriter: > Removes the dependency that this memzone reserve has on the > socket currently running on. Following the socket of the master > core will yield more predictable results when calling this > function after initialisation. You don't describe what is the problem. In another mail, you say "The original suggestion also fixes the crash that I was seeing because of memory being reserved from a numa node with no "--socket-mem" allocated." Please describe it clearly in the commit log. You should also explain what this rte_memzone_reserve() is for, and what are the incidences of your changes. Thanks -- Thomas > @@ -184,7 +184,7 @@ rte_eth_dev_data_alloc(void) > if (rte_eal_process_type() == RTE_PROC_PRIMARY){ > mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA, > RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data), > - rte_socket_id(), flags); > + rte_lcore_to_socket_id(rte_get_master_lcore()), flags);