From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <keith.wiles@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 152631B3B6
 for <dev@dpdk.org>; Wed,  3 Oct 2018 16:25:09 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 03 Oct 2018 07:25:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,336,1534834800"; d="scan'208";a="78155391"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga007.jf.intel.com with ESMTP; 03 Oct 2018 07:24:09 -0700
Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.34]) by
 fmsmsx104.amr.corp.intel.com ([169.254.3.197]) with mapi id 14.03.0319.002;
 Wed, 3 Oct 2018 07:24:09 -0700
From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Babu Radhakrishnan, AgalyaX" <agalyax.babu.radhakrishnan@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "alejandro.lucero@netronome.com"
 <alejandro.lucero@netronome.com>, "allain.legacy@windriver.com"
 <allain.legacy@windriver.com>, "Singh, Jasvinder"
 <jasvinder.singh@intel.com>, "matan@mellanox.com" <matan@mellanox.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, "Pattan, Reshma"
 <reshma.pattan@intel.com>
Thread-Topic: [PATCH v2 5/6] net/tap: disable tap build in FREEBSD
Thread-Index: AQHUWyGJSryNS2UdE0yeSJEnYosU9qUOCJSA
Date: Wed, 3 Oct 2018 14:24:09 +0000
Message-ID: <833D4A94-FB7A-44D8-B31C-C6B4862B8BEE@intel.com>
References: <1538054652-20820-1>
 <1538575221-23873-6-git-send-email-agalyax.babu.radhakrishnan@intel.com>
In-Reply-To: <1538575221-23873-6-git-send-email-agalyax.babu.radhakrishnan@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.255.74.56]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <977A9D9E32A7714094E85043D5D4AEC0@intel.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 5/6] net/tap: disable tap build in FREEBSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 14:25:10 -0000



> On Oct 3, 2018, at 9:00 AM, Babu Radhakrishnan, AgalyaX <agalyax.babu.rad=
hakrishnan@intel.com> wrote:
>=20
> Disabled tap build in FreeBSD because it is not supported
> Added changes to enable tap build if it is Linux OS and
> disable in FreeBSD.
>=20
> Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@inte=
l.com>

Thought I acked this one already.

Acked-by: Keith Wiles <keith.wiles@intel.com>

> ---
> drivers/net/tap/meson.build | 3 +++
> 1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
> index 37f65b75c..5d30cd52d 100644
> --- a/drivers/net/tap/meson.build
> +++ b/drivers/net/tap/meson.build
> @@ -1,6 +1,9 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright 2018 Luca Boccassi <bluca@debian.org>
>=20
> +if host_machine.system() !=3D 'linux'
> +        build =3D false
> +endif
> sources =3D files(
> 	'rte_eth_tap.c',
> 	'tap_bpf_api.c',
> --=20
> 2.13.6
>=20

Regards,
Keith