From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3692AA04DE; Fri, 30 Oct 2020 13:29:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B085C87A; Fri, 30 Oct 2020 13:29:23 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B5795C866; Fri, 30 Oct 2020 13:29:19 +0100 (CET) IronPort-SDR: EB9bv5psFXrW4ar2K+jWIWYkN747LwOQNeOj+p/gR4hS10ZoYCCwkD+xFAys2+MNXXHaKouXQn X9euiz92qdmA== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="148453193" X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="148453193" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 05:29:18 -0700 IronPort-SDR: 3ercEi65TlRFiYzlLVIGSPVKK0N/oyIC5BrabqRAdHfgP62dsdul+TRrNYpLcGpxUHJexypa6+ Z2sEWKlOHbVA== X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="537050173" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.23.197]) ([10.252.23.197]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 05:29:15 -0700 To: Bing Zhao , orika@nvidia.com, wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com Cc: dev@dpdk.org, stable@dpdk.org References: <1603949725-95973-1-git-send-email-bingz@nvidia.com> From: Ferruh Yigit Message-ID: <834d76c4-ebb2-e685-5c62-e2847e2255be@intel.com> Date: Fri, 30 Oct 2020 12:29:11 +0000 MIME-Version: 1.0 In-Reply-To: <1603949725-95973-1-git-send-email-bingz@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix the eCPRI command line style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/29/2020 5:35 AM, Bing Zhao wrote: > In the current implementation of eCPRI flow item parsing of the CLI, > the token items in the list are not connected properly. > A command containing "rtc_ctrl rtc_id spec 14857 rtc_id mask 0xff00" > will be considered invalid. In order to support spec with mask, the > common entry needs to be typed twice and the whole command will be > too long. > By changing the token lists, it could support spec with mask without > backing from the entry of the item. > > Fixes: 17d103cc9365 ("app/testpmd: add eCPRI in flow creation patterns") > > Cc: stable@dpdk.org > > Signed-off-by: Bing Zhao Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.