From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C0A5A00C2; Fri, 6 Jan 2023 14:41:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44BAE400EF; Fri, 6 Jan 2023 14:41:06 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id E4D30400D4 for ; Fri, 6 Jan 2023 14:41:04 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1EDFA5C00CA; Fri, 6 Jan 2023 08:41:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 06 Jan 2023 08:41:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1673012464; x= 1673098864; bh=O8Osho25Z2tpH5OKqp+3Q4m53A41CO6dzpSr2QQw8RQ=; b=s dgUwMLayo0TmD8BIB2Wy86Z0o8vsA62yKnh/M16nJ3NUKtUqMYcKnD8kfMH/WOMU 2bHUjuaPvOPT6Z30oRsAgIuwJR+BzF41GM90RVi1IA/G2s3Ug8SIVc2BDE933Dme iHKZA7AMF2BgQHVToP+iRhvPMsjGX9GaRW0P2PlCLOmHt5zcwjxzfrF+APSDSjFA rueHI8TFIK1O6Vkr0JSyscACSycotRH+qoY+91duInIRIBqk3rqDJkwYJX7ko0iR 0WIFDxHW8+SFa0MrUyMSanx6760mXvxEzZ0u+1cLxIsKKACvKX2hUwzerG/WMbVj vALktr/Vamz4m9bvGUhUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1673012464; x= 1673098864; bh=O8Osho25Z2tpH5OKqp+3Q4m53A41CO6dzpSr2QQw8RQ=; b=G G11e6DuvUw8qQ8l1X0X9B+dQcJT8rEWyhMaQtQy/YlVL9E93yBDcf6+wuvfXwhdm pvyOQnDURS4Bc5GMjDPycByTCx2cB/8f31zQy1Hg2EZkPG4LRNTvu+yZ8Dua6a5M vTLraM1szsl/DiYiI8vjQc0nLsbrvHrh1xmDoC0Quhkgn8mIlD72h+yCs/HINfAD YRP2eMpwcwhPSWzeJ3y5N/pZmMwIh1521GWHzIMRNzGiDbgH/6rb4aCui0pLsd85 jAV672QNmpMcQ4LYeGcsY7Mtbk9JCPrJp0+5nb3jC0W8hrV2rpq0Xzk41BeWAOOK JLiSHM666gf9guCawggNw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrkedtgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Jan 2023 08:41:01 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Stephen Hemminger , david.marchand@redhat.com Cc: dev@dpdk.org, Tyler Retzlaff , dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , honnappa.nagarahalli@arm.com, jerinj@marvell.com, ktraynor@redhat.com, maxime.coquelin@redhat.com Subject: Re: [PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction Date: Fri, 06 Jan 2023 14:40:59 +0100 Message-ID: <836507794.0ifERbkFSE@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8762F@smartserver.smartshare.dk> References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D8762F@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/01/2023 13:41, Morten Br=F8rup: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Friday, 6 January 2023 12.48 > >=20 > > On Thu, Jan 05, 2023 at 04:32:40PM -0800, Stephen Hemminger wrote: > > > On Thu, 5 Jan 2023 09:21:18 -0800 > > > Tyler Retzlaff wrote: > > > > > > > On Thu, Jan 05, 2023 at 10:01:31AM +0100, Thomas Monjalon wrote: > > > > > 05/01/2023 08:09, Morten Br=F8rup: > > > > > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > > > > > +/** > > > > > > > + * @warning > > > > > > > + * @b EXPERIMENTAL: this API may change, or be removed, > > without prior > > > > > > > notice > > > > > > > + * > > > > > > > + * Get the count of leading 0-bits in v. > > > > > > > + * > > > > > > > + * @param v > > > > > > > + * The value. > > > > > > > + * @return > > > > > > > + * The count of leading zero bits. > > > > > > > + */ > > > > > > > +__rte_experimental > > > > > > > +static inline unsigned int > > > > > > > +rte_clzl(unsigned long v) > > > > > > > > > > > > Don't use l (long) and ll (long long) for names (and types), > > use explicit bit lengths, 32 and 64. > > > > > > > > > > > > E.g.: rte_clz32(uint32_t v) > > > > > > > > > > I agree on using numbers. > > > > > > > > > > > > > love the idea, fewer functions too. > > > > > > > > though it is a shame we cannot adopt C11 standard because we could > > just > > > > do away with the bit suffixes entirely. > > > > > > We could but the project needs to support older RHEL releases > > > which have older tool sets. Though probably this is moot point given > > > how much meson seems to change. > >=20 > > True, though meson tends to be a bit easier to update than GCC on a > > system > > - no "pip3 install --upgrade gcc", sadly :-) > >=20 > > If we can't go all the way to C11 support, how about at least going to > > C99 > > support? As far as I know DPDK has never updated its minimum C-standard > > version, and it might be a good idea to start the process of doing so, > > even > > if it is a baby step. I am in favor of this baby step: define -std=3Dc99 porject-wise and see what are the effects during the year. > The DPDK Getting Started Guide [1] says: >=20 > "Required Tools and Libraries: > [...] > a supported C compiler such as gcc (version 4.9+)" >=20 > GCC version 4.9 supports C11 [2]: > "GCC 4.9 Changes: "ISO C11 support is now at a similar level of completen= ess to ISO C99 support [...]" >=20 > So why are we not going to support C11? We should make a plan to switch to C11 during next year. > Probably because of RHEL 7, which only provides GCC 4.8 [3]. >=20 > RHEL 7 was released for GA on June 10, 2014 [4]. If someone has a server = with a nine year old distro still used in production, it is probably becaus= e it is running some legacy application, which is difficult to get up and r= unning on a newer distro. Partial conclusion: RHEL 7 is probably still wide= ly used in production. >=20 > However, I have a hard time understanding why anyone would build and/or d= eploy a brand new DPDK application (based on DPDK 23.03) on such a server. = Can someone please justify this? >=20 > Are we really going to postpone C11 support in DPDK until June 30, 2026, = when RHEL 7 ends its Extended Life Cycle Support [4]? RHEL does its own choices to support old software for long. Upstream development should move forward. > If so, then the GCC version mentioned in the DPDK Getting Started Guide s= hould be corrected accordingly. No let's keep GCC 4.9 as a minimum for now. If needed we could upgrade it later.