Re: [dpdk-dev] [PATCH v2 07/11 1/2] vdev: new registration API

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Neil,

2014-04-11 06:49, Neil Horman:
> On Fri, Apr 11, 2014 at 09:36:52AM +0200, Olivier Matz wrote:
> > Instead of having a list of virtual device drivers in EAL code, add an
> > API to register drivers. Thanks to this new registration method, we can
> > remove the references to pmd_ring, pmd_pcap and pmd_xenvirt in EAL code.
> > This also enables the ability to register a virtual device driver as
> > a shared library.
> > 
> > The registration is done in an init function flaged with
> > __attribute__((constructor)). The new convention is to name this
> > function rte_pmd_xyz_init(). The per-device init function is renamed
> > rte_pmd_xyz_devinit().
> > 
> > By the way the internal PMDs are now also .so/standalone ready. Let's do
> > it later on. It will be required to ease maintenance.
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> I just posted a patch to separate pmd linkage from the applications
> yesterday, which will work with the existing API.  See my series on the
> introduction of the PMD_INIT and PMD_INIT_NONPCI macros.

This patch serie was posted weeks ago and has been reviewed.
It's a good approach because code is simpler like this and it's a first step 
before removing rte_pmd_init_all().
Your patches are using rte_pmd_init_all() which is an useless function.

Neil, next time, don't hesitate to discuss the design approaches before doing 
such big changes. By the way, your patches have to be reviewed carefully 
because there are other insteresting changes.

Thanks
-- 
Thomas