From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 0B6E168D1 for ; Fri, 11 Apr 2014 15:10:20 +0200 (CEST) Received: by mail-wi0-f182.google.com with SMTP id d1so971909wiv.15 for ; Fri, 11 Apr 2014 06:11:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=q4BkvjfxQ+bsn0hpvx18eRLUOrE1saeNSv9GpD0aEE4=; b=P9gkx28osSV44lkE7Qlanov87fHV02pTzkBe/wneuvhe2r4ldpQ9iKbY0QCZDVGZGX 6AytyGXOWGf3+8TcTofD6uqSYFj7wb1gkvpiYb/6ZDToBn68g9YtZbLyMmy/AHrQTRjk 5R6iNVCHR9rDU8R7QGAX6UJ48yULRBFyA1h5qtuF//pCMjyPSWfRBegGxSlLlPiJa0u/ D8W3MUjWQ8wBIapIf3bTavA94mUsXz21cJUxiQUw+/qvcg4ZXqWd9uJ78oSUqMxfRO7k Z/kdx+41yMmusGFNipVfSBUjpFrBeKL3f1Nbe+OGjGDdASufibioYNP7vGwKfm0rufDj cO2A== X-Gm-Message-State: ALoCoQnSJXrlFnk5ORx8L1FMc1b+bpv+0rR+fednhDvjuMboBZBwWt1JC2m2CbsoXjnfntZnX3lh X-Received: by 10.180.81.228 with SMTP id d4mr3407225wiy.49.1397221918330; Fri, 11 Apr 2014 06:11:58 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id c7sm11260473wjf.19.2014.04.11.06.11.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Apr 2014 06:11:57 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Fri, 11 Apr 2014 15:11:56 +0200 Message-ID: <8367341.P2CbmhJR7D@xps13> Organization: 6WIND User-Agent: KMail/4.12.3 (Linux/3.13.7-1-ARCH; KDE/4.12.3; x86_64; ; ) In-Reply-To: <20140411104929.GA911@hmsreliant.think-freely.org> References: <1460632.jOzC6OEr8u@xps13> <1397201813-26627-1-git-send-email-olivier.matz@6wind.com> <20140411104929.GA911@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 07/11 1/2] vdev: new registration API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2014 13:10:21 -0000 Hi Neil, 2014-04-11 06:49, Neil Horman: > On Fri, Apr 11, 2014 at 09:36:52AM +0200, Olivier Matz wrote: > > Instead of having a list of virtual device drivers in EAL code, add an > > API to register drivers. Thanks to this new registration method, we can > > remove the references to pmd_ring, pmd_pcap and pmd_xenvirt in EAL code. > > This also enables the ability to register a virtual device driver as > > a shared library. > > > > The registration is done in an init function flaged with > > __attribute__((constructor)). The new convention is to name this > > function rte_pmd_xyz_init(). The per-device init function is renamed > > rte_pmd_xyz_devinit(). > > > > By the way the internal PMDs are now also .so/standalone ready. Let's do > > it later on. It will be required to ease maintenance. > > > > Signed-off-by: Olivier Matz > > I just posted a patch to separate pmd linkage from the applications > yesterday, which will work with the existing API. See my series on the > introduction of the PMD_INIT and PMD_INIT_NONPCI macros. This patch serie was posted weeks ago and has been reviewed. It's a good approach because code is simpler like this and it's a first step before removing rte_pmd_init_all(). Your patches are using rte_pmd_init_all() which is an useless function. Neil, next time, don't hesitate to discuss the design approaches before doing such big changes. By the way, your patches have to be reviewed carefully because there are other insteresting changes. Thanks -- Thomas