From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9E9BC1B456 for ; Tue, 25 Sep 2018 18:56:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 09:56:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,302,1534834800"; d="scan'208";a="89247444" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2018 09:56:00 -0700 To: dpdk-dev References: From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <83690b8a-4aee-6d1a-65c9-173ef46655be@intel.com> Date: Tue, 25 Sep 2018 17:55:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] cppcheck on dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 16:56:04 -0000 On 5/31/2018 12:22 PM, Ferruh Yigit wrote: > On 5/16/2018 1:41 PM, Ferruh Yigit wrote: >> Today after listening Colin's Static Analysis talk, I run cppcheck on v18.05-rc4 >> code and it revealed some issues, sharing here for anyone to interested in >> fixing them. At least I encourage to check maintainers to check their own pieces. >> >> It is really easy to run cppcheck, in dpdk source folder: >> cppcheck --force . >> >> With above command cppcheck verifies all #ifdef paths, some issues below seems >> related to this and that is why these issues not seen in build tests. > > Some issues are fixed but we still have more, to trace them better submitted a > bugzilla issue for it: > > https://dpdk.org/tracker/show_bug.cgi?id=58 v18.08-115-g55d6bb67c cppcheck report: https://bugs.dpdk.org/show_bug.cgi?id=58#c6