From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC0EA41C96; Tue, 14 Feb 2023 17:05:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB5A841141; Tue, 14 Feb 2023 17:05:53 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id EA14241141; Tue, 14 Feb 2023 17:05:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676390751; x=1707926751; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=3Q5mnNNj1iRCX2fsLvmdUpWaZD4EEzPb8wEXkmCzOkw=; b=NajhG3D8EuSFVNE0oYANhVVSksb0crWOF4FgAstJMSgZEextgVk/JqD2 uH8XOoYLNrZkQczRag1BTX+o7o5K1A8NQr9IEshSxl/1RtGB7inHv671p JFCIb9UPDDcJEIbABcwuiIPRA9ZSc7LD8Lej0J9a0enRSwjoQncbWF6KQ gzYsoa48RopQ4WcaEyRtaWiAeW3GLtc6AMTu3XmvQrvtrN0uFmjSxum7g ZN0inJw8cSfBqUaWDJAycnIAveZVDmYZpdgVUBUuwXHN4DIdR/BuDacnN 4J3HWn7ES14/xYxh5zAPaU9kSUU9d5J2farbUBnibRqScXF6isQ9MbHHg A==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="319224113" X-IronPort-AV: E=Sophos;i="5.97,297,1669104000"; d="scan'208";a="319224113" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2023 08:04:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="662580380" X-IronPort-AV: E=Sophos;i="5.97,297,1669104000"; d="scan'208";a="662580380" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 14 Feb 2023 08:04:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 14 Feb 2023 08:04:31 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 14 Feb 2023 08:04:28 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 14 Feb 2023 08:04:28 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 14 Feb 2023 08:04:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F5VKlqmtY8EGtycyoZQ56leS8m7LElF7qoYLxeOiw+EuvmLFq+ow2q5Q2Wz1ttpqf5KNXfn5qjdvvCjOdBPcVNE1fpexqfmUo/ai9H/SYfqqTQKMn81Oak0WtjyRY2632XNKVOnT8jrzh6ASJQu1Q0zawRxzZLO6kFba+sB/9lrBy8Pmqalch7BkQve985vccwllAkpN4eyFRCQTWKoZuINk8cc7G/n3s98GkfmkParoc1KtsuAMvWRR6erKFLME/LosVbzFA29PyfsMILiTH2wMHMHgORYw9yFqVFFTkMDPvK63bJlrcXx0g65AcsFnWgVanNPB2qsg3DaFBdeyZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJOA9e72ATEHMow2XuaMddEwvUkJ0Wn6cuNpQ3WAdMo=; b=GiaCHHuIH9pDQFTOKpB0ruwsacH9rxsve+qkPSoHMh4NM5RqePgJ6TKguoO6WkWIDz2AEm/xb12hiad1w7Tp1w6NRqrzhk/neihMQj5FIJ9wDmjq09IPnM7YrNGiUvec6miEuYkT9F4r4Lb3WUP79a1FpLF6vz6uXgOZw6HXvsVuMvXr7wq70OQWKC34XjIFTcxRhu5kUDzD0N43lwadCs3kvY6ghG87vjYiqeJ8KnRm0EshqiXD5x0DWRwKOzJpfU/5f5hIPpgHa/mSCvFr/7BFLdBYJ1dZ6jKZFFZGaUVHtbw+0EotmaZNV1JY6i3PzKYaowot2ci5hzQc1U9c3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CY8PR11MB7136.namprd11.prod.outlook.com (2603:10b6:930:60::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:04:23 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::96f4:ad8:3fb9:b60d%9]) with mapi id 15.20.6086.023; Tue, 14 Feb 2023 16:04:23 +0000 Message-ID: <8377a64a-463c-5d65-ea0f-7bafbdf694e5@intel.com> Date: Tue, 14 Feb 2023 16:04:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 1/6] dma/ioat: fix device stop if no copies done Content-Language: en-US To: Bruce Richardson , CC: , References: <20230116153714.554470-1-bruce.richardson@intel.com> <20230116173738.562322-1-bruce.richardson@intel.com> <20230116173738.562322-2-bruce.richardson@intel.com> From: Kevin Laatz In-Reply-To: <20230116173738.562322-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0231.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::20) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB5872:EE_|CY8PR11MB7136:EE_ X-MS-Office365-Filtering-Correlation-Id: 98aae167-93a8-450d-f45d-08db0ea52353 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tJleEXAwi/AUFQ6Ot9emr2CrVvEgxoYLDcgnvxi4BgLgAqyfmGE2j2STL/ajHw3nVusSITUvV1dE5QTPprleSlzD1+k32pjTsaNUSJv2g8NfZhGM64RTRPtTCK7vp84WWJH2wzeim6WeqI/K5MFIlQLPeGEK2Kv5xkmC7nHkfiOoncRs3YUTPP/HfGgu7xYL2f8WH05hFlhBFmEcYgjeDQ529x08YbuBpQ/0yKM06xmCd6oI24xH9QfbVYhJzX9BLbI3wU83xA+RVuC6KI/y0afhRHH65CQ6HmXTSusJIOYvAsAYNIl+GlfaG5gLF9PxwqrzTkHEM4qSc6MjdQwWA4j595s7JIcS6Tr7RpPOr+D7MHduohqXD1U5oe20Gb7JTdzaPlHXXmAZhpShsthEEnLYjgfcgD8fnAAkADBL9Xv7Ydlwb9qCvAPZvHxIuvvb9T4LwyK63q3hxAs3p8v52ME2BcnZtowXn6hWPWTtf+frsIoxeSNCf5IvhmHWfA3JMCHnFGH+m7LNtHKY7iOLbnHGC2zRk7G+f4HVW6Cw7fXLOPpKGxIIOPYeN8O3lhRjihepmy4LmaRZ+AMFg76dOrptyKXH0a01S2+uWfVAN8i47qAxYSZ6bVA7lGKcjVbfPrO/b1Ewn4RAqu83NqdBYmXQPMNFCs1UTRwuM0g0rpHnPM0a9KF4oq4DjSnMhhcUz1vYML0KO43OoO/3rzbCvDsEvNmp+nuL28JfLFqsADQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199018)(36756003)(86362001)(31696002)(82960400001)(66476007)(6486002)(316002)(450100002)(66556008)(8676002)(4326008)(66946007)(478600001)(83380400001)(53546011)(8936002)(2906002)(5660300002)(4744005)(44832011)(6512007)(186003)(26005)(6666004)(2616005)(6506007)(38100700002)(41300700001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N21ac0xnSlcrQkVvRGcyM1JKNHR3Vzh5TmxKMW41RkY4Qmk4ZktKRkZNVEVt?= =?utf-8?B?dmdBQ2ZlTTJNdHZ5VVgycHFWcFpQYnpOVkhCTGpXbitrMmtwM3dMNDlVMW1P?= =?utf-8?B?UzBmY0p1MklMc2ttSy9YL1h5dU96MFc0amtTUk0vTFY0MnEzUzdMMHBQUlVn?= =?utf-8?B?ZWlVOUxZNGU3QjRjYXJSbG9EVEFjMWpCcERsTS85V2pEU1FkakJlVEg4Y0Zs?= =?utf-8?B?bFV1NTNPMGNXMzhwdEs2WkExOUdPQnNsYzh1aFpPQjNLY1dTc3N6amV0dFNJ?= =?utf-8?B?d1J2TlcweXRKbGs1WmN2MXc0Sk9lSHJJa2VBUS9uVTE3WUxTamEwdUg0bGxl?= =?utf-8?B?djllQk5oQVlsTzJOTm01T3RPeEh3Q3JNeVBkL2VTMWJJZTJoQ3VLd3BPVS9N?= =?utf-8?B?ekg4ci9IT1VPczFzOFlVUTZDemxLTHloM0RNVmhyd284RzA2WW9wMFVVZ2NV?= =?utf-8?B?V1g3QlNCNzBTbCtkZEd3ZDNrcXJ3dTl0ais5RDZSQWhSOW9NSStCRlBxSFcv?= =?utf-8?B?K241S0J1YW9kS0kvNi9lYzlnUHBHdjAyY0lvK2lEVHlyTzJJWTFtYndscERY?= =?utf-8?B?cnpBMzNxU0xUTHVnQlpsTENtS2s2YWJ3Q2RxRjRYSklhVWZlK0xMSHpsM01l?= =?utf-8?B?SzhzMjUwRW9QcUtQRGNDbE9kMWNldFhacDN1b0FpRDNZOERpVXdLSWNmYWdS?= =?utf-8?B?ZkNwZFFhQnZpbEd3NzZDdFBuVTdaczV1SGxHeWNxbVZmMzNqUFZaY3g2ODR3?= =?utf-8?B?Vlh6WDVmeDNSSWJsQXVYeGFoODBIeC9mTVcyRlVvVm9rRklaUGI2M1lQVzJh?= =?utf-8?B?QUxpZVhmNXEvRkNaa0lpaFFPQ1BnQ1RWcXJ0TWdlQTQ0ZzdHaC9JN1Bhc2d0?= =?utf-8?B?MEdleWxJQXYySncrWEVPNEhoNkFZT1A5c0NzUVh3VklzU3d5YmRrbTczd0Vr?= =?utf-8?B?TkV6cHo5L2U0ZWZLMWRPWFB6Q2ZmNGFJeDBIaHEzd1AzVUhqRlJtdnFsTGQr?= =?utf-8?B?UEM5WEEzdVF1bitZbkNqTU9Bcm9TZGo5QUlMdWQzeG9JYm9pVnNiRXhVcWVF?= =?utf-8?B?bGVSZ2p4MmlPRXRBdGdMcnVpV0tsY0N6M01KUnYzSUxMQnc5MmgwMXVNbzVn?= =?utf-8?B?R3JpemxrK25sWWE4QTNkWnVPZTlSWjRiZXFkbW1PUHRTdzh3d2VOV0ZJUWli?= =?utf-8?B?SzZyVHhJOWtsQXhBclJkY25VMlFmYUZhcHdEOEV2dTRpRG9NeDJhakwvQ05w?= =?utf-8?B?dlRZWVA3WDM3aFZFam5mbUI4VTZkYi9yL3B5eWNEN1hoOGpicktsWk9xdmRh?= =?utf-8?B?dGVsZG5COERaL29BbVVIWTNrcUhReWNOUWdmbS9rQTY3UHg2VGVJOFg0ZnE0?= =?utf-8?B?a2JGYUxwWk5RK1F0S2ZaT0xXUndtOVpzc3dlZVdUeDg3VzB6YTRjbHpCdlF4?= =?utf-8?B?R0ZZMXRidzF3R2VOTm5CZTM1M2c2czI0clVOdTFwYTFpRzBscHhncXJDN3ln?= =?utf-8?B?OXlTem9PdjVQVXZ5RFhLUnZQMmNrTWVhMUlhdGpCdzZCYjZ0eWp4d2JUcHRh?= =?utf-8?B?T3JXdEozRW56ZWFpQUFPeEx4NGZWSGV6VkczU3YvQVVxdHhXME5QbHlpcnBS?= =?utf-8?B?YWx0aVIxeDRsMnlZM1FKMktNZFpSeUgvczNDVlRMcytRZkZQbmpHemFmb0U5?= =?utf-8?B?OUpEL09rVnJiSXRGV1NKUXJYTHNjTmxHbUp4R205NlM5eG9aMUxScU5lNE8r?= =?utf-8?B?OVdMN2tUT0pnOGQ5VDVwMnc0RGd3UlFJQkN5amo3VFdBbzhIREVpUkg2UHd1?= =?utf-8?B?emZQQUN0YWpiZGV4eVpxV2JCRUdLUkF2cTQ3UXhKdGQyck9RUDYwR1Q3a3ND?= =?utf-8?B?NUxQczBWRGxiWnk2cVA2QnZ0YkV2eVFBWkgzYWVWUUNMbU1JMnJHTVdFaTVQ?= =?utf-8?B?eVRoMVpreXFpdHZNL0RhZFlSVWJuVjlzVUdzWXI4QXBTT2NyMEF5SVBTMXhT?= =?utf-8?B?M1FtNGZFbTFTc2tuRGFyb1dTb1p0TUYybnBYaitpdW1ac3UwZm5GaUs1RmZZ?= =?utf-8?B?Nm8vNC9qaEc0cFdYY2JPYXY1UzhVM2xxSXE0Ymp6UEt4UlpRTWlReEpiWWNO?= =?utf-8?B?dXBSb2FnTlR0UTVoQjQ2eFhZUmEwa3QxY2FJcWFQTjhPa09wa0dQY21TSHNl?= =?utf-8?B?N0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 98aae167-93a8-450d-f45d-08db0ea52353 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:04:23.1747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MF5/DqeWxKh0VREQRYhGPzWBeH09qAt83mLxffgiO+LV9W7o6YW7TgI1p9Thj4Ah/RUWRnA/zGrCTGCc9kn3Pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7136 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 16/01/2023 17:37, Bruce Richardson wrote: > The HW DMA devices supported by IOAT driver do not transition to > the "active" state until the first operation is started by the HW. > Therefore, if the user calls "rte_dma_stop()" on a device without > triggering any operations, the sequence of commands to be sent to > the HW is different, as is the final device state. > > Update the IOAT driver "stop" function to take account of this > difference. > > Fixes: 583f046dd404 ("dma/ioat: add start and stop") > Cc: conor.walsh@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- > drivers/dma/ioat/ioat_dmadev.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) > Acked-by: Kevin Laatz