From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Marvin Liu <yong.liu@intel.com>, Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix packed ring zero-copy
Date: Mon, 24 Feb 2020 12:14:53 +0100 [thread overview]
Message-ID: <83787803-471f-b54f-5f1f-a6e4ecbc494e@redhat.com> (raw)
In-Reply-To: <CAJFAV8yE-Phff29ECSwPsf1SzfjLkWFoBbMoaDY9xXEWQzDykw@mail.gmail.com>
On 2/24/20 11:32 AM, David Marchand wrote:
> On Mon, Feb 24, 2020 at 9:28 AM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>> Hi David & Thomas,
>>
>> On 2/24/20 4:14 PM, Marvin Liu wrote:
>>> Available buffer ID should be stored in the zmbuf in the packed-ring
>>> dequeue path. There's no guarantee that local queue avail index is
>>> equal to buffer ID.
>>>
>>> Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single dequeue")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>>> Reported-by: Yinan Wang <yinan.wang@intel.com>
>>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>
>>
>> If it is not too late, I think we should pick this patch for
>> v20.02. It is fixing a regression introduced in DPDK v19.11.
>
> I might have cold feet, but taking this fix right now feels risky.
> If the problem has been there since 19.11, it can wait 20.05 and it
> will go to 19.11 after proper validation.
Ok, I get your point and it's your call. Now, this fix is really
isolated to zero-copy packed ring, so the only risk IMO is to break
something that is already not working.
Thanks,
Maxime
prev parent reply other threads:[~2020-02-24 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 14:50 [dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid Marvin Liu
2020-02-24 7:25 ` Ye Xiaolong
2020-02-24 7:39 ` Liu, Yong
2020-02-24 7:27 ` Maxime Coquelin
2020-02-24 15:14 ` [dpdk-dev] [PATCH v2] vhost: fix packed ring zero-copy Marvin Liu
2020-02-24 8:28 ` Maxime Coquelin
2020-02-24 10:32 ` David Marchand
2020-02-24 11:14 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83787803-471f-b54f-5f1f-a6e4ecbc494e@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).