From: Martins Eglitis <martins@sitilge.id.lv>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ether: mark ethernet addresses as being 2-byte aligned
Date: Sun, 9 Feb 2020 20:32:47 +0100 [thread overview]
Message-ID: <8382cf47-4ae9-ca71-a1c6-c6c2b6a243bd@sitilge.id.lv> (raw)
In-Reply-To: <20200205134525.GA687@bricha3-MOBL.ger.corp.intel.com>
Hi,
Thank you for the help. I think it has something to do how the NFF-Go is
being built. Will address the question to NFF-Go devs.
Thank you,
Martins
On 2020-02-05 14:45, Bruce Richardson wrote:
> On Wed, Feb 05, 2020 at 01:21:54AM +0100, Martins Eglitis wrote:
>> Dear Bruce and Kevin,
>>
>> I tried building an application (NFF-GO) which has DPDK as a dependency.
>> I am still getting the same warnings you and Kevin were discussing. My
>> current DPDK version is 19.11-1.
>>
>> Do you know if this issue has been resolved?
>>
>> This is the output:
>>
>> # github.com/intel-go/nff-go/internal/low
>> In file included from
>> /home/zebra/Projects/nff-go/dpdk/dpdk/x86_64-native-linuxapp-gcc-install/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev.h:160,
>> from
>> ../../go/pkg/mod/github.com/intel-go/nff-go@v0.9.1/internal/low/low.h:11,
>> from
>> ../../go/pkg/mod/github.com/intel-go/nff-go@v0.9.1/internal/low/low.go:16:
>> /home/zebra/Projects/nff-go/dpdk/dpdk/x86_64-native-linuxapp-gcc-install/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h:
>> In function ‘rte_is_same_ether_addr’:
>> /home/zebra/Projects/nff-go/dpdk/dpdk/x86_64-native-linuxapp-gcc-install/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h:84:2:
>> warning: converting a packed ‘const struct rte_ether_addr’ pointer
>> (alignment 1) to a ‘unaligned_uint16_t’ {aka ‘const short unsigned int’}
>> pointer (alignment 2) may result in an unaligned pointer value
>> [-Waddress-of-packed-member]
>> 84 | const unaligned_uint16_t *w1 = (const uint16_t *)ea1;
>> | ^~~~~
> <snip>
> Hi,
>
> looking at the code in DPDK for 19.11, rte_ether.h no longer has the
> unaligned_uint16_t type in rte_ether.h. For example, line 84 of rte_ether.h
> should read as below:
>
> 81 static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1,
> 82 const struct rte_ether_addr *ea2)
> 83 {
> 84 const uint16_t *w1 = (const uint16_t *)ea1;
> 85 const uint16_t *w2 = (const uint16_t *)ea2;
> 86
>
> Have you got mixed header files from two different DPDK releases?
>
> /Bruce
--
Best regards,
Martins Eglitis
prev parent reply other threads:[~2020-02-09 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 15:54 Bruce Richardson
2019-05-16 18:04 ` Kevin Traynor
2019-05-16 20:38 ` Bruce Richardson
2019-07-01 13:11 ` Olivier Matz
2019-07-01 13:38 ` Bruce Richardson
2019-07-01 14:14 ` Olivier Matz
2019-07-01 14:28 ` Bruce Richardson
[not found] ` <1e5856a8-108b-1f0c-6ce7-b7c9eafac658@sitilge.id.lv>
2020-02-05 13:45 ` Bruce Richardson
2020-02-09 19:32 ` Martins Eglitis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8382cf47-4ae9-ca71-a1c6-c6c2b6a243bd@sitilge.id.lv \
--to=martins@sitilge.id.lv \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).