From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DA66A051C; Sun, 9 Feb 2020 20:34:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5AC11BF9E; Sun, 9 Feb 2020 20:33:53 +0100 (CET) Received: from mail.sitilge.id.lv (sitilge.id.lv [109.237.27.180]) by dpdk.org (Postfix) with ESMTP id 5B579DE3 for ; Sun, 9 Feb 2020 20:32:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sitilge.id.lv; s=mail; t=1581276768; bh=BU+9/mpmL8XUpTKJqRA6WWHQG0HQJmOBIdgzACnw5vg=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=j5gvGAAIUku5oJWWUuLsnao33AbiaQhfubbkLQCTi5crielu9R7XJ87mf0wEl0mBV VbBr8Fu+v43lZLSTRVczmaNYCj6dfBFIKE35IMPAqyQvSX+pGK7wdfcAUoG8TfJojC Ii0z5vhMZkUdr1IexfVd/Oa+tXcdbzeWJaNPECQU= To: Bruce Richardson Cc: dev@dpdk.org References: <20190516155457.4006-1-bruce.richardson@intel.com> <1e5856a8-108b-1f0c-6ce7-b7c9eafac658@sitilge.id.lv> <20200205134525.GA687@bricha3-MOBL.ger.corp.intel.com> From: Martins Eglitis Message-ID: <8382cf47-4ae9-ca71-a1c6-c6c2b6a243bd@sitilge.id.lv> Date: Sun, 9 Feb 2020 20:32:47 +0100 MIME-Version: 1.0 In-Reply-To: <20200205134525.GA687@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Mailman-Approved-At: Sun, 09 Feb 2020 20:33:47 +0100 Subject: Re: [dpdk-dev] [PATCH] ether: mark ethernet addresses as being 2-byte aligned X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thank you for the help. I think it has something to do how the NFF-Go is being built. Will address the question to NFF-Go devs. Thank you, Martins On 2020-02-05 14:45, Bruce Richardson wrote: > On Wed, Feb 05, 2020 at 01:21:54AM +0100, Martins Eglitis wrote: >> Dear Bruce and Kevin, >> >> I tried building an application (NFF-GO) which has DPDK as a dependency. >> I am still getting the same warnings you and Kevin were discussing. My >> current DPDK version is 19.11-1. >> >> Do you know if this issue has been resolved? >> >> This is the output: >> >> # github.com/intel-go/nff-go/internal/low >> In file included from >> /home/zebra/Projects/nff-go/dpdk/dpdk/x86_64-native-linuxapp-gcc-install/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev.h:160, >> from >> ../../go/pkg/mod/github.com/intel-go/nff-go@v0.9.1/internal/low/low.h:11, >> from >> ../../go/pkg/mod/github.com/intel-go/nff-go@v0.9.1/internal/low/low.go:16: >> /home/zebra/Projects/nff-go/dpdk/dpdk/x86_64-native-linuxapp-gcc-install/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h: >> In function ‘rte_is_same_ether_addr’: >> /home/zebra/Projects/nff-go/dpdk/dpdk/x86_64-native-linuxapp-gcc-install/usr/local/share/dpdk/x86_64-native-linuxapp-gcc/include/rte_ether.h:84:2: >> warning: converting a packed ‘const struct rte_ether_addr’ pointer >> (alignment 1) to a ‘unaligned_uint16_t’ {aka ‘const short unsigned int’} >> pointer (alignment 2) may result in an unaligned pointer value >> [-Waddress-of-packed-member] >> 84 | const unaligned_uint16_t *w1 = (const uint16_t *)ea1; >> | ^~~~~ > > Hi, > > looking at the code in DPDK for 19.11, rte_ether.h no longer has the > unaligned_uint16_t type in rte_ether.h. For example, line 84 of rte_ether.h > should read as below: > > 81 static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, > 82 const struct rte_ether_addr *ea2) > 83 { > 84 const uint16_t *w1 = (const uint16_t *)ea1; > 85 const uint16_t *w2 = (const uint16_t *)ea2; > 86 > > Have you got mixed header files from two different DPDK releases? > > /Bruce -- Best regards, Martins Eglitis