DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/4] RX/TX queue start/stop enhancement
Date: Mon, 25 Aug 2014 16:39:40 +0200	[thread overview]
Message-ID: <8387355.n025YUnlxz@xps13> (raw)
In-Reply-To: <1408001703-30919-1-git-send-email-jing.d.chen@intel.com>

> This patch mainly includes 2 changes. One is in testpmd to add command
> testing specific RX/TX queue start/stop in Port X. Another change is in
> i40e, which implemented rx/tx_queue_start/stop in both PF and VF driver.
> In the meanwhile, support field start_rx_per_q in i40e_dev_rx_queue_setup
> and start_tx_per_q in i40e_dev_tx_queue_setup.
> 
> Chen Jing D(Mark) (4):
>   testpmd: add command to start/stop specfic queue
>   i40e: PF Add support for per-queue start/stop
>   i40e: PF driver to support RX/TX config paramter
>   i40e: VF driver to support per-queue RX/TX start/stop

Applied for version 1.7.1.

The commit logs and comments in the patches had some typos and sentences
difficult to read. For next patches, I'd prefer simpler sentences.
I'm french so I know how it's difficult to write clear english text and
I think it's even harder for a chinese.
By the way, I see that Konstantin reviewed the patch, so I assume he checked
the code but he probably forgot to check comments.

Please understand that my comment is not specifically about you (author or
reviewer), but it's an example of what I've seen many times before.
I try to fix or reword them, especially in commit logs. But it would make
things easier if everyone could make an effort about typos and english writing.

Thanks
-- 
Thomas

      parent reply	other threads:[~2014-08-25 14:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14  7:34 Chen Jing D(Mark)
2014-08-14  7:35 ` [dpdk-dev] [PATCH 1/4] testpmd: add command to start/stop specfic queue Chen Jing D(Mark)
2014-08-14  7:35 ` [dpdk-dev] [PATCH 2/4] i40e: PF Add support for per-queue start/stop Chen Jing D(Mark)
2014-08-14  7:38   ` Cao, Min
2014-08-14  7:35 ` [dpdk-dev] [PATCH 3/4] i40e: PF driver to support RX/TX config paramter Chen Jing D(Mark)
2014-08-14  7:35 ` [dpdk-dev] [PATCH 4/4] i40e: VF driver to support per-queue RX/TX start/stop Chen Jing D(Mark)
2014-08-25 14:39 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8387355.n025YUnlxz@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jing.d.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).