From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 3675BB390 for ; Mon, 25 Aug 2014 16:35:51 +0200 (CEST) Received: by mail-wi0-f176.google.com with SMTP id bs8so2646170wib.15 for ; Mon, 25 Aug 2014 07:39:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=IDO6f2Z6FfJhdHIFutk+raEDPcQQVlywcvmIGuZHdC4=; b=fw9ld3Fw95pNyxxMakzMKiZMAinvfe/GPrru6jibZ+NRYn2siQWKei8hvfzb5Gs1z6 iiYSEnJx5TMBEnPw58YsdhsX+3K4O1ZYV9BFWQhtgvvk7+v3xoyym/wexRDzSyozg/3B NJ0sloO+RUU6eVOloP9G2MBIMam6fKlaULWEpYMR0kwIZaNSvWuvoY7ARXi0xmKaLN0p esIVMjfoxIl+qpZatO7EIUj7MZ7noSqLy5sOh9pKMtfk0pd4I43KKAqg16RjNeXoSu1d WIFbz8yIHwJai9t8Ss9ESR5TnMV3zGnJvanY+Doqcwv7w539URVMeJE+8k4tdCCQOrkv HUjw== X-Gm-Message-State: ALoCoQlr6Otryv51gtp32R3Ydd1hgVzuZ8uOakKI7Npw9cpoK2qqB9wIRKKYG2g1tNdsSl79/waZ X-Received: by 10.180.99.97 with SMTP id ep1mr15438408wib.33.1408977585678; Mon, 25 Aug 2014 07:39:45 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gr3sm1287200wib.12.2014.08.25.07.39.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Aug 2014 07:39:44 -0700 (PDT) From: Thomas Monjalon To: "Chen Jing D(Mark)" Date: Mon, 25 Aug 2014 16:39:40 +0200 Message-ID: <8387355.n025YUnlxz@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1408001703-30919-1-git-send-email-jing.d.chen@intel.com> References: <1408001703-30919-1-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/4] RX/TX queue start/stop enhancement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2014 14:35:51 -0000 > This patch mainly includes 2 changes. One is in testpmd to add command > testing specific RX/TX queue start/stop in Port X. Another change is in > i40e, which implemented rx/tx_queue_start/stop in both PF and VF driver. > In the meanwhile, support field start_rx_per_q in i40e_dev_rx_queue_setup > and start_tx_per_q in i40e_dev_tx_queue_setup. > > Chen Jing D(Mark) (4): > testpmd: add command to start/stop specfic queue > i40e: PF Add support for per-queue start/stop > i40e: PF driver to support RX/TX config paramter > i40e: VF driver to support per-queue RX/TX start/stop Applied for version 1.7.1. The commit logs and comments in the patches had some typos and sentences difficult to read. For next patches, I'd prefer simpler sentences. I'm french so I know how it's difficult to write clear english text and I think it's even harder for a chinese. By the way, I see that Konstantin reviewed the patch, so I assume he checked the code but he probably forgot to check comments. Please understand that my comment is not specifically about you (author or reviewer), but it's an example of what I've seen many times before. I try to fix or reword them, especially in commit logs. But it would make things easier if everyone could make an effort about typos and english writing. Thanks -- Thomas