From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB50A4545A; Fri, 14 Jun 2024 12:33:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A761A402DD; Fri, 14 Jun 2024 12:33:38 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id 443E0402D3 for ; Fri, 14 Jun 2024 12:33:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718361217; x=1749897217; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=0lE4e08KLajLoaBaPk1vcIJjbm3WcrcIKorMV6mqUEY=; b=aG4vC24fgnVSFxmAZTU7ST8CQWL83c4gEyc3xj+zrXcPA61iM60SyjQr eC0FR8CiUk3AERSxmQ41fQneI5Nz16//RMJoxRBLgQxeaYiYmFPxY2arC wsmqMKwTDbxiVAbDqw54CZrEKUfotX6Ic8QZzn49Nj/IkN+qIwF2Lw4yU EpFCmjFl66Ctp41bXm8+QJnwpib9UKxdC8yJIlTF+ZhHCT7LeJO5+XaOt oXB8HsKN2d6EYVumhznIYgcxf7OuYeo1pA88oc8MlpwQYgCmdJFK5CqQs YLhjiBQYMyAxZ1Zrn2X5nYkIysv+q+7VTsbuVvCxgU8Ur0XEewxnBy6oA Q==; X-CSE-ConnectionGUID: DpOHjXS1QmumTknGP+lMgg== X-CSE-MsgGUID: 0wOf3Oz5RrG6+CcPOk3dTA== X-IronPort-AV: E=McAfee;i="6700,10204,11102"; a="32782480" X-IronPort-AV: E=Sophos;i="6.08,237,1712646000"; d="scan'208";a="32782480" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2024 03:33:36 -0700 X-CSE-ConnectionGUID: j4J1MHkgS2SRWnnHpQZ/qA== X-CSE-MsgGUID: OYxWamgQTiaWar7eYaf5bg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,237,1712646000"; d="scan'208";a="45007804" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Jun 2024 03:33:36 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 14 Jun 2024 03:33:35 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 14 Jun 2024 03:33:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 14 Jun 2024 03:33:35 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 14 Jun 2024 03:33:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kRTfSnwFbNDcJW45nmdsWCkoeZt525rBMpp0G0u9O2QmU3jQygV4rPlBe3j2SpA+/fMSm60x4iICq9/AQakfAABaJapS4/QO5LWKYzunkfvRc7Nu2LCaMcMJdLFu7fxWj2oy3CPZd5H+ahTybSHbb1yRXuAFvXTqZCpQD0elJ0NvG8bVcPZCbJikp8zjITfYVolJwaR4mSF44Ykq76Y+VzPHOgBwZFfDsoATUJLsDmx6O+ozvfdBb3fghHnps8wa4CStIUeT/n6A69vVI3dLi3taP1jWQ5ysKr9Pc+uI2OogJ1UxiUCH0ss4ncUgTnNO1tbBCcl7HMcq3MyMToZejQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w2y7TiYKxRscJ5vy6UE1SP16P5rIKQDPV6rplEq36fA=; b=UwPRfJyNWYtRAfib30qY25QFjo1k3OVReGogZ8WQEgFQaRV6cwxeRZSxZbRYse1w8z4WddX6ejr+8V+qwtU7sLcQljkOjMpEJngh82eMR71drgHTw/OLAZjb+jZjHMvkLHn6cUMNgYwGnaa6Jy6AuYF6xTerfX0IQy6xRP+E8fvMRajmufP7nd4LCPzI4OZjAQPmdDnWIjwPKoJJ3AmY3a3cI6PqLwFDkB7/DF2cynontuNQkxQu2H5H12ffSi7yUgeVNclatTfEyat0YMcN2g2FuVnsiiR1/RXucx8QD2gxLTKHEImuauaoJMu1MFtUghhSm01Zsl4qO5hD5v6QzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by SJ0PR11MB5213.namprd11.prod.outlook.com (2603:10b6:a03:2da::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.26; Fri, 14 Jun 2024 10:33:27 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 10:33:26 +0000 Message-ID: <838d881c-2114-49cf-a122-028946c993e7@intel.com> Date: Fri, 14 Jun 2024 12:33:20 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/22] common/idpf: added NVME CPF specific code with defines To: Soumyadeep Hore , CC: References: <20240604080611.2197835-1-soumyadeep.hore@intel.com> <20240612035257.2245824-1-soumyadeep.hore@intel.com> <20240612035257.2245824-2-soumyadeep.hore@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20240612035257.2245824-2-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR04CA0007.eurprd04.prod.outlook.com (2603:10a6:10:110::17) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|SJ0PR11MB5213:EE_ X-MS-Office365-Filtering-Correlation-Id: e40ce0de-4212-4aa8-c1f0-08dc8c5d6cb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?alA5MG9jUVBYQ0FmU0VCV3VnZ1oyS2RoMnVyT1FNK29WUUlTNjlzMitIVWdj?= =?utf-8?B?dllhb2x2MEJsOHJWOUhRNXd3UVB5ZUg2SGVBSG1ZaU9Ua2ZlenZoNitnNDNn?= =?utf-8?B?NisxUlhwM0hONThqTjlQT3o1dmJVYm1zaklqRFdVSThSUFdhK0R1S3dzcUQ0?= =?utf-8?B?K1NWT3dkV2U3ejZmdS9vUWxkZjd2NmZRRUZqYVkrNU0zZytaZm0zbUtwOEpu?= =?utf-8?B?VkFiYndYV3hlMlo3UGdaeVhmU1NEUWd4bS9aNzlYNlBmbWJtaUxSOFRObzNI?= =?utf-8?B?WVBBUnBjSk1KSTk1MkdDeTdySkNmaHNJMktYZlVoUk1aaXFwRVAzUHZyMU8r?= =?utf-8?B?T2VuVkdOK3FJU0l4c3RaYlA0dm9NblZKelRQeFlwSEQzNVMrUHI1bWdTc3h5?= =?utf-8?B?UTlGKzNVNWV4WUlIUDdHdlBzWi9jME5oZDU1RWtiU0dTTE5qZzYvOXBLT1BM?= =?utf-8?B?RE1nSGduYXdOZmtyMThjT2h1TVdOZWpBOURxT3V0cXBVdGVmMmI4RG03VWpn?= =?utf-8?B?b0hCRXlKVUIvWG9FMWhDaDlDZ3VKR3ozZnR3T1ZOdHRNUkwveWhrZlZBTnRy?= =?utf-8?B?WEFGajVpREo5dmhRdjdOakZBRkRtcVVtUUFrWVdhS2V3OFdySUxKM1NZa2pC?= =?utf-8?B?WXdyNjExUm9sa2lCbzJyeHhCTUY1VW9vQS85YzhBWGFmWkpyek1xdWZDSTRz?= =?utf-8?B?S0lzeUwzd1pCZDI3cEs3eXRyV3ExQVFMcFlOQ3JlMzMyUld3UEVmaWhieUVy?= =?utf-8?B?RWpJNWk3eDU5aEc5bTFLR2NxSXRyMGlTOW9la0ZyZEVGd3A2VkF2ZDN6TEF5?= =?utf-8?B?R0dmL0dLRVdyQ0RYWDRydllLWlpSNWNkR0I0OUJDeVNQR3hWb1hXV21VcHFn?= =?utf-8?B?STd6bFRZVk9GVEE4eG0vZDZ3S01Ib2NQR2ZzcHk0MEJzaXFwSndiNzU5emdL?= =?utf-8?B?QmdpYm5SM3F1d3BqakxScm5wRmhHeGwreW80WUYxVXV1ZGd0V3dIUXZteGVk?= =?utf-8?B?ZlU3MHRrUzN5T08zR1lqclRaVm1FQ0t2L0kzaGZtaHkvR0ZGUnB5TmVHUHZ1?= =?utf-8?B?YXJ6V0hqakNnNTNVQ2tSdi84Z255NUsrcnJiV095S0JwRlloS29SRDZ1VWY4?= =?utf-8?B?RGxxSTVRRHhtN3lxSjRaREJrUWlma3pycm1sY2NJb1J4TGE3NnM4djlEZ0NN?= =?utf-8?B?N0NDQkxTR3V3Qmd0VVRYVkdNWVhpU005elJMcXVKMkhCL0lucDBQaFp3T0dL?= =?utf-8?B?QlhEU2lwTWRYeHRCSURNbmFKV2JxKzJxaEpmQnliSldnZENVTVR1c3ZvZGJC?= =?utf-8?B?OUxLUDdtV2oyQ2tPcEg4OTNPVUsxZDYwKy9QaS9CVmlETjJVMXRtNlppNzdP?= =?utf-8?B?ZXZSVHpHSXhQbVlkY3Y0NHBFZVZxM2pya1FETW1DR29aR2xwUytiTE5KSXpp?= =?utf-8?B?Zzk1K3YrVm1ubXR1YmMyZnFuZlBXMW5xRXR1OVE0cnh1eWthTGRKdjJFZTRU?= =?utf-8?B?TFRCUnFoaTJKUzhzRWpwUXU0TWROY2hlbnhwYjh4RHZjY09NUnFXMHpIMDRr?= =?utf-8?B?N2lsQmpyQ1ZkTVFwell6QURVdHc4UGpJbUdZRGFKV2VJVk9JUkVyVk14Wi9W?= =?utf-8?B?S0VkMFIrbXRRenlqcXJDblZISzVyOVZ5UWxQQzNiczQ5SGlwaXcvMERTRFpw?= =?utf-8?B?clNmMHRJNnlZc00zbTNwbVhUNTJKbUhEaHUrOWFqeVpxak8ydkVEMHdyL0Rx?= =?utf-8?Q?RsnYUy8/TEpM8Jz1gbbneDw2Qb1ObR595x9Gf1w?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWhpRGFGRVhUSGJONnM1MGNNNmN6K0IvRWREcW9rNlg4dXpKaithTGNXN01z?= =?utf-8?B?aFM4UkQ2bnpCRWJKano5Y2NYVWdFUVpQc0ZrQWZON3RlSjJNSy82aStOR3pq?= =?utf-8?B?YjRZS1FSS2cyS3djNkR3VkdDclNpVzlETGg4aWJ0SFp3akd2NXpUQ2hEaWln?= =?utf-8?B?Z2JhYlpQUVRTSkc3SWJVUlBpeHZvSG5vYTEyS1QrdTBqelgwZ0Z3MHJncEJD?= =?utf-8?B?NGZHK2M2Q1Z5VzR3ZVEzTDhsakdlcDFXaWI3WVQ3THRYVTB3ZDRybkJqT0Ny?= =?utf-8?B?Y1NNQXlrc2xQS2REK1RzWnpmamVTWlhpTzBtYmpYajdqNGM1NHQrcG1pQS82?= =?utf-8?B?M1FVWnpqUG9PVStDeHlDNXVHYWVWY2JXN0NGQ0dDTXRMWG9LYnpiVXdnVDhE?= =?utf-8?B?OVAvRVYrVE1LcjRnY1M2WEcyZ3dJVU1TVkJWYVdLaytHNlF4SEZCS2Q1Y3c3?= =?utf-8?B?RXMyTXN6SE1lVStBcG10T0k2dE1OSjJKdEJrbmJReE5MNk96NUdvWXczQk81?= =?utf-8?B?MzdCRjNkcVFleXNIbmdlaUlQL1ZwK3RaVzIyLzZjMVBOVzl2NDdHWHhqMFZw?= =?utf-8?B?QW53dFQ2aGd1b3RES1BXYjVUckRiYnl6NndEOHg4aktFN0ovQlNlSFovZVB3?= =?utf-8?B?cjVvNnNoYjhoanNydEtSYm9IWjJtUWFhbG8wcFVKeHpYSTc0dVF5K0Y3bzlu?= =?utf-8?B?Q292ZTNac0xkUW5hT2FzYnhIWGxmRXZmVmcvQzBZYVBjbHpCSVBlNlRnUjl3?= =?utf-8?B?TWlmZ2RtOUcxU2p1MDY0RlM5aGc2NVNWNWhueTJqU25MTWlJR1dqM05LMUVY?= =?utf-8?B?UnlHcVZxRTBJMHRIMVRhOWtmUUFRNzJNNFMzU0t0ejJSbytwRm1Jd1hXVGlG?= =?utf-8?B?QWt4aXFIS2p2RGZ1REFPeFZyT0ZmcGxzeUNjZDAveHd4am9PRGk3N2plZGtn?= =?utf-8?B?bVBsRytHWmVTUVI0SEZ0dlJGMnBrVDlKKzdSSWVEcmtMRGRCdmNPK1d5NjlT?= =?utf-8?B?K1FjemhjcXB4N2hZd3c5aG53dWltRnFmd0JvMmhDVWJPTmVlZitpd0VOWHpI?= =?utf-8?B?QlluSXMxVzE5T3p6cWxCcU94eUc2ais5WDZ1ZDZSZTdORUJiNGdENHF4amE4?= =?utf-8?B?UmhwcU9JODdxZ1dCYkIzVWJBaCtaaVZjWE5hZkpySjZZSlI3L3Q4aTZpcXl3?= =?utf-8?B?WWVqUDNkOWdWSWE4bW1iZk1YQ0FWekhWcVdFYllJQVh3UFY2VmF1OVd5OTVZ?= =?utf-8?B?YzRIdnlRMDJyYm9aSzhTWDgxTHkzWlhnOSs4SGU5REhyaHNRaWM2a1oraTBx?= =?utf-8?B?NWxoU2FWWnVuVytLb0YzcEhzalJ4MllJQ2Ixc04xTTVzeGpWeWtZZVZQWWo2?= =?utf-8?B?Rk55TDhTWFJVV1NPOVlMNDRIbk1iUTVPMXpES0dVREdveHdiaUZuR05OTVZ1?= =?utf-8?B?SmJPa3c2dUZqWnczME9TL1ZsZEhHMzhnT0Y2V3lnQVFuZHIyRW9UWW01cFg3?= =?utf-8?B?QjRLZFpEZlhIdldsS0FmRDViTmkwQ0RKL1RQRy9GZTNVbjBwb1hyODRLeEtM?= =?utf-8?B?QlhzVnJnNzd1WkdieStBeTZjZ3B6d3FBQzhBSUVGYkRBSE03eVdrd3pQWUpt?= =?utf-8?B?dHVjQmJUTk9IR2FibmdONHdmQkZ4Tjg3bm1YcGM1ZmdxeU9EL0ZwMlB3SmlP?= =?utf-8?B?ZXJCNGY2Wkk1WW5SbjVmMnpiWkliemt0UE9BbnR3T3AwMmhNQUdWc0YrSnRG?= =?utf-8?B?dDFPZkdNQjNzcGFGS1RCQkE5K0lVamhkcXNFUHZzak1uRWNhaDdmMisvKy9v?= =?utf-8?B?OVZtUXBML2NKQjZvL0p6VG03WHIzNUd5ZS9nK2UxRnM5UFUxNytoQmZJWmFP?= =?utf-8?B?N05EcXp1bFZYUlhtYmRyRFZ5YnpHN09CaGRndHoweHdxcC8wdldJbXpDM0Z1?= =?utf-8?B?Qmpjc09MRlIrR0hDUmg4aTg0Y0tBV3RPb3hVbFFWZGN3QjgwRzU3V2F3V1Fw?= =?utf-8?B?cUZ2YWx1b1ZBQ0poMVJVRHk1Rm1DNmFCYVFVUWkxK0J2K0V0L09Xc2ZQTHo5?= =?utf-8?B?TEhVZjNlQTVaa1hHaUlOU05rUVFpeG55WU9yNTd4L3I0M1B3bkFNc1RBaWwx?= =?utf-8?B?QnBVTDZmN2NsaVFldGc0bzBGUnlZaThXOHh4NDcveWozU0tYQnVDMytDMlQw?= =?utf-8?B?Qnc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e40ce0de-4212-4aa8-c1f0-08dc8c5d6cb1 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 10:33:26.5579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VnpkW24x0rTR1jGps6Lpd1m/+0InyN+sGCQ72pSdQRV/mypINcYWoCIWvN0AdyW/4diUh/nWkqtNYPLclvTRIBYIx/0OoZR9WyZuoGH24yA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5213 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: > Removes NVME dependency on memory allocations and > uses a prepared buffer instead. > > The changes do not affect other components. > > Signed-off-by: Soumyadeep Hore > --- > return status; > } > @@ -232,8 +244,13 @@ void idpf_ctlq_remove(struct idpf_hw *hw, > * destroyed. This must be called prior to using the individual add/remove > * APIs. > */ > +#ifdef NVME_CPF > +int idpf_ctlq_init(struct idpf_hw *hw, u8 num_q, > + struct idpf_ctlq_create_info *q_info, struct idpf_ctlq_info **ctlq) > +#else > int idpf_ctlq_init(struct idpf_hw *hw, u8 num_q, > struct idpf_ctlq_create_info *q_info) > +#endif Nitpicking, but the added function's indentation seems different from the rest of the functions in this file file. Is this how it is in base code? > { > struct idpf_ctlq_info *cq = NULL, *tmp = NULL; > int ret_code = 0; > @@ -244,6 +261,10 @@ int idpf_ctlq_init(struct idpf_hw *hw, u8 num_q, > for (i = 0; i < num_q; i++) { > struct idpf_ctlq_create_info *qinfo = q_info + i; > > +#ifdef NVME_CPF > + cq = *(ctlq + i); > +#endif > + > ret_code = idpf_ctlq_add(hw, qinfo, &cq); > if (ret_code) > goto init_destroy_qs; > diff --git a/drivers/common/idpf/base/idpf_controlq_api.h b/drivers/common/idpf/base/idpf_controlq_api.h > index 38f5d2df3c..6b6f3e84c2 100644 > --- a/drivers/common/idpf/base/idpf_controlq_api.h > +++ b/drivers/common/idpf/base/idpf_controlq_api.h > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: BSD-3-Clause > - * Copyright(c) 2001-2023 Intel Corporation > + * Copyright(c) 2001-2024 Intel Corporation > */ > > #ifndef _IDPF_CONTROLQ_API_H_ > @@ -158,8 +158,13 @@ enum idpf_mbx_opc { > /* Will init all required q including default mb. "q_info" is an array of > * create_info structs equal to the number of control queues to be created. > */ > +#ifdef NVME_CPF > +int idpf_ctlq_init(struct idpf_hw *hw, u8 num_q, > + struct idpf_ctlq_create_info *q_info, struct idpf_ctlq_info **ctlq); > +#else Same question as above. Also, a more general question on #ifdef - is it expected to be enabled somehow? > int idpf_ctlq_init(struct idpf_hw *hw, u8 num_q, > struct idpf_ctlq_create_info *q_info); > +#endif > > /* Allocate and initialize a single control queue, which will be added to the > * control queue list; returns a handle to the created control queue -- Thanks, Anatoly