From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Issue with non-scattered rx in ixgbe and i40e when mbuf private area size is odd
Date: Mon, 03 Aug 2015 00:32:02 +0200 [thread overview]
Message-ID: <8391226.fPvu0Dy7iE@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836A69E3D@irsmsx105.ger.corp.intel.com>
2015-07-29 18:12, Ananyev, Konstantin:
> As we don't support split header feature anyway, I think we can fix it just by always setting HBA in the RXD to zero.
> Could you try the fix for ixgbe below?
Please Konstantin, could you send a proper patch for this fix?
Thanks
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -1183,7 +1183,7 @@ ixgbe_rx_alloc_bufs(struct ixgbe_rx_queue *rxq, bool reset_mbuf)
>
> /* populate the descriptors */
> dma_addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(mb));
> - rxdp[i].read.hdr_addr = dma_addr;
> + rxdp[i].read.hdr_addr = 0;
> rxdp[i].read.pkt_addr = dma_addr;
> }
>
> @@ -1414,7 +1414,7 @@ ixgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
> rxe->mbuf = nmb;
> dma_addr =
> rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(nmb));
> - rxdp->read.hdr_addr = dma_addr;
> + rxdp->read.hdr_addr = 0;
> rxdp->read.pkt_addr = dma_addr;
>
> /*
> @@ -1741,7 +1741,7 @@ next_desc:
> rxe->mbuf = nmb;
>
> rxm->data_off = RTE_PKTMBUF_HEADROOM;
> - rxdp->read.hdr_addr = dma;
> + rxdp->read.hdr_addr = 0;
> rxdp->read.pkt_addr = dma;
> } else
> rxe->mbuf = NULL;
> @@ -3633,7 +3633,7 @@ ixgbe_alloc_rx_queue_mbufs(struct ixgbe_rx_queue *rxq)
> dma_addr =
> rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(mbuf));
> rxd = &rxq->rx_ring[i];
> - rxd->read.hdr_addr = dma_addr;
> + rxd->read.hdr_addr = 0;
> rxd->read.pkt_addr = dma_addr;
> rxe[i].mbuf = mbuf;
> }
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> index 6c1647e..16a9c64 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> @@ -56,6 +56,8 @@ ixgbe_rxq_rearm(struct ixgbe_rx_queue *rxq)
> RTE_PKTMBUF_HEADROOM);
> __m128i dma_addr0, dma_addr1;
>
> + const __m128i hba_msk = _mm_set_epi64x(0, UINT64_MAX);
> +
> rxdp = rxq->rx_ring + rxq->rxrearm_start;
>
> /* Pull 'n' more MBUFs into the software ring */
> @@ -108,6 +110,9 @@ ixgbe_rxq_rearm(struct ixgbe_rx_queue *rxq)
> dma_addr0 = _mm_add_epi64(dma_addr0, hdr_room);
> dma_addr1 = _mm_add_epi64(dma_addr1, hdr_room);
>
> + dma_addr0 = _mm_and_si128(dma_addr0, hba_msk);
> + dma_addr1 = _mm_and_si128(dma_addr1, hba_msk);
> +
> /* flush desc with pa dma_addr */
> _mm_store_si128((__m128i *)&rxdp++->read, dma_addr0);
> _mm_store_si128((__m128i *)&rxdp++->read, dma_addr1);
> bash-4.2$ cat patch1
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index a0c8847..94967c5 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -1183,7 +1183,7 @@ ixgbe_rx_alloc_bufs(struct ixgbe_rx_queue *rxq, bool reset_mbuf)
>
> /* populate the descriptors */
> dma_addr = rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(mb));
> - rxdp[i].read.hdr_addr = dma_addr;
> + rxdp[i].read.hdr_addr = 0;
> rxdp[i].read.pkt_addr = dma_addr;
> }
>
> @@ -1414,7 +1414,7 @@ ixgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
> rxe->mbuf = nmb;
> dma_addr =
> rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(nmb));
> - rxdp->read.hdr_addr = dma_addr;
> + rxdp->read.hdr_addr = 0;
> rxdp->read.pkt_addr = dma_addr;
>
> /*
> @@ -1741,7 +1741,7 @@ next_desc:
> rxe->mbuf = nmb;
>
> rxm->data_off = RTE_PKTMBUF_HEADROOM;
> - rxdp->read.hdr_addr = dma;
> + rxdp->read.hdr_addr = 0;
> rxdp->read.pkt_addr = dma;
> } else
> rxe->mbuf = NULL;
> @@ -3633,7 +3633,7 @@ ixgbe_alloc_rx_queue_mbufs(struct ixgbe_rx_queue *rxq)
> dma_addr =
> rte_cpu_to_le_64(RTE_MBUF_DATA_DMA_ADDR_DEFAULT(mbuf));
> rxd = &rxq->rx_ring[i];
> - rxd->read.hdr_addr = dma_addr;
> + rxd->read.hdr_addr = 0;
> rxd->read.pkt_addr = dma_addr;
> rxe[i].mbuf = mbuf;
> }
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> index 6c1647e..16a9c64 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c
> @@ -56,6 +56,8 @@ ixgbe_rxq_rearm(struct ixgbe_rx_queue *rxq)
> RTE_PKTMBUF_HEADROOM);
> __m128i dma_addr0, dma_addr1;
>
> + const __m128i hba_msk = _mm_set_epi64x(0, UINT64_MAX);
> +
> rxdp = rxq->rx_ring + rxq->rxrearm_start;
>
> /* Pull 'n' more MBUFs into the software ring */
> @@ -108,6 +110,9 @@ ixgbe_rxq_rearm(struct ixgbe_rx_queue *rxq)
> dma_addr0 = _mm_add_epi64(dma_addr0, hdr_room);
> dma_addr1 = _mm_add_epi64(dma_addr1, hdr_room);
>
> + dma_addr0 = _mm_and_si128(dma_addr0, hba_msk);
> + dma_addr1 = _mm_and_si128(dma_addr1, hba_msk);
> +
> /* flush desc with pa dma_addr */
> _mm_store_si128((__m128i *)&rxdp++->read, dma_addr0);
> _mm_store_si128((__m128i *)&rxdp++->read, dma_addr1);
prev parent reply other threads:[~2015-08-02 22:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 15:07 Martin Weiser
2015-07-29 18:12 ` Ananyev, Konstantin
2015-07-29 20:24 ` Zhang, Helin
2015-07-30 8:12 ` Olivier MATZ
2015-07-30 9:00 ` Ananyev, Konstantin
2015-07-30 9:10 ` Olivier MATZ
2015-07-30 9:43 ` Ananyev, Konstantin
2015-07-30 11:22 ` Olivier MATZ
2015-07-30 13:47 ` Thomas Monjalon
2015-07-30 13:56 ` [dpdk-dev] [PATCH] mbuf: enforce alignment of mbuf private area Olivier Matz
2015-07-30 14:13 ` Ananyev, Konstantin
2015-07-30 16:06 ` Olivier MATZ
2015-07-30 15:33 ` Zhang, Helin
2015-07-30 16:07 ` Olivier MATZ
2015-07-30 16:22 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2015-07-30 16:25 ` Zhang, Helin
2015-07-30 21:28 ` Ananyev, Konstantin
2015-08-02 22:35 ` Thomas Monjalon
2015-08-02 22:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8391226.fPvu0Dy7iE@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).