From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 2D6E0C4A2 for ; Mon, 29 Jun 2015 14:20:51 +0200 (CEST) Received: by wiga1 with SMTP id a1so69654194wig.0 for ; Mon, 29 Jun 2015 05:20:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=B5vpiO69kjnIen4e8LFNPxiraMALK1v7a9j6AsP9x8s=; b=QpTSIsRr+YNho4TznDPQp0amXdDiYQEZZP162DZA1r0FVG05U9En1gKepV0zaZ/nfC b+KjAOxdQjVEg2AC2tKu5hdHghz+Q7U4ho7yizKz8js7dS+8XuVAWN/3BgnIoi33krob 5rKqO1CbcIxxPRp9ImV7wjXAmnqTSGYla6Zrf7Blk9BU1PX6aGz1ivO2L+OIXJNau6pq kS7qy3Abf+qGouhRMEfoHby3LDXOvxC4BZ7Pajg8MooWWcHOR1T/Bec2elSTPMLKwV6g nx/ci/aIHy29Gt/056i6aRf1+HjAz4mGHkGWfFy1mmHXSxfnN0Gw0Y6kFOg6T9dMgMXI S+5w== X-Gm-Message-State: ALoCoQnk+NfGKeaT6fAaIBCtlwQLuvB1uPpfpSD5WzQirtcz6tm0vG88PQzY8veRiTq2qyVWCAac X-Received: by 10.194.184.14 with SMTP id eq14mr27871171wjc.58.1435580451047; Mon, 29 Jun 2015 05:20:51 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ee1sm11912894wic.8.2015.06.29.05.20.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 05:20:49 -0700 (PDT) From: Thomas Monjalon To: Adrien Mazarguil Date: Mon, 29 Jun 2015 14:19:41 +0200 Message-ID: <8398676.9XloqYzlxM@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <6446943.entjzpE8eR@xps13> <1435570492-19291-1-git-send-email-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: fix cpu_feature_table[] compilation with -pedantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 12:20:51 -0000 2015-06-29 14:10, David Marchand: > On Mon, Jun 29, 2015 at 11:34 AM, Adrien Mazarguil < > adrien.mazarguil@6wind.com> wrote: > > > Since the commit below includes rte_cpuflags.h in rte_spinlock.h, > > compilation of the mlx4 driver fails when CONFIG_RTE_LIBRTE_MLX4_DEBUG=y. > > > > This mode adds -pedantic to the compiler's command line for mlx4, which > > complains about the static definition of an empty cpu_feature_table[] in > > common rte_cpuflags.h, then about its redefinition as a larger array in > > arch-specific rte_cpuflags.h. > > > > While DPDK does not officially support -pedantic internally, external > > applications may enable it and include rte_spinlock.h from the public API. > > > > Instead of removing -pedantic from mlx4, this commit fixes rte_cpuflags.h. > > > > Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86") > > > > Signed-off-by: Adrien Mazarguil > > Acked-by: David Marchand Applied, thanks