From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 525C9A0A02; Thu, 25 Mar 2021 16:59:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D967140E52; Thu, 25 Mar 2021 16:59:44 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 39DD8140E4D for ; Thu, 25 Mar 2021 16:59:42 +0100 (CET) IronPort-SDR: U3wprO3ThajFNXk2pfVZRBKdwa37Ynykd6+EdGpHoVY0o45raSgFIh8lhBYW8A35NprdgIBWer AQ9qu6UU1UEA== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="254956565" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="254956565" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 08:59:41 -0700 IronPort-SDR: /XntOqaRUzvNgtYBVD7++u5lZ4O3p/nBLajMO9dY5cuCq+qlyM5NJzwuCSw2mT7H1HeCnhDsEi ktHCOEiD4WZQ== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="391792896" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.15.136]) ([10.252.15.136]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 08:59:40 -0700 From: Ferruh Yigit To: Jiawen Wu , dev@dpdk.org References: <20210325055141.629963-1-jiawenwu@trustnetic.com> <20210325055141.629963-4-jiawenwu@trustnetic.com> <603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com> X-User: ferruhy Message-ID: <839c556b-b4be-c8c6-a7ae-7cdc00645a09@intel.com> Date: Thu, 25 Mar 2021 15:59:36 +0000 MIME-Version: 1.0 In-Reply-To: <603dc490-6524-aac4-4865-5670d9ecb9ca@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/25/2021 10:19 AM, Ferruh Yigit wrote: > On 3/25/2021 5:51 AM, Jiawen Wu wrote: >> Add device arguments to support runtime options. >> And use these configuration to control the link setup flow, to adapt to >> different NIC's construction. Use firmware version to control the impact >> of firmware update. And fix some left bugs. >> >> Signed-off-by: Jiawen Wu > > <...> > >> +#define TXGBE_DEBUG_BP >> +#ifdef TXGBE_DEBUG_BP >> +#define BP_LOG(fmt, ...) \ >> +        RTE_LOG(CRIT, PMD, "[%lu.%lu]%s(%d): " fmt, \ >> +            usec_stamp() / 1000000, usec_stamp() % 1000000, \ >> +            __func__, __LINE__, ## __VA_ARGS__) >> +#else >> +#define BP_LOG(fmt, ...) do { } while (0) >> +#endif >> + >>   #endif /* _TXGBE_LOGS_H_ */ >> > > The 'BP_LOG' looks like used for developer debug prints, if so I suggest > removing them completely, > but if not can you please convert it dynamic logging, or using existing dynamic > logs 'txgbe_logtype_init', 'txgbe_logtype_driver'? > Also, 'usec_stamp()' seems returning 'uint64_t', if so shouldn't use '%l' since that will fail on 32bit, instead please prefer 'PRIu64'.