From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F3BE454AB; Thu, 20 Jun 2024 17:21:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 133F142D55; Thu, 20 Jun 2024 17:21:27 +0200 (CEST) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id DB1CA4281D for ; Thu, 20 Jun 2024 17:21:25 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4W4kgW08Mmz6K9BG; Thu, 20 Jun 2024 23:19:51 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 7188C140517; Thu, 20 Jun 2024 23:21:24 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 20 Jun 2024 17:21:24 +0200 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Thu, 20 Jun 2024 17:21:24 +0200 From: Konstantin Ananyev To: Bruce Richardson , "dev@dpdk.org" Subject: RE: [PATCH] net/*: replace intrinsic header include with rte_vect Thread-Topic: [PATCH] net/*: replace intrinsic header include with rte_vect Thread-Index: AQHaww4GkzJt8GbdbEOSznyE91SYRbHQxLpA Date: Thu, 20 Jun 2024 15:21:24 +0000 Message-ID: <83a8e632eb4049faa69ca8eba8a4dc2e@huawei.com> References: <20240620123218.1936250-1-bruce.richardson@intel.com> In-Reply-To: <20240620123218.1936250-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.138.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Rather than having the SSE code in each driver include tmmintrin.h, > which often does not contain all needed intrinsics, e.g. > _mm_cvtsi128_si64() for 32-bit x86 builds, we can just replace the > include of ?mmintrin.h with rte_vect.h for all network drivers. >=20 > Signed-off-by: Bruce Richardson > --- > drivers/net/fm10k/fm10k_rxtx_vec.c | 2 +- > drivers/net/i40e/i40e_rxtx_vec_sse.c | 2 +- > drivers/net/iavf/iavf_rxtx_vec_sse.c | 2 +- > drivers/net/ice/ice_rxtx_vec_sse.c | 2 +- > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 2 +- > drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 2 +- > drivers/net/ngbe/ngbe_rxtx_vec_sse.c | 2 +- > drivers/net/txgbe/txgbe_rxtx_vec_sse.c | 2 +- > drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k= _rxtx_vec.c > index 62119de373..9a84775cb1 100644 > --- a/drivers/net/fm10k/fm10k_rxtx_vec.c > +++ b/drivers/net/fm10k/fm10k_rxtx_vec.c > @@ -10,7 +10,7 @@ > #include "fm10k.h" > #include "base/fm10k_type.h" >=20 > -#include > +#include >=20 > #ifndef __INTEL_COMPILER > #pragma GCC diagnostic ignored "-Wcast-qual" > diff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c b/drivers/net/i40e/i40e= _rxtx_vec_sse.c > index 2d4480a765..ad560d2b6b 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_sse.c > +++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c > @@ -12,7 +12,7 @@ > #include "i40e_rxtx.h" > #include "i40e_rxtx_vec_common.h" >=20 > -#include > +#include >=20 > #ifndef __INTEL_COMPILER > #pragma GCC diagnostic ignored "-Wcast-qual" > diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf= _rxtx_vec_sse.c > index 96f187f511..0db6fa8bd4 100644 > --- a/drivers/net/iavf/iavf_rxtx_vec_sse.c > +++ b/drivers/net/iavf/iavf_rxtx_vec_sse.c > @@ -10,7 +10,7 @@ > #include "iavf_rxtx.h" > #include "iavf_rxtx_vec_common.h" >=20 > -#include > +#include >=20 > #ifndef __INTEL_COMPILER > #pragma GCC diagnostic ignored "-Wcast-qual" > diff --git a/drivers/net/ice/ice_rxtx_vec_sse.c b/drivers/net/ice/ice_rxt= x_vec_sse.c > index 9a1b7e3e51..c01d8ede29 100644 > --- a/drivers/net/ice/ice_rxtx_vec_sse.c > +++ b/drivers/net/ice/ice_rxtx_vec_sse.c > @@ -4,7 +4,7 @@ >=20 > #include "ice_rxtx_vec_common.h" >=20 > -#include > +#include >=20 > #ifndef __INTEL_COMPILER > #pragma GCC diagnostic ignored "-Wcast-qual" > diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/i= xgbe_rxtx_vec_sse.c > index f60808d576..a77370cdb7 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c > @@ -10,7 +10,7 @@ > #include "ixgbe_rxtx.h" > #include "ixgbe_rxtx_vec_common.h" >=20 > -#include > +#include >=20 > #ifndef __INTEL_COMPILER > #pragma GCC diagnostic ignored "-Wcast-qual" > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.h b/drivers/net/mlx5/mlx5= _rxtx_vec_sse.h > index 2bdd1f676d..93d6d1b5f0 100644 > --- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.h > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.h > @@ -9,7 +9,7 @@ > #include > #include > #include > -#include > +#include >=20 > #include > #include > diff --git a/drivers/net/ngbe/ngbe_rxtx_vec_sse.c b/drivers/net/ngbe/ngbe= _rxtx_vec_sse.c > index f703d0ea15..b128bd3a67 100644 > --- a/drivers/net/ngbe/ngbe_rxtx_vec_sse.c > +++ b/drivers/net/ngbe/ngbe_rxtx_vec_sse.c > @@ -11,7 +11,7 @@ > #include "ngbe_rxtx.h" > #include "ngbe_rxtx_vec_common.h" >=20 > -#include > +#include >=20 > static inline void > ngbe_rxq_rearm(struct ngbe_rx_queue *rxq) > diff --git a/drivers/net/txgbe/txgbe_rxtx_vec_sse.c b/drivers/net/txgbe/t= xgbe_rxtx_vec_sse.c > index 12eb4aeef5..1a3f2ce3cd 100644 > --- a/drivers/net/txgbe/txgbe_rxtx_vec_sse.c > +++ b/drivers/net/txgbe/txgbe_rxtx_vec_sse.c > @@ -10,7 +10,7 @@ > #include "txgbe_rxtx.h" > #include "txgbe_rxtx_vec_common.h" >=20 > -#include > +#include >=20 > static inline void > txgbe_rxq_rearm(struct txgbe_rx_queue *rxq) > diff --git a/drivers/net/virtio/virtio_rxtx_simple_sse.c b/drivers/net/vi= rtio/virtio_rxtx_simple_sse.c > index 6a18741b6d..d53acc4fd6 100644 > --- a/drivers/net/virtio/virtio_rxtx_simple_sse.c > +++ b/drivers/net/virtio/virtio_rxtx_simple_sse.c > @@ -8,7 +8,7 @@ > #include > #include >=20 > -#include > +#include >=20 > #include > #include > -- Acked-by: Konstantin Ananyev > 2.43.0