From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9301FA04B1; Wed, 23 Sep 2020 09:14:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73DF91D637; Wed, 23 Sep 2020 09:14:16 +0200 (CEST) Received: from incedge.chinasoftinc.com (unknown [114.113.233.8]) by dpdk.org (Postfix) with ESMTP id E6FC51D5B2 for ; Wed, 23 Sep 2020 09:14:14 +0200 (CEST) X-ASG-Debug-ID: 1600845253-149d111baf1f9150001-TfluYd Received: from mail.chinasoftinc.com (inccas001.ito.icss [10.168.0.51]) by incedge.chinasoftinc.com with ESMTP id TJvjErPLiPNRvbqR (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Sep 2020 15:14:13 +0800 (CST) X-Barracuda-Envelope-From: huwei013@chinasoftinc.com X-Barracuda-RBL-Trusted-Forwarder: 10.168.0.51 X-ASG-Whitelist: Client Received: from [192.168.1.199] (139.159.243.11) by INCCAS001.ito.icss (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Wed, 23 Sep 2020 15:14:13 +0800 X-Barracuda-RBL-Trusted-Forwarder: 192.168.1.199 To: Ajit Khaparde X-ASG-Orig-Subj: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: retain original FDIR mode when configuring DCB CC: dpdk-dev , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Jijiang Liu , Jingjing Wu , Helin Zhang , "Wei Hu (Xavier" , , Ferruh Yigit References: <20200908021603.44862-1-huwei013@chinasoftinc.com> <20200908021603.44862-3-huwei013@chinasoftinc.com> From: "Wei Hu (Xavier)" Message-ID: <83a980af-e24f-43be-b1a8-aa22af7105d8@chinasoftinc.com> Date: Wed, 23 Sep 2020 15:14:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [139.159.243.11] X-Barracuda-Connect: inccas001.ito.icss[10.168.0.51] X-Barracuda-Start-Time: 1600845253 X-Barracuda-Encrypted: ECDHE-RSA-AES256-SHA X-Barracuda-URL: https://incspam.chinasofti.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at chinasoftinc.com X-Barracuda-Scan-Msg-Size: 5285 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: retain original FDIR mode when configuring DCB X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ajit Khaparde On 2020/9/22 13:15, Ajit Khaparde wrote: > On Mon, Sep 7, 2020 at 7:16 PM Wei Hu (Xavier) > wrote: >> From: Huisong Li >> >> Sometimes, we have to start testpmd application with --pkt-filter-mode to >> test flow table feature. When using 'port config 0 dcb vt off 4 pfc on' >> command, the dcb information are configured in init_port_dcb_config >> function by get_eth_dcb_conf function, And then rte_eth_dev_configure API >> function will be called to re-configure PMD driver. >> >> The values of rxmode and txmode in rte_eth_conf struct used to configure >> PMD driver, come from the current values maintained in testpmd. However, >> the fdir_conf.mode in rte_eth_conf struct is not set, which may cause that >> some PMD driver cannot test the flow table feature when multiple TCs are >> enabled. >> >> Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li >> Signed-off-by: Wei Hu (Xavier) >> --- >> app/test-pmd/testpmd.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c >> index 73543bb..19bf972 100644 >> --- a/app/test-pmd/testpmd.c >> +++ b/app/test-pmd/testpmd.c >> @@ -3521,6 +3521,7 @@ init_port_dcb_config(portid_t pid, >> >> port_conf.rxmode = rte_port->dev_conf.rxmode; >> port_conf.txmode = rte_port->dev_conf.txmode; >> + port_conf.fdir_conf.mode = rte_port->dev_conf.fdir_conf.mode; > This is probably not necessary. FDIR is due for deprecation [1]. > https://doc.dpdk.org/guides/rel_notes/deprecation.html Thanks your for pointing out it, this patch is really necessary. Thanks, Xavier >> /*set configuration of DCB in vt mode and DCB in non-vt mode*/ >> retval = get_eth_dcb_conf(pid, &port_conf, dcb_mode, num_tcs, pfc_en); >> -- >> 2.9.5 >>