From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 699E641C35; Wed, 8 Feb 2023 03:07:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECFF842670; Wed, 8 Feb 2023 03:07:54 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2088.outbound.protection.outlook.com [40.107.95.88]) by mails.dpdk.org (Postfix) with ESMTP id 9021740DDB; Wed, 8 Feb 2023 03:07:52 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gPOHbRSevuWhsBLppMWogsWXrSNMdaUp6BRPxWsTd0IUVLT6G0GKq+ujzaopw2ThHPvCfZMhs/LeMCY37khj/pxiaF4xMLnqOycEF5tqQy9MTPdNRQlJ34f1hzHG+oT83Qt9W9lZmFe4isiQtIIpWu2409O9nWwrY/CdBVtMevebyKqWZAjXgwdKa7loBsChkN30nR6hogbtnI7NbYd/KKTy5eBRYmMBgW8QVHwl3mwv2y+k7pWt4A6piZXyJ7hmqSJWxIBy3nLJiTdlAgYTG1SLka4HELtirAQIXO+dbzm6ujIhLXt7v+cpReic0rVH+eNcGbsJKl0WtF0J9b8JBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dUFEH9+mIN9unO46FhNZYlgscY+EpUfsk5hJmG6LAKU=; b=Y4/GdSKMZJepah2tvfb0qNTX8odJjd97osQzCzl0taAqG4SVwNwWpQwqXCyjPkCXRtfXrY/k68IO6sfjQW0rMvlE0u8NaDmeClLUIql+e/bwaprn9vfX6UONginhtGKKtGbj3cpBngZ1RvtgSOhftM8O8JdmFtdnQ+sBC4aZWxgIK7/Wr1ZFN6rzCkkmbD2miSLVVZb8M0Yq5zRVA3jjNZWktV2lJ4v5AObwrGok2SaO9W2UQ/+hZ2apx+xGGDoHZ5jVrHqNeHvH7zesc35GBO5/umnu1sq0f9ssKtiOGgZvY85s51kDHW9JCtk+E+0zeO8LX0XKPeE8Ssm7kLnDLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dUFEH9+mIN9unO46FhNZYlgscY+EpUfsk5hJmG6LAKU=; b=UlbsLdT9mt4DHxjGGMSS0WCZsDiW7sgquYujFsxjo230GzF7pcQMcpdYBcuU3abyQDXoSsY9Lg6DMYpA+s8x/qSj/bBRMpTev+FPA5oe1VVjbFNbEukvdXjWlp+H0xVjevCJeyVtMnQjPGRQZPs6jx9Z3Lwq9GuSnP9d6j2UmSE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW3PR12MB4377.namprd12.prod.outlook.com (2603:10b6:303:55::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 02:07:47 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6064.034; Wed, 8 Feb 2023 02:07:47 +0000 Message-ID: <83ed5136-cf48-8938-5174-f622b76d0552@amd.com> Date: Wed, 8 Feb 2023 02:07:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] app/testpmd: fix forwarding stats for Tx dropped Content-Language: en-US To: "Singh, Aman Deep" , Yuying Zhang , David Marchand , Ferruh Yigit , Maxime Coquelin , "lihuisong (C)" Cc: dev@dpdk.org, stable@dpdk.org, Joshua Washington References: <20230131115603.640254-1-ferruh.yigit@amd.com> <4c995d84-82f0-6c4c-b189-14da06f013ea@intel.com> From: Ferruh Yigit In-Reply-To: <4c995d84-82f0-6c4c-b189-14da06f013ea@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0009.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW3PR12MB4377:EE_ X-MS-Office365-Filtering-Correlation-Id: 61d0ee93-fc52-4f7d-2441-08db097945f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j18Eq3M4FUmx9kE5cGaDCgs5a8eHQR4Zr9qKLJa++qxZ2OBtmMBeJWFvXomTHKq6SjVh4sCiyGybE5gs+3DWiEfHo4x6WHmo+Wbvm92K8bvRa2AIYQOY9iVjCTqR4fKThaz3tQHJDTBVX0qIoKMpWRp7MZ/THNEum4PrfcyARvl0yHlU+0xcgw3oY/8OxOqyEUTulPC637h06Rf9uc1a/9MEkssywoBbkx3Chsav3avTa/mh0UOffdC7b9hVZjV0vhHsZ3Rv/aqZuVNodTXT9FB9Ff5Imo67xcG7T62h3cD/UiMoK9KqoEMdWIeiqJ1/+yVYmzJMdWP9E2k6Co4i6AmUq+RrZd1+3lQN6zZJLuMOGGPwgIFqZbJ6wwavvkjgjMoAau8SLBaRKhQbjK+nDMOJsbSE1Y60OyAOIVBN49JgtFr1c5AEsqSxVqJJz7UDeKy09OuR/aDRTskndpU4usjfRmda4F3N2AlrNMSMb7F0VbsPi71k60Zx6qjSTzeD3JezSJqXDQej7gHy9jVGErG2LhhLh/ohDuL9szuaKdnbRbsWNKPJWLIRPbWXiRrPTd19kAfhMICOd8kXJzBWC/+lgU4E0VrLAZ3LuzQQRDjZkfsVnHlhOgRh5cYvu841v/8uipYqYLWtIN17QXHIQ9nYwd0P/OfPPeFg+lFpJgQZShXljXXT9hMpKmCvoUqaAL+PXkPFtA1WQPES2MEhEM3/1St7H5lIAZgUwKu5wUs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(346002)(396003)(366004)(376002)(136003)(451199018)(8936002)(86362001)(4744005)(41300700001)(44832011)(5660300002)(4326008)(8676002)(66476007)(66556008)(316002)(110136005)(36756003)(66946007)(2906002)(31696002)(2616005)(83380400001)(6506007)(26005)(186003)(53546011)(6512007)(6666004)(38100700002)(31686004)(6486002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0FXMDgwV2hqL0JFNExtQTBQWENJTytCUzRhSW5QSUJORTRpMm1jdnRaL2Ny?= =?utf-8?B?Ylp3eUcrd1JOK3VSNGhXUm5MZG1qTXowdmVQc2xMY1BlcFFTMzdUVGtUZXhU?= =?utf-8?B?UzRpODNYdEtpbW0yWHJOWU5UdUFQa081TldFZCtEbEVhSCtJanBtY05ONjYz?= =?utf-8?B?SzlIejdKNGRESTM1Y2Y2Wm5xOVRUUjQ2YzJPQUxGdkJkKyt1LzB3Tjl0YkhE?= =?utf-8?B?QWlKWk1QdkNUWngwNmZTQ3lBK2RtUkRmVXFxM2o3bk9kSlhpRENScTFHb3JW?= =?utf-8?B?RjEyakcycFZXYm1vOGFlaklSU1lIM1YzS3JvbFdVeFFxcldRVFB5dUdERGl0?= =?utf-8?B?OTcyNk9RNm95MGp4czdlVGJJM2hhYXR6d1ZZTkQ4UWtlUmVWNWp1cVh1dGlW?= =?utf-8?B?NVVtWDNvVHU3eDFiYWxKamJrM3cyZXBjUDlwNElNdnlDVnhSV0dmUkF6bUdK?= =?utf-8?B?RktFL05NdkJSV1NNY1NJQStBazgycTg4YjB0NmhneG5xMVBLRlN5RVB6WUx5?= =?utf-8?B?bXJEN2tIaHljR0xOdWlmM05Lek5jcWRaSWhrajZpemhaN2pFaCtmMDBwSGxB?= =?utf-8?B?eS96WFpVS2o4MFd6clpmRnRnOEFpUmR6VXNzMXVmdTZFM1lMZG15YVdMNXgw?= =?utf-8?B?YTNJWXMzN2hlQ1ZqbWV4Rkk1eHN0aFducWlSd3Z3ZTZ6Vis0ZnUwdTNRR25T?= =?utf-8?B?UmoyMnREc1ZXUk1UcnVwR3JMc2RNSUpNZHZ4WS8rZmRTc1hXTHlWZkoyc1lX?= =?utf-8?B?MEJwTFM5UmU1blB3Zk1XdzlRdGJqV0k1dTNyK0U0Sk5jOFBueDFjTWJBcS9U?= =?utf-8?B?b2xjQ213aHZaTnJEbGVhNGUyNjg1WXBjc1cwcEtQTjlyblpKU1FKTlRKVW9p?= =?utf-8?B?Z1luWDBsSFQ4cnhNZm1DWGxtMzZ2YWdIbkhrWXU3cVovYnFPT3ltMmUzZnBr?= =?utf-8?B?REh5YWs0OVl0L1Fzb2VxMHMydTE0bDEvUWFIeXZ3RXJMYXkvVzRuMUpraWVj?= =?utf-8?B?RzJVVVJLejZCV0ZnOWhUMlp0Mnc4QnFZZXNSbVJrRHdOKzAzUGU1aHZVRGJr?= =?utf-8?B?bEZEenF2dm40ZytxSHJqN0IzV242ZFVjU2c5V0hSNFVwL2d0YjhjV1VPODhm?= =?utf-8?B?QW9Sa2hpL1puOXdsN2dsQ0p6YTYzeEEwZFFjZDRlNFV0dTNjN0VRVCtkQzYx?= =?utf-8?B?RVB1MUVQeTFPalAybW1aeGcrOUNZNGk4aDcwenBmS0dMenB4QXQwRzlRdXBM?= =?utf-8?B?TElGWld2b0N4aHNJMFo0NHE1d2liRi9IKytDK1lHTDRZQWJrSS9uSWQvRTdI?= =?utf-8?B?cUNTZkNMSlpoUnBHOGV2RTdoWHBOOGV5V1VaRjNNNnNJWjErTUt5OThNZW8y?= =?utf-8?B?UEY4VkpyRm5SRndnQjhDZ2JWSllHK3RvdVVvbG82bXZEcUp0bFA5SjRWZUx4?= =?utf-8?B?RUEzVzFaR1I0YXlJNS85VUF0aWRhQy9tZW1lSktBekhIOEFKVE1lTkc2TmxE?= =?utf-8?B?aERUcFZRTkVhWjFyWEpqTU1mSkZ0Z1pYVkI3UlcwOTVnZmZENjdhZ1UxVVYw?= =?utf-8?B?TVFmMmVxdm5kdWd0SE1acFBTdEZaVGF5enhYVVZ6RENMMnJ1cVVraWprSG1X?= =?utf-8?B?bHlCZmIwOWpuejVhSnNUekZJaERZT0lKU3RQclRrZEZiTG1xUWN4R0N6MTVh?= =?utf-8?B?NkVEbXVtU0N0elVjcnU4M0ZxdVFFR3NzcnZnY3REODFnREM1L1RDbzNXSmVj?= =?utf-8?B?SE1UeGVqKytCeFl1N3JDVXpzZDh2SFNMZHpid3o0L1AzMlF3Vzc3SUNCNTVp?= =?utf-8?B?eW82eUc4bjJrTUlPNGtCdWhJWXByMmJ2aGMxdVorUG9kUmJHdlV2M2t3bmF5?= =?utf-8?B?L1g4Sk5vaWNWNnNIZ2R4cVFjbFIzNTRBNnppMVIvVlN4RFlrbTVDMDViUUxH?= =?utf-8?B?dS8rNzl2OVU4VXpEZ3N2akNUYTZlaVhaVkRyQjBLUnFOQU9RUzNYeUxjUkI3?= =?utf-8?B?NjRuRWt2aFBkOFErWUYxVDlQdzBGem12TG9rUkJkbmY4QlBPa1dMaUp2WXpq?= =?utf-8?B?cExya1NoMWFqMEd5cDllR210Z1AzVXRVOEhIdWdvTHNTZXJqTlZCaWluaUhL?= =?utf-8?Q?e65gHaemcuYDIP243X0fWoYwi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61d0ee93-fc52-4f7d-2441-08db097945f6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 02:07:47.5009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NcAj6EvwzmVC8rxTm95V0oWaUdNzybs28xQSl/T7763wXEewZ3lvhuNfinD6q7JX X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4377 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2023 10:10 AM, Singh, Aman Deep wrote: > > On 1/31/2023 5:26 PM, Ferruh Yigit wrote: >> There is an inconsistency at displaying Tx dropped value for per port >> forwarding stats and accumulated forwarding stats. >> >> While displaying per port TX-dropped value, it only takes >> 'ports_stats[pt_id].tx_dropped' into account, >> but for accumulated TX-dropped results it takes both >> 'ports_stats[pt_id].tx_dropped' & 'stats.oerrors' into account. >> >> To fix, make both per port and accumulated stats display 'tx_dropped' >> and 'stats.oerrors' (ports_stats[pt_id].tx_dropped + stats.oerrors). >> >> Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on >> demand") >> Cc: stable@dpdk.org >> >> Reported-by: Joshua Washington >> Signed-off-by: Ferruh Yigit > > Acked-by: Huisong Li > > Acked-by: Aman Singh > Applied to dpdk-next-net/main, thanks.