From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFF88A0350; Mon, 11 May 2020 18:09:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A3831C19F; Mon, 11 May 2020 18:09:39 +0200 (CEST) Received: from qrelay214.mxroute.com (qrelay214.mxroute.com [172.82.139.214]) by dpdk.org (Postfix) with ESMTP id D59E81C133 for ; Mon, 11 May 2020 18:09:38 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay214.mxroute.com (ZoneMTA) with ESMTPA id 172047fa960000add6.001 for ; Mon, 11 May 2020 16:09:34 +0000 X-Zone-Loop: 01eff7fc3f7af9062974909bdc5274ed9c77169e536d X-Originating-IP: [149.28.56.236] Received: from galaxy.mxroute.com (unknown [23.92.70.113]) by filter004.mxroute.com (Postfix) with ESMTPS id 6CB563E9E8; Mon, 11 May 2020 16:09:29 +0000 (UTC) Received: from [192.198.151.44] by galaxy.mxroute.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1jYAYW-0000nz-3h; Mon, 11 May 2020 11:41:24 -0400 To: Akhil Goyal , Arek Kusztal , "dev@dpdk.org" Cc: "fiona.trahe@intel.com" , "ray.kinsella@intel.com" , "bruce.richardson@intel.com" References: <20200507105703.11804-1-arkadiuszx.kusztal@intel.com> <20200507105703.11804-2-arkadiuszx.kusztal@intel.com> <07efe718-39ea-8b6e-a201-433ea2c64357@ashroe.eu> From: Ray Kinsella Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <83f61f31-d474-dd5e-2cd8-4815de54d897@ashroe.eu> Date: Mon, 11 May 2020 17:09:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Seems to be an issues on my side (see below). Everything that the ABI Compliance Checker 2.3 complains about has already been reported and suppressed in libabigail.ignore. Suggest you use libabigail going forward. Oddly enough Fedora 31 / ABI Compliance Checker 2.3 [root@xyz abi-check]# abi-compliance-checker -l librte_cryptodev.so -old 24cd1b529/librte_cryptodev.so.dump -new 26c1ec175/librte_cryptodev.so.dumpPreparing, please wait ... Comparing ABIs ... Comparing APIs ... Creating compatibility report ... Binary compatibility: 100% Source compatibility: 100% Total binary compatibility problems: 0, warnings: 0 Total source compatibility problems: 0, warnings: 0 Report: compat_reports/librte_cryptodev.so/24cd1b529_to_26c1ec175/compat_report.html Ubuntu 18.04/ ABI Compliance Checker 2.2 root@abc:/build/dpdk-next-crypto/abi-check# abi-compliance-checker -l librte_cryptodev.so -old 6ef23d92d/librte_cryptodev.so.dump -new 6488cc1cf/librte_cryptodev.so.dump Preparing, please wait ... Comparing ABIs ... Comparing APIs ... Creating compatibility report ... Binary compatibility: 99.4% Source compatibility: 100% Total binary compatibility problems: 1, warnings: 1 Total source compatibility problems: 0, warnings: 0 Report: compat_reports/librte_cryptodev.so/6ef23d92d_to_6488cc1cf/compat_report.html Ray K On 11/05/2020 09:18, Akhil Goyal wrote: > Hi Ray, > > Previously, I only ran the script for the 2 patches. > > ./devtools/validate-abi.sh HEAD > > However when I run for v20.02 and HEAD, the list is quite big. I believe most of them are either experimental or internal PMD. But cryptodev is still there. > > NOTICE: abi-compliance-checker returned 1 > NOTICE: ABI may be incompatible, check reports/logs for details. > NOTICE: Incompatible list: librte_bbdev.so librte_common_iavf.so librte_common_octeontx2.so librte_cryptodev.so librte_eal.so librte_efd.so librte_eventdev.so librte_hash.so librte_ipsec.so librte_meter.so librte_pdump.so librte_pmd_crypto_scheduler.so librte_pmd_dpaa2_sec.so librte_pmd_dpaa_sec.so librte_pmd_ring.so librte_ring.so librte_vhost.so > > Regards, > Akhil > >> -----Original Message----- >> From: Ray Kinsella >> Sent: Monday, May 11, 2020 1:18 PM >> To: Akhil Goyal ; Arek Kusztal >> ; dev@dpdk.org >> Cc: fiona.trahe@intel.com; ray.kinsella@intel.com; bruce.richardson@intel.com >> Subject: Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get >> function >> >> Hi Akhil, >> >> So 1st thing is that this that validate-abi uses "ABI Compliance Checker", >> which does not use libabigail.ignore. >> >> So you will end up with different results compared to using libabigail as follows: >> >> DPDK_ABI_REF_DIR= >> DPDK_ABI_REF_VERSION=v20.02 ./devtools/test-meson-builds.sh >> >> I did check with the "ABI Compliance Checker" (I like this tool also), however I >> got the following >> >> NOTICE: No error detected, ABI is compatible. >> INFO: Logs are in /root/src/dpdk/abi-check/abi-check.log >> INFO: HTML reports are in /root/src/dpdk/abi-check/compat_reports directory >> >> What references did you use with validate-abi.sh (I used v20.02 and HEAD). >> >> Ray K >> >> On 09/05/2020 22:11, Akhil Goyal wrote: >>> Hi Ray/Arek, >>> >>> I still see Incompatible cryptodev even after update in the abignore list. >>> I checked it with ./devtools/validate-abi.sh >>> NOTICE: ABI may be incompatible, check reports/logs for details. >>> NOTICE: Incompatible list: librte_cryptodev.so >>> >>> Did I miss something? >>> >>> >>>> >>>> On 07/05/2020 11:57, Arek Kusztal wrote: >>>>> This patch adds versioned function rte_cryptodev_info_get() >>>>> to prevent some issues with ABI policy. >>>>> Node v21 works in same way as before, returning driver capabilities >>>>> directly to the API caller. These capabilities may include new elements >>>>> not part of the v20 ABI. >>>>> Node v20 function maintains compatibility with v20 ABI releases >>>>> by stripping out elements not supported in v20 ABI. Because >>>>> rte_cryptodev_info_get is called by other API functions, >>>>> rte_cryptodev_sym_capability_get function is versioned the same way. >>>>> >>>>> Signed-off-by: Arek Kusztal >>>>> --- >>>>> v2: >>>>> - changed version numbers of symbols to 20.0.2 >>>>> v3: >>>>> - added v2/v3 informations >>>>> - changed version numbers of symbols to 21 >>>>> v4: >>>>> - fixed clang build by movind binding default symbol >>>>> - implemented mailing list comments >>>>> - added abidiff tool suppression entries >>>>> v5: >>>>> - fixed meson build >>>>> >>>>> devtools/libabigail.abignore | 8 ++ >>>>> lib/librte_cryptodev/meson.build | 1 + >>>>> lib/librte_cryptodev/rte_cryptodev.c | 147 >>>> ++++++++++++++++++++++++- >>>>> lib/librte_cryptodev/rte_cryptodev.h | 34 +++++- >>>>> lib/librte_cryptodev/rte_cryptodev_version.map | 7 ++ >>>>> 5 files changed, 191 insertions(+), 6 deletions(-) >>>>> >>>> [SNIP] >>>> >>>> Acked-by: Ray Kinsella