From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DCAFF2B8C for ; Tue, 25 Sep 2018 10:03:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 01:03:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,301,1534834800"; d="scan'208";a="89104588" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2018 01:03:27 -0700 To: Thomas Monjalon Cc: Rahul Lakkireddy , Wenzhuo Lu , Qi Zhang , Xiao Wang , Konstantin Ananyev , Rasesh Mody , Harish Patil , Shahed Shaikh , Yong Wang , dev@dpdk.org References: <20180920001853.23454-1-thomas@monjalon.net> <1920676.XclAJlGjTg@xps> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <840d806c-d75c-f990-5883-1315ea37f95b@intel.com> Date: Tue, 25 Sep 2018 09:03:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1920676.XclAJlGjTg@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 08:03:37 -0000 On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > 24/09/2018 17:06, Ferruh Yigit: >> On 9/20/2018 1:18 AM, Thomas Monjalon wrote: >>> -#define false FALSE >>> -#define true TRUE >> >> TRUE and FALSE also defined in this patch, can we remove them too? > > I don't see the need to remove TRUE and FALSE. > The base drivers use them on other platforms, and it is convenient to not > change the base drivers. Not needed, but previously it was only TRUE & FALSE, and true & false was define to them. Now there are TRUE & FALSE from header files and true & false from stdbool and these pairs used interchangeably, I thought it can better to unify the usage to stdbool ones. > > [...] >>> static int >>> ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed, >>> - int *link_up, int wait_to_complete) >>> + bool *link_up, int wait_to_complete) >> >> Also need to change "wait_to_complete" to bool because below changes start >> sending bool type to this function. > > [...] >>> --- a/drivers/net/ixgbe/ixgbe_rxtx.c >>> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c >>> @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, >>> struct ixgbe_rx_entry *next_rxe = NULL; >>> struct rte_mbuf *first_seg; >>> struct rte_mbuf *rxm; >>> - struct rte_mbuf *nmb; >>> + struct rte_mbuf *nmb = NULL; >> >> This change is unrelated. Can we separate this one? > > Yes it looks unrelated but it becomes necessary when including stdbool.h. > I don't know the root cause, but yes, it may deserve a separate commit. > Maybe an ixgbe maintainer can take care of it? Why becomes necessary? Does it give a build warning etc? My concern is this is in data path, one extra assignment, it would be better to confirm it is really needed.