Re: [dpdk-dev] [PATCH] examples/vhost_blk: use common macros for min/max

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 2/22/20 12:50 AM, Tiwei Bie wrote:
> On Fri, Feb 21, 2020 at 07:29:13PM +0100, Thomas Monjalon wrote:
>> 20/02/2020 03:52, Tiwei Bie:
>>> On Wed, Feb 19, 2020 at 11:39:22AM +0100, Thomas Monjalon wrote:
>>>> The macros RTE_MIN and RTE_MAX can be used in DPDK applications.
>>
>> Only RTE_MIN is used in this patch. The title is wrong as well.
> 
> Make sense! The commit log should describe what's changed
> by the patch exactly.
> 
>>
>>
>>>> This change implies fixing the sign of used_len as size_t
>>>> as defined in vhost_strcpy_pad().
>>>>
>>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>>> ---
>>>>  examples/vhost_blk/blk.c              | 4 ++--
>>>>  examples/vhost_blk/vhost_blk.h        | 2 --
>>>>  examples/vhost_blk/vhost_blk_compat.c | 2 +-
>>>>  3 files changed, 3 insertions(+), 5 deletions(-)
>>>
>>> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
>>
>>
>>
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I'll fixup the patch when applying.

Thanks,
Maxime