From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A60EA0C45; Thu, 25 Nov 2021 13:47:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCA39426E3; Thu, 25 Nov 2021 13:47:08 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 218D0426E2 for ; Thu, 25 Nov 2021 13:47:06 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10178"; a="235449764" X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="235449764" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2021 04:47:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="592012664" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by FMSMGA003.fm.intel.com with ESMTP; 25 Nov 2021 04:47:05 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 25 Nov 2021 04:47:04 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 25 Nov 2021 04:47:04 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 25 Nov 2021 04:47:04 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 25 Nov 2021 04:47:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RqwCm3Mjc+uPAhmmRztMkCF6e2KKtPFVxMP0FehDi/Ah5uKIBlK7sedNOyz1AUd/uKFE03eWOvGnatfVlXVFmYX0VRHg9PTykcgFg8dOiCkflVAZX8WeGl3p7NQO9UxPMK5OxcMWr0igMIbOiV687sVcJ2irvFkIqGCT10FPqCiKpf2Gn2MnDuWQDLtkYBuAdakOwmoqB0YCzssqn3vEGRFnZEkWimzt83Qg1orOod89+dTTgcXyrr81gKVFLzW0HP9y+a7DoF/x5PDgDC4jtJ8mXAeG6BnnC7aGWn2ZoEmTgz4hmNuw3n9fWWe3ZfxGxEFauyKgxblyXIYJc3uPhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k77GV+6KcC8/kWvjQ1xR2Wo5t+dWhrzqkmCj++88XtI=; b=mvQ1dWRmgb1EN603mDqoXz7Hf1mP6+rJwJg8diLzN7dP/lJTtA8xLHx6R88HuKB8B+GsaPX8j0gAswjR0mqZjmN9tAbIb4CP2/d7mzBUx6/xRWsWSefrmLcK+NX7dlTseGkdE6vK9FU21zH+9mEpB+5FeACv531a8HXKZ4IU309drCrKycf4j2mTiP7hbAgUKECPAT3cgRGvhYPA2pO/3v8mzTlhG524Gs1K80SSadyXZAztjKWCnZ1baJoqm705GXeT8HiFbhchBtCEYVfDZYGtDD0OsNl1EFeSHL68FUvg+OrQ0cnDcIfb2MnRhDfxdU4xAGt8J5I/IHMGLalf6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k77GV+6KcC8/kWvjQ1xR2Wo5t+dWhrzqkmCj++88XtI=; b=sXS9aLsJ6v9IRYznK/kx7AtyW9bQgGZWxgI7/RLqBFP9v4Zqt4dyy0ra1mSrgroZo2w6O8xltLkbavC9b9hwCNehalM9ng7G32bFquMneqjLP8VNj2qXv5LC/0mlMr6UDzh5XWD81wRctdUbUEK+QF7Quw0cMYSYtye/7cg9j9w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4917.namprd11.prod.outlook.com (2603:10b6:510:32::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 25 Nov 2021 12:47:03 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.030; Thu, 25 Nov 2021 12:47:03 +0000 Message-ID: <843154cd-4ed4-046e-e01c-3fb154ddad86@intel.com> Date: Thu, 25 Nov 2021 12:46:57 +0000 Content-Language: en-US To: Ori Kam , Slava Ovsiienko CC: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "David Marchand" , Andrew Rybchenko , "dev@dpdk.org" , Ray Kinsella References: <20211123075940.5521-1-viacheslavo@nvidia.com> <20211124153756.12198-1-viacheslavo@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB3PR08CA0016.eurprd08.prod.outlook.com (2603:10a6:8::29) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR08CA0016.eurprd08.prod.outlook.com (2603:10a6:8::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Thu, 25 Nov 2021 12:47:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 51092c47-3d03-434d-c82c-08d9b011adf6 X-MS-TrafficTypeDiagnostic: PH0PR11MB4917: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HHQal+rfs9w13vhHpKlJskCgTSPIdlN9EzQVJUOkZ2KnqLtmlmYhF5hnn2F1fGB2dhPwKO3zXMPDFsGr8oG5qr3XpP1sQSrjrbjsKbKcKOatMi2tuRHKDwkbwIjJI13r93wxUP4Td5UxfDn4Dk1405zyhT/OrHRugDMlB6hbf2kUwqS8tS3Qzp78dNthvxHizzFFnjJ6zosaKdx7VPxk/WNE8A6r4x1MWSiizLbPHOVPc9K5Mj0KDZ+ziM2K4Id2Gqp0Mb2Eg+kwxW+kjqWSJI5PVoeWfpImnVDVNHl1tPUOzyMTkuCn1cZijuXD7Xql4Y7qZWZfqInvF7fEtJEQfu4HFCvSymdH011SuwW1gihvCf6FTdElSeuZamFUinCf256spmXC6kORdr10s8Nafbj0f2g7W09jei66ga1cZ2jOQXHLkRCm8emqMVI/DYQ1ZPjvUiI1pEK6/Z9sEU/b2t4kTr36rFtKK6LlHxECe5S1mVHFJsl0vWVQDatzPePl/RR/u6h+10vcvLS4xGy85yBb7FrL5bicVLUIL2ynyTuU26mdroyZhuSu4osch01i/CjkZ7L/m9rD5PNOPC+Pgy9xtyffvmwqfFAAlYrh6E0U+KasYhAxG+2E+LvFMnwMkZ3zSKmbowoHb6/9+hvyiSQujSfFToDVZhJvYMqZxkRP9oK4Bd8ii14YTHjKlPoNYk9INb1mHltUXnLh1dvCKw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(38100700002)(31686004)(66556008)(2616005)(956004)(4326008)(54906003)(66476007)(6486002)(6666004)(86362001)(316002)(110136005)(16576012)(44832011)(36756003)(5660300002)(2906002)(8676002)(31696002)(53546011)(186003)(26005)(8936002)(508600001)(83380400001)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTAySWJCSEtoeHBiVGpRaEo2Mk9iWjAvdENCWmJBRUZtbFpwajlVQlhiZFNT?= =?utf-8?B?bi90SEtGQzUyMkdDMithVHFWVXdYaGhrb0JLN1ZYNXg5ZUkxa3p0SzhXaXpX?= =?utf-8?B?eFBOU0NFeEpLWENkV2pUZHNEU0dDRFlYMmNMU2VFZWFvVDRxTHNSK09RYTFS?= =?utf-8?B?bjVZVWgxQkRpdnlSWEMzRndFVVpSL1dOVHYrelBmeGl3b29NaWZYWWFEQXVn?= =?utf-8?B?N29NQy9seDJjL0Z2RHk2T0pldlNneGhjVXJHOWk2MmYvYW54QmlheFppVWRC?= =?utf-8?B?SUZCcGdhMmFjVW85L2tFL3p3S1d0NjJJd2p0amNOeDB3d2dBRVJFRGFUUE1X?= =?utf-8?B?Z2hObWh1cDQ2Wm0xVU8wYWlZRGNxLzVVRlJqUTZCNE12dWp0TGV3amlmaGdX?= =?utf-8?B?OVM5K20vWHo1d290RGEwS2RrVUlYZUpCMExiSE9mQm5tRXJEMG1WeSt0YmFv?= =?utf-8?B?aWtBZU4wL3N6aWR0eGdkVDZuWEdVVitUUFVrZ2N0Y1NoY2lBNDgzQzVlUTZh?= =?utf-8?B?YjdlTDJCM1pQL1BWeXUxd3E2OGo2K0t2K1d4SlpSRlhNVHM1b1JIY1FnVEJp?= =?utf-8?B?NXEvMmU3Z1Z4VU1HR1h2ckltT1dkM3k3MTVKMTJueStmTGVKc1hkT3hOcDI1?= =?utf-8?B?K01mZW9vbTNITnduczV2d1phQURjZ1NoRzJ4N3FHcDdLdWRVWjVuNUhhMWFL?= =?utf-8?B?Z21KbHZRMTlFOWx4RlZYaFBtS2JCU1pZOGd5ZzUvakVUcldZVWJXZU1TV3NF?= =?utf-8?B?WHZIcC9WcVBqTEQwYitheWNHcUd6eVdSRENFTTdQaTBpY3hjL25qblovZmU5?= =?utf-8?B?L3E0OTlvMUZOeGhEZUsweVlHNTRtMVdPRm9OUzdlem5DQ3JabHVKR3V5MnlL?= =?utf-8?B?a01XV01HQ1dYc2ZOaStuYkkrZk4vMHA5WGwvOTR6eFkzY3BzVmpEM3FUZExa?= =?utf-8?B?c2RYSFRDNVRaUEViVnhwYnNCV3Y0UDZDNDVubjRLV0pLbTVUdUZNUHRTeTV5?= =?utf-8?B?UTgrRUxYNGJ1VXdWdnpycDhLTjlNa1ZtN1FsKzZUTmFra3cvMENMN0hMamZF?= =?utf-8?B?L3Z0K1VhYk1ZUzI5cmdlYlY3Q21NejlPOFhMT2w1Z2pvUTJvZkFRWlB6eUQz?= =?utf-8?B?VjI5MjU3VlJwK2hqdElFWlVDQnVIZzUzbHc5dnFIaHlPVkZ3KzRwdElwQS91?= =?utf-8?B?c3g4L2htbGw5VWF6NW4yLy95eEdPT2M4ZmQyVjQ4ZlJHMEZseEtvRWM5NzBR?= =?utf-8?B?ZmpyTERMOGVVTk1RVVA4Q3A1dlVTUEg3cEpTNWNGZVVvbUlMbVhlR08vcllF?= =?utf-8?B?NkM0Z005amtEWnRVY3k0Y3cvT1BSTHVRWi93Mjh6bUVjNFJRZU1ITnVLeG1Y?= =?utf-8?B?Q2hNOCtHblhiUUtHNjNZSnoyQm1ITGo0U2ptUjVpQ1cxZlIxbXl6U2ZUZkRG?= =?utf-8?B?YjR4WUVIejhYTnFPMUtvdG5wQ0hwSHNndzBmdllyY1FOdXdCSWNKY2kxRFBJ?= =?utf-8?B?eE1RM1pvTlkxSkxYZlNVM2pJRHlDRngraDU3dWMyWVl0SFo5ZjFqcmJyQWo3?= =?utf-8?B?OWZjL21TQWZsV2tKcXA5NFBHNHFwVVpmN1o2bHJrekJnNU5ScWRnQ1dMdENT?= =?utf-8?B?RFRUY005WFJCRTE5L2ZhMEZNaHdlK0xmMFFSRVB3bkNYUm10V2dLTXY1TnFE?= =?utf-8?B?ZEIyNjhqY3IwUS95WFQraG41ZlJ0UlN2OFJyYlRJTjV0aldoQnpOdWY2Qldv?= =?utf-8?B?YjBpZFFDaThDTHR3MTI5d01hc1ljVGJRMEc3VVcrYWNsUmJGSjlmK0VYNUlS?= =?utf-8?B?VjhwN01MdmdQYmhnbG5WRWVTQllLVFlCU3pNdFFQUE5QbENYVzNXTld6S1U0?= =?utf-8?B?YktyMFRQVmYxVzVSaCs4YkJNOEdXT0lUWmxpYWo5RmVoQVlkS0haYjY0YVVG?= =?utf-8?B?aEpJcEhpTVIrY3pweVY3dVhIL3FsVFdiTnhlYitsbHp6NGNVcnZhVEtGN0U4?= =?utf-8?B?QXdhMTRITVNlNnhDdnZ6eFZMZXZTdmZWbVlLMDFvc2QxSlZZQnhDbHd2Qncv?= =?utf-8?B?aHI2N0R3cXgybFI0MXJtR3RjaitlSTM3UnJidlVneWJkY3NoU3RmVGsyVmhu?= =?utf-8?B?cjdsUVgyKzRFQlRmcGdvWmNJN2wvVkhaN0V6NXBJS2IxTGVha1lGdTZWMklJ?= =?utf-8?Q?xjHkb9tdPegGAKYCuEz+1Zk=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 51092c47-3d03-434d-c82c-08d9b011adf6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 12:47:03.1380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J46Y9dhBPnMRwl4FnvX6CLfzZoid3gGilLYg1s4+x/ggKCJfrSXWEJ52aOm7a2tZ6yJQEPenY6SbT3hVUnYoHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4917 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/25/2021 12:29 PM, Ori Kam wrote: > Hi > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, November 25, 2021 2:19 PM >> Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions >> >> On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: >>> @@ -3331,6 +3430,9 @@ struct rte_flow_action_set_tag { >>> }; >>> >>> /** >>> + * @deprecated >>> + * @see RTE_FLOW_ACTION_TYPE_MODIFY_FIELD >>> + * >>> * @warning >>> * @b EXPERIMENTAL: this structure may change without prior notice >>> * >>> @@ -3355,6 +3457,9 @@ struct rte_flow_action_set_meta { >>> }; >>> >>> /** >>> + * @deprecated >>> + * @see RTE_FLOW_ACTION_TYPE_MODIFY_FIELD >>> + * >>> * RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP >>> * RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP >>> * >> >> Hi Viacheslav, Ori, >> >> Just recognized that some of the "struct rte_flow_*" added as experimental >> (experimental note in the struct comment), some without experimental note. >> >> Is it because some forgotten the add the experimental note? >> >> What is the rule to add new "struct rte_flow_*"? >> > > In the beginning struct were never experimental, > and in the last few releases we started to put experimental also on structs > which I think is much better since at the end this is a new API and just like any other > new API it is not stable. > Got it, thanks. So to record for archives, new "struct rte_flow_*" structs should be experimental by default. Does it applies to enums too?