From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 431386A98 for ; Wed, 27 Aug 2014 16:31:39 +0200 (CEST) Received: by mail-wi0-f178.google.com with SMTP id hi2so535377wib.5 for ; Wed, 27 Aug 2014 07:35:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=waXkh/K+JEAYDQmG98yrV0yG4PxaV3j6C5SnJ1mYvYU=; b=DwSmt7/P3qXWgIQE1LFkXac7FdnD5SBkALt7FzpX/AX8I8P3k2AfcHvQQsZhC9KV9p 39cPUgQX7QY1QC/brH4nWHkLDZ+79L3BK1XB3CVf1jiaQWqHs0CZiVX4YzrSzIqeDYTR fcKmF9EB885cDAfms4YnBp+MIksZ58eUzvmWOxNsRSiEimZeLjlek/bY3NUJl6DIowaq jyBgIjSHgC7ekByQ9XdVeqnUKL/mSCZVKYEKxS+k0SGRXg/RQOXC6dRj2uiC34BwnUey wUKNNx+sCs9we7wJoUtC0mSOXuOutlpIO2fzr6WzE385hNS75mcAxUyF8jMkOdeoNZtn zwbA== X-Gm-Message-State: ALoCoQlrbOj8juRqbiLACPFa6cQyT/lzFnCB1VhaiyuPPGGwP+5ipIm/wcofyQn+0/ToM52NdZLt X-Received: by 10.194.179.73 with SMTP id de9mr23618787wjc.87.1409150142556; Wed, 27 Aug 2014 07:35:42 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id bt9sm1474044wjc.44.2014.08.27.07.35.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Aug 2014 07:35:41 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Date: Wed, 27 Aug 2014 16:35:37 +0200 Message-ID: <8438692.KHYKcsiDRz@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1409105634-29980-8-git-send-email-jingjing.wu@intel.com> References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com> <1409105634-29980-8-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 14:31:39 -0000 Hi Jingjing, 2014-08-27 10:13, Jingjing Wu: > add structure definition to construct programming packet. What is a "programming packet"? > +#ifdef RTE_LIBRTE_I40E_PMD > + "i40e_flow_director_filter (port_id) (add|del)" > + " flow (ip4|ip6) src (src_ip_address) dst (dst_ip_address)" > + " flexwords (flexwords_value) (drop|fwd)" > + " queue (queue_id) fd_id (fd_id_value)\n" > + " Add/Del a IP type flow director filter for i40e NIC.\n\n" > + > + "i40e_flow_director_filter (port_id) (add|del)" > + " flow (udp4|tcp4|udp6|tcp6)" > + " src (src_ip_address) (src_port)" > + " dst (dst_ip_address) (dst_port)" > + " flexwords (flexwords_value) (drop|fwd)" > + " queue (queue_id) fd_id (fd_id_value)\n" > + " Add/Del a UDP/TCP type flow director filter for i40e NIC.\n\n" > + > + "i40e_flush_flow_diretor (port_id)\n" > + " Flush all flow director entries of a device on i40e NIC.\n\n" > +#endif /* RTE_LIBRTE_I40E_PMD */ I'd really like to stop seeing this kind of thing. We cannot add some ifdef for each PMD in generic code. I stopped reading after that. Sorry, I don't want to be rude but my feeling is that adding such feature with global picture in mind is not easy. I know you want to offer all i40e capabilities but you should think at future evolutions and how other drivers will be integrated with yours. Thanks -- Thomas