From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection
Date: Wed, 19 Dec 2018 23:59:35 +0100 [thread overview]
Message-ID: <8444963.9kjRHCCdve@xps> (raw)
In-Reply-To: <CAJFAV8xt5LqgWoetPSwuzV3txTkYEh5FWCQxqnFFU=8R8-TBrw@mail.gmail.com>
17/12/2018 11:19, David Marchand:
> On Mon, Dec 17, 2018 at 10:26 AM Gaetan Rivet <gaetan.rivet@6wind.com>
> wrote:
>
> > Missing brackets around the if means that the loop will end at its first
> > iteration.
> >
> > Cc: stable@dpdk.org
> >
> > Fixes: 2395332798d0 ("eal: add option register infrastructure")
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> > rte_option_register(struct rte_option *opt)
> > {
> > TAILQ_FOREACH(option, &rte_option_list, next) {
> > - if (strcmp(opt->opt_str, option->opt_str) == 0)
> > + if (strcmp(opt->opt_str, option->opt_str) == 0) {
> > RTE_LOG(INFO, EAL, "Option %s has already been
> > registered.",
> > opt->opt_str);
> > return;
> > + }
> > }
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks
> Different topic but having a return code would be better than a simple log.
+1
prev parent reply other threads:[~2018-12-19 22:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 9:25 Gaetan Rivet
2018-12-17 9:35 ` Burakov, Anatoly
2018-12-18 10:26 ` [dpdk-dev] [PATCH] mk: use misleading indentation warning when available Gaetan Rivet
2018-12-18 14:50 ` Ferruh Yigit
2018-12-19 9:24 ` Gaëtan Rivet
2018-12-19 10:05 ` Burakov, Anatoly
2018-12-17 10:19 ` [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection David Marchand
2018-12-19 22:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8444963.9kjRHCCdve@xps \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).