From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BAD8A10BD; Wed, 19 Dec 2018 23:59:38 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C72C721B62; Wed, 19 Dec 2018 17:59:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 19 Dec 2018 17:59:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=uAj6B4g+ofrVdWhcq7/QHmjTTe496gVm+6+PVtCsLDM=; b=IQS9ZO1WET48 IvUhxHONw6v8a+uYr+rx9xkRn0b3YiFwUA/rgFyj4bOlCt9iJjIcyTKo3AtrPcHF gYHbiNwb+Ah7gSr9IvHbImJqNCNMItX5w52rtut+xmbbOhnaYcNenQhgw2YFxmdU mhw8bFpqiHrn6oRJDZJWrViRvD2MDpA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=uAj6B4g+ofrVdWhcq7/QHmjTTe496gVm+6+PVtCsL DM=; b=xgVDiiPNRv4yFBn+/K7SaEB6cPGe2NfZex5BCOml/eiEXraH7tkpNFq1p bIIbEE7eNQCM3S+VJvZfTL2fitlNBV28xyM81aK+wJ1qQNs0p66strunla4Bo3ik V0rRc7CKULRrV9756AQNDw0BsmF/YHUmJnDXc7UXjukNtAvTtYz0qPEo1GauB3Mk Web86pyFUSobYe4kjCIALHCyel8SZwt9ZT+kLC8dbWmg6U23DosGME0J1u3vlmMN j5QeYZw6V1FkC9viVg3heM1Vil8YMJ5nYrNXlpeWV5Mj4SRchrla2ty/UWTXOjzH ixrr/SHWrFwNUpmX+FQhBDcCD3Xow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejuddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A959EE4445; Wed, 19 Dec 2018 17:59:36 -0500 (EST) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org, David Marchand , stable@dpdk.org Date: Wed, 19 Dec 2018 23:59:35 +0100 Message-ID: <8444963.9kjRHCCdve@xps> In-Reply-To: References: <20181217092559.21801-1-gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 22:59:39 -0000 17/12/2018 11:19, David Marchand: > On Mon, Dec 17, 2018 at 10:26 AM Gaetan Rivet > wrote: > > > Missing brackets around the if means that the loop will end at its first > > iteration. > > > > Cc: stable@dpdk.org > > > > Fixes: 2395332798d0 ("eal: add option register infrastructure") > > Signed-off-by: Gaetan Rivet > > --- > > rte_option_register(struct rte_option *opt) > > { > > TAILQ_FOREACH(option, &rte_option_list, next) { > > - if (strcmp(opt->opt_str, option->opt_str) == 0) > > + if (strcmp(opt->opt_str, option->opt_str) == 0) { > > RTE_LOG(INFO, EAL, "Option %s has already been > > registered.", > > opt->opt_str); > > return; > > + } > > } > > Reviewed-by: David Marchand Applied, thanks > Different topic but having a return code would be better than a simple log. +1