From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C77FA0C4D; Mon, 6 Sep 2021 03:56:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E57C940E32; Mon, 6 Sep 2021 03:56:39 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 634A040C35 for ; Mon, 6 Sep 2021 03:56:38 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="217994416" X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="217994416" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:56:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="579468739" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 05 Sep 2021 18:56:37 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 5 Sep 2021 18:56:36 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 6 Sep 2021 09:56:29 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Mon, 6 Sep 2021 09:56:29 +0800 From: "Zhang, Qi Z" To: Qiming Chen , "dev@dpdk.org" CC: "Xing, Beilei" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset Thread-Index: AQHXl9GiUKFK3m0bv0+TezPfjN+ig6uWVQkw Date: Mon, 6 Sep 2021 01:56:29 +0000 Message-ID: <844c807a3c9e48a0ba3eec4303d30905@intel.com> References: <20210823034623.7467-1-chenqiming_huawei@163.com> In-Reply-To: <20210823034623.7467-1-chenqiming_huawei@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Qiming Chen > Sent: Monday, August 23, 2021 11:46 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > > Subject: [dpdk-dev] [PATCH] net/i40e: extend the polling times of vf rese= t >=20 > In the embedded RTOS environment, the x722 controller Ethernet card of th= e > d2146nt chip, the vfio user mode driver takes over 8 vf ports in turn, bu= t > i40evf_check_vf_reset_done will probably fail. >=20 > This issue has been discussed with intel&dpdk experts for 3 rounds before= , and > the version matching is no problem, and there is no substantial progress.= The > official website contacted external experts, but there was no response > afterwards. Learning from the implementation of the i40evf kernel driver = locally, > after modifying the polling time from 1 second to 5s, the repeated restar= t > process took over the start port test, and it was found that this probabi= lity was > reduced to an order of magnitude acceptable to the user. >=20 > The patch cannot fundamentally solve the failure problem, but it greatly = slows > down the probability of the problem. The modification is based on the i40= evf > kernel driver. >=20 > Signed-off-by: Qiming Chen > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index f64db72e9a..924da8dfb4 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -42,7 +42,7 @@ > /* busy wait delay in msec */ > #define I40EVF_BUSY_WAIT_DELAY 10 > #define I40EVF_BUSY_WAIT_COUNT 50 > -#define MAX_RESET_WAIT_CNT 20 > +#define MAX_RESET_WAIT_CNT 100 >=20 > #define I40EVF_ALARM_INTERVAL 50000 /* us */ >=20 > -- > 2.30.1.windows.1 The patch is not applied for main repo as i40evf will be removed, you can s= ubmit a fix to dpdk-stable directly.