DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Habibi, Michael" <michael.f.habibi@hp.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] irq_to_desc undefined when compiling igb_uio
Date: Tue, 26 Aug 2014 21:43:15 +0000	[thread overview]
Message-ID: <845ED019F5932D4E8BED0A693FDBF6E72442E9B8@G4W3304.americas.hpqcorp.net> (raw)
In-Reply-To: <20140826213253.GC6818@drone.musicnaut.iki.fi>

I agree the kernel is old but it's what we're stuck with at the moment. It
appears that at least some thought went into this, as the code in question
is actually compatibility code added for older kernel versions such as mine:

#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 37)
/* Compatability wrapper for new kernel API for IRQ */
#define irq_data irq_desc
#define irq_get_irq_data(irq) irq_to_desc(irq)
#define irq_data_get_msi(data) get_irq_desc_msi(data)
#endif

I may just export the symbol for now. Unfortunately I'm not familiar enough
with this area of the code, but if I end up tackling this I'll see if I can
submit a patch if it hasn't been fixed by then.

Thanks.

P.S. Aaro sorry for the duplicate email. I resent this without my digital signature so it would get through the mailing list.

-----Original Message-----
From: Aaro Koskinen [mailto:aaro.koskinen@iki.fi]
Sent: Tuesday, August 26, 2014 4:33 PM
To: Habibi, Michael
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] irq_to_desc undefined when compiling igb_uio

Hi,

On Tue, Aug 26, 2014 at 08:55:29PM +0000, Habibi, Michael wrote:
> I have verified in our kernel source, as well as the public source for
> 2.6.34, that irq_to_desc is not an exported function.
> However the documentation states that the minimum version required is
> only 2.6.33. Did I setup my environment or build my kernel incorrectly?

It's probably just that nobody has ever bothered to test latest DPDK with your kernel version before. Note that Linux 2.6.34 is EOL and you should upgrade your kernel anyway.

A.

  reply	other threads:[~2014-08-26 21:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 20:55 Habibi, Michael
2014-08-26 21:32 ` Aaro Koskinen
2014-08-26 21:43   ` Habibi, Michael [this message]
2014-08-26 22:32     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=845ED019F5932D4E8BED0A693FDBF6E72442E9B8@G4W3304.americas.hpqcorp.net \
    --to=michael.f.habibi@hp.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).