From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 528101B664 for ; Tue, 3 Apr 2018 12:24:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CC9A120B1C; Tue, 3 Apr 2018 06:24:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 03 Apr 2018 06:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=BLImSl0i+LAYbNldXiBZdzS8RC 47AlNusD+Qkb6xOFI=; b=BeQzA9CzSnlUm2CiHxPR5hn+4rltp8s2UTd1hkXrB5 NF1b9x2PVIeTKxisyj3DFUG+UDxUr6j/s4o4LSzZUqZe19Qn8mXiUT1tDwpRomo5 Zy44pXD23zh/twxM5dbbeRQcXOMHoPHTFcddHgow3RtibuG0JKDrfW/7LUJflvEr 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=BLImSl 0i+LAYbNldXiBZdzS8RC47AlNusD+Qkb6xOFI=; b=mPVU/+dFxEc5Gz5GvVeiIc 0Twmxffy1faGpb56c1ckZzREoWcA5vBP23UsXFQRa9A6Ev/+3MEseHBY22GGBSmi 9bRM3tjL84yyuenWo/LSAWuFYkr47+GuFmvmT4TnwCFiOs1EgCC3QaEauJTRVQ13 9VA+Pxv9Voub7Hu4gH5UA4hpcT9UYJM4Q4LBJ08k+jp9Rg9ztVn/jBBjxZ3H66+X QPzNT1VAPVMIPjiB6nETeHeCIWwY1m1pCpTvpuooJNtstvf3w+jhERhVJIxWUzWm PrkmFM2M7Y+CoOJU8ui7zF+1X8gmqA98Jf68/Fq2/sKuvOKaB/x2fl4CgqJkRcLQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1DB30E4408; Tue, 3 Apr 2018 06:24:44 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: John McNamara , Marko Kovacevic , dev@dpdk.org, Bruce Richardson Date: Tue, 03 Apr 2018 12:24:15 +0200 Message-ID: <8464158.iTavIsMWKz@xps> In-Reply-To: <20180403092859.71589-1-ferruh.yigit@intel.com> References: <20180403092859.71589-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 10:24:45 -0000 03/04/2018 11:28, Ferruh Yigit: > Library folder name and output library name are same except a few flaws > including librte_ether. > > This library is network device abstraction layer, the name "ethdev" fits > better than "ether", and library & header files already named as ethdev. > > Also there is a rte_ether.h in the net library which can cause confusion. > > Signed-off-by: Ferruh Yigit > --- > Not sure if the we are ready for this change J > > This is one the issues that the hassle of the change doesn't worth the > benefit and you may prefer to live with the flaw. > > Also a concern is this breaks the git history. Yes it breaks the git history. I am a big user of gitk. Do you know how to follow the history after rename with gitk? I think it is a good change but I would like to be sure it will not bother us every day.