From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9744A0547; Wed, 21 Apr 2021 16:20:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3052441B25; Wed, 21 Apr 2021 16:20:06 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 72D4441B1F; Wed, 21 Apr 2021 16:20:05 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 07DB67F528; Wed, 21 Apr 2021 17:20:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 07DB67F528 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1619014805; bh=ZWb0PIFujopxBdc1D2s9XAdX58f23DsXEVF00YDBrOc=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=bBFu5ePtBKkRn+2MULf03L+bPADOEnFp2wDUelFi83kbsHTGajrnO4fKW8C7yDpvv 0HCxcF3RtiSYOwKxtOAQWamamzQpmlFfzbl4Xzj++xwmLRBjP0kvepYwDa41laCf38 IoMuwzWKSbAWzS3Vk4g0oFYltk1mScZkASyla8Ak= To: =?UTF-8?Q?Juraj_Linke=c5=a1?= , Ruifeng Wang , "thomas@monjalon.net" , "david.marchand@redhat.com" , "bruce.richardson@intel.com" , "aconole@redhat.com" , "maicolgabriel@hotmail.com" Cc: "dev@dpdk.org" , "arybchenko@solarflare.com" , "stable@dpdk.org" , nd References: <1615988163-17371-1-git-send-email-juraj.linkes@pantheon.tech> <1618995020-4775-1-git-send-email-juraj.linkes@pantheon.tech> <1618995020-4775-2-git-send-email-juraj.linkes@pantheon.tech> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <847c00bd-d210-c5c6-c8bc-3232f7e17f8b@oktetlabs.ru> Date: Wed, 21 Apr 2021 17:20:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/21/21 5:08 PM, Juraj Linkeš wrote: > > >> -----Original Message----- >> From: Ruifeng Wang >> Sent: Wednesday, April 21, 2021 12:06 PM >> To: Andrew Rybchenko ; Juraj Linkeš >> ; thomas@monjalon.net; >> david.marchand@redhat.com; bruce.richardson@intel.com; >> aconole@redhat.com; maicolgabriel@hotmail.com >> Cc: dev@dpdk.org; arybchenko@solarflare.com; stable@dpdk.org; nd >> >> Subject: RE: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build >> >>> -----Original Message----- >>> From: Andrew Rybchenko >>> Sent: Wednesday, April 21, 2021 5:05 PM >>> To: Juraj Linkeš ; thomas@monjalon.net; >>> david.marchand@redhat.com; bruce.richardson@intel.com; >>> aconole@redhat.com; maicolgabriel@hotmail.com >>> Cc: dev@dpdk.org; Ruifeng Wang ; >>> arybchenko@solarflare.com; stable@dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build >>> >>> On 4/21/21 11:50 AM, Juraj Linkeš wrote: >>>> From: Ruifeng Wang >>>> >>>> The sfc PMD was enabled for aarch32 which is 32-bit mode but has >>>> cpu_family set to aarch64. >>>> As sfc support only 64-bit system, it should be disabled for aarch32. >>>> >>>> Updated meson file to disable sfc for aarch32 build. >>>> >>>> Fixes: 141d2870675a ("net/sfc: support aarch64 architecture") >>>> Cc: arybchenko@solarflare.com >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Ruifeng Wang >>>> Acked-by: Andrew Rybchenko >>> >>> Withdraw my ack >>> >>>> --- >>>> drivers/common/sfc_efx/meson.build | 2 +- >>>> drivers/net/sfc/meson.build | 2 +- >>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/common/sfc_efx/meson.build >>>> b/drivers/common/sfc_efx/meson.build >>>> index 1ca9510733..db5a6a8b42 100644 >>>> --- a/drivers/common/sfc_efx/meson.build >>>> +++ b/drivers/common/sfc_efx/meson.build >>>> @@ -10,7 +10,7 @@ if is_windows >>>> reason = 'not supported on Windows' >>>> endif >>>> >>>> -if (arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')) and >>>> (arch_subdir != 'arm' or not >>>> host_machine.cpu_family().startswith('aarch64')) >>>> +if (arch_subdir != 'x86' or arch_subdir != 'arm') and (not >>>> +dpdk_conf.get('RTE_ARCH_64')) >>> >>> Am I missing something or condition in parenthesis is always true? I >>> think it >> > > Thanks for catching this. > >> Oops, it should be an 'and' in the parenthesis. >> >>> should be: >>> >>> if arch_subdir != 'x86' or arch_subdir != 'arm' or not >>> dpdk_conf.get('RTE_ARCH_64') >> >> I assume you meant to use 'and's. >> > > I believe the actual correct condition is: > (arch_subdir != 'x86' and arch_subdir != 'arm') or (not dpdk_conf.get('RTE_ARCH_64')) > > This should result in 'only supported on x86_64 and aarch64'. Yes, many thanks. Andrew. > >>> >>>> build = false >>>> reason = 'only supported on x86_64 and aarch64' >>>> endif >>>> diff --git a/drivers/net/sfc/meson.build >>>> b/drivers/net/sfc/meson.build index 0c5cfb9058..0a96235e33 100644 >>>> --- a/drivers/net/sfc/meson.build >>>> +++ b/drivers/net/sfc/meson.build >>>> @@ -12,7 +12,7 @@ if is_windows >>>> subdir_done() >>>> endif >>>> >>>> -if (arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')) and >>>> (arch_subdir != 'arm' or not >>>> host_machine.cpu_family().startswith('aarch64')) >>>> +if (arch_subdir != 'x86' or arch_subdir != 'arm') and (not >>>> +dpdk_conf.get('RTE_ARCH_64')) >>> >>> same here. >>> >>>> build = false >>>> reason = 'only supported on x86_64 and aarch64' >>>> endif >>>> >