From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C2D16A3 for ; Sun, 24 Mar 2019 23:59:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5D51420C9A; Sun, 24 Mar 2019 18:59:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 24 Mar 2019 18:59:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3j9kXDNTk+n6aJPMXp4uX61lLWi0b7mXtKsQhYBWxjU=; b=XT0NnI9alKm8 aWMzbHyxi3mpQATbmlDDjmG7bbrPfapWN3Ofk9jvpMvgKUEfNZAsmcXFv+qb2Xq3 +hFzV3WfBhR2p+belxhbX9qMD8C0dtcKcdobwIcVdlBTTx9ivqwIL4oplWpfYOf1 u1LZVRlsM6/gKaiVZ2Uy7AgY2IFoV3A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3j9kXDNTk+n6aJPMXp4uX61lLWi0b7mXtKsQhYBWx jU=; b=wim7usD75RP/Ct9DjN58PhvFBKg38fln6mh8gi66bS7kLCl4qvMkcfpH6 pZFZAay5AGVLMBGWIyCWJmrGATwk4n7i1/42iZnZA7Tx+KXH1c8uJsJrOrhBclX1 EyvY8HimYbdVBur4LKhKSpOmP/9YhWIc4NLKlxU0wpNF5f4uAGWD/6ZEv+L6zHnA Y+IAamIUvHryvkHJqBB2b5Qhuxt11JERd+6TOAHBB5qO30J4OEDaTo98JSbpCLIl sDnLZOyYw06wMjCTjATUSs8FTQVTUkXNA1kuHqr7i+DEUnJyg3A9ZmLUkfcMsEGE EAz5SiS71AA4d2A+Q1pQkzjtA/mUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrjeeigdduieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 452CDE456D; Sun, 24 Mar 2019 18:59:24 -0400 (EDT) From: Thomas Monjalon To: Andrius Sirvys Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Sun, 24 Mar 2019 23:59:22 +0100 Message-ID: <8490098.mdA5AMzK3V@xps> In-Reply-To: <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com> References: <1551952591-102518-1-git-send-email-andrius.sirvys@intel.com> <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] build: move variable definition to top level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Mar 2019 22:59:26 -0000 07/03/2019 12:28, Andrius Sirvys: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/meson.build file > will make it easier for compiling separate directories. > > In the process, we rename driver_classes to dpdk_driver_classes for > consistency with the other variables. > > Signed-off-by: Andrius Sirvys > Acked-by: Bruce Richardson > --- > v4: Removed unreleated files that were accidentally included > --- > drivers/meson.build | 4 ++-- > meson.build | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) Please, could you rebase on top of latest changes in master? Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AE1E7A05D3 for ; Sun, 24 Mar 2019 23:59:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40AF2137D; Sun, 24 Mar 2019 23:59:27 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C2D16A3 for ; Sun, 24 Mar 2019 23:59:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5D51420C9A; Sun, 24 Mar 2019 18:59:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 24 Mar 2019 18:59:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3j9kXDNTk+n6aJPMXp4uX61lLWi0b7mXtKsQhYBWxjU=; b=XT0NnI9alKm8 aWMzbHyxi3mpQATbmlDDjmG7bbrPfapWN3Ofk9jvpMvgKUEfNZAsmcXFv+qb2Xq3 +hFzV3WfBhR2p+belxhbX9qMD8C0dtcKcdobwIcVdlBTTx9ivqwIL4oplWpfYOf1 u1LZVRlsM6/gKaiVZ2Uy7AgY2IFoV3A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3j9kXDNTk+n6aJPMXp4uX61lLWi0b7mXtKsQhYBWx jU=; b=wim7usD75RP/Ct9DjN58PhvFBKg38fln6mh8gi66bS7kLCl4qvMkcfpH6 pZFZAay5AGVLMBGWIyCWJmrGATwk4n7i1/42iZnZA7Tx+KXH1c8uJsJrOrhBclX1 EyvY8HimYbdVBur4LKhKSpOmP/9YhWIc4NLKlxU0wpNF5f4uAGWD/6ZEv+L6zHnA Y+IAamIUvHryvkHJqBB2b5Qhuxt11JERd+6TOAHBB5qO30J4OEDaTo98JSbpCLIl sDnLZOyYw06wMjCTjATUSs8FTQVTUkXNA1kuHqr7i+DEUnJyg3A9ZmLUkfcMsEGE EAz5SiS71AA4d2A+Q1pQkzjtA/mUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrjeeigdduieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 452CDE456D; Sun, 24 Mar 2019 18:59:24 -0400 (EDT) From: Thomas Monjalon To: Andrius Sirvys Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Sun, 24 Mar 2019 23:59:22 +0100 Message-ID: <8490098.mdA5AMzK3V@xps> In-Reply-To: <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com> References: <1551952591-102518-1-git-send-email-andrius.sirvys@intel.com> <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] build: move variable definition to top level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190324225922.SIuYUei2eqW37EefSOhBlOhxYTflKeAPND1TXjOto3k@z> 07/03/2019 12:28, Andrius Sirvys: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/meson.build file > will make it easier for compiling separate directories. > > In the process, we rename driver_classes to dpdk_driver_classes for > consistency with the other variables. > > Signed-off-by: Andrius Sirvys > Acked-by: Bruce Richardson > --- > v4: Removed unreleated files that were accidentally included > --- > drivers/meson.build | 4 ++-- > meson.build | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) Please, could you rebase on top of latest changes in master? Thanks