Re: [dpdk-dev] [PATCH v3] net/ixgbe: include QPRDC in imissed stat

["Harris, Cody" <codh@amazon.com>]

Sorry about all the revisions, I hit some style issues I didn't know about.

Be nice, it's my first time contributing anything :)

-Cody

On 5/18/20, 10:08 PM, "Cody Harris" <codh@amazon.com> wrote:

    The ixgbe imissed statstic originally only contained dropped packets
    counted by the RXMPC registers. This change includes additional types of
    packet drops counted by the QPRDC registers.
    
    Intel support confimed that the packet drops counted by the QPRDC registers
    do not double-count drops counted by RXMPC registers:
    
    "RXMPC counts packets that are dropped because there is no room in the
    internal packet buffer.  QPRDC counts packets that are dropped because they
    can't be transferred to system memory. These packets have been stored in
    the internal packet buffer, so there should be no overlap with RXMPC."
    
    Signed-off-by: Cody Harris <codh@amazon.com>
    ---
     drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
    index a4e5c539d..7284ca28e 100644
    --- a/drivers/net/ixgbe/ixgbe_ethdev.c
    +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
    @@ -3366,7 +3366,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
     	}
     
     	/* Rx Errors */
    -	stats->imissed  = total_missed_rx;
    +	stats->imissed  = total_missed_rx + total_qprdc;
     	stats->ierrors  = hw_stats->crcerrs +
     			  hw_stats->mspdc +
     			  hw_stats->rlec +
    -- 
    2.24.1.AMZN