From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86CFAA00C4; Fri, 1 Jul 2022 16:00:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7082040A7B; Fri, 1 Jul 2022 16:00:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A7D640156 for ; Fri, 1 Jul 2022 16:00:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656684033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gqo48MVcyxNcbJXUXh1Zarya0FBUcNKQdTuMEvGev3c=; b=jLRcWofQR1XV5MCor4GR3mgocQApJeUmlS2PGKFiLUmZQIpKaLoDgjM+ZFGzfd63nAUfvs dDKAogowgYyF5rj9auxg4AbR2U9YOUjVhN5nJBvlPhw52s3wwaWeSlPpY6kJdbXi8SoBjq XeTV0bhmKqPo/3G1pt8NS/RLa1cmtNs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-414-Udbj2_dsN5GmdmFHliOAtg-1; Fri, 01 Jul 2022 10:00:30 -0400 X-MC-Unique: Udbj2_dsN5GmdmFHliOAtg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 87B53811E76; Fri, 1 Jul 2022 14:00:30 +0000 (UTC) Received: from [10.39.208.30] (unknown [10.39.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 169D1492CA3; Fri, 1 Jul 2022 14:00:28 +0000 (UTC) Message-ID: <84a0943c-de96-d56e-ab53-1f9fb9f3a4ff@redhat.com> Date: Fri, 1 Jul 2022 16:00:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3] vhost: prefix logs with context To: David Marchand Cc: dev@dpdk.org, chenbo.xia@intel.com References: <20220701075511.2176198-5-david.marchand@redhat.com> <20220701132056.2244694-1-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220701132056.2244694-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/1/22 15:20, David Marchand wrote: > We recently improved the log messages in the vhost library, adding some > context that helps filtering for a given vhost-user device. > However, some parts of the code were missed, and some later code changes > broke this new convention (fixes were sent previous to this patch). > > Change the VHOST_LOG_CONFIG/DATA helpers and always ask for a string > used as context. This should help limit regressions on this topic. > > Most of the time, the context is the vhost-user device socket path. > For the rest when a vhost-user device can not be related, generic > names were chosen: > - "dma", for vhost-user async DMA operations, > - "device", for vhost-user device creation and lookup, > - "thread", for threads management, > > Signed-off-by: David Marchand > Reviewed-by: Maxime Coquelin > --- > Changes since v2: > - rebased on next-virtio, > > Changes since v1: > - preserved original format for logs (removing extra ':'), > > --- > lib/vhost/iotlb.c | 30 +- > lib/vhost/socket.c | 129 ++++----- > lib/vhost/vdpa.c | 4 +- > lib/vhost/vhost.c | 146 +++++----- > lib/vhost/vhost.h | 20 +- > lib/vhost/vhost_user.c | 644 +++++++++++++++++++++-------------------- > lib/vhost/virtio_net.c | 258 +++++++++-------- > 7 files changed, 636 insertions(+), 595 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime