From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 09E8AFB8A for ; Tue, 20 Dec 2016 14:44:34 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 20 Dec 2016 05:44:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,378,1477983600"; d="scan'208";a="914398377" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 20 Dec 2016 05:44:30 -0800 To: Alejandro Lucero , dev@dpdk.org References: <1482240120-28274-1-git-send-email-alejandro.lucero@netronome.com> From: Ferruh Yigit Message-ID: <84d1611c-a35c-c011-f9f5-625acda82645@intel.com> Date: Tue, 20 Dec 2016 13:44:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1482240120-28274-1-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6] nfp: report link speed using hardware info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 13:44:35 -0000 On 12/20/2016 1:22 PM, Alejandro Lucero wrote: > Previous reported speed was hardcoded because there was not firmware > support for getting this information. This change needs also to support > old firmware versions, but instead of the previous hardcoded report, no > speed is reported to the user avoiding to give the wrong speed when link > is not configured to 40G. > > v6: avoid to report speed with old firmware > v5: Fix missing parenthesis > v4: Make conditional simple and more ellaborated commit comment. > v3: remove unsed macro > v2: use RTE_DIM instead of own macro > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks. (replaced v5)