From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89CD2A0C49; Thu, 8 Jul 2021 10:27:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7401441599; Thu, 8 Jul 2021 10:27:54 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D0CDA40687; Thu, 8 Jul 2021 10:27:51 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10038"; a="270581288" X-IronPort-AV: E=Sophos;i="5.84,222,1620716400"; d="scan'208";a="270581288" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 01:27:50 -0700 X-IronPort-AV: E=Sophos;i="5.84,222,1620716400"; d="scan'208";a="498348057" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.3.227]) ([10.252.3.227]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 01:27:49 -0700 To: Richael Zhuang , dev@dpdk.org Cc: yux.jiang@intel.com, stable@dpdk.org References: <20210625020206.42284-2-richael.zhuang@arm.com> <20210708023447.20495-1-richael.zhuang@arm.com> <20210708023447.20495-3-richael.zhuang@arm.com> From: David Hunt Message-ID: <84d630db-5697-1a6e-edb4-34f2c43610b0@intel.com> Date: Thu, 8 Jul 2021 09:27:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210708023447.20495-3-richael.zhuang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v6 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/7/2021 3:34 AM, Richael Zhuang wrote: > On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not > be exactly the same as what was set when using CPPC cpufreq driver. > For other cpufreq driver, no need to round it currently, or else > this check will fail with turbo enabled. For example, with acpi_cpufreq, > cpuinfo_cur_freq can be 2401000 which is equal to freqs[0].It should > not be rounded to 2400000. > > Fixes: 606a234c6d360 ("test/power: round CPU frequency to check") > Cc: richael.zhuang@arm.com > Cc: stable@dpdk.org > > Signed-off-by: Richael Zhuang > --- > app/test/test_power_cpufreq.c | 23 ++++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) > Acked-by: David Hunt