From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20A32459FD; Sun, 22 Sep 2024 18:11:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4A0240274; Sun, 22 Sep 2024 18:11:02 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2087.outbound.protection.outlook.com [40.107.92.87]) by mails.dpdk.org (Postfix) with ESMTP id 8177B4025F for ; Sun, 22 Sep 2024 18:11:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TurblblYQ57/c7X+UxZdZUC0/TU1GdvrDghQ3N1hSOpdpE51BP+4QPaNfoLaa/m8kXe0nWv99RRExiFpdTHaiZuMNfR8NS3WgG9/ZwQrik7ik2WiTeEmvBMY5mDpzCEPQtN/8bM99nUit1UgQuOhL40ui2FI5YeWoheT+/pI8cp+MO8habUq8+jDtDuif30iRUK61N3g2VtNBzF+kVz5hlVBLIt2Xup2NZeBQqFbiwmBFdeWPLxmiLa/ZH/wBSqRaF0xlvoNTjGf7X67sB/W1qhHa6EH+u+UWJPJZcypkJ8HvG0aNnMHtI4AtuhWTnhpnQsqg8RdMVPYIuJSKLTm7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LE3bZu6SpyRLgPQdyygfevvgh8MQdRo0am7aN6msCAk=; b=BbG0bhcYWwEd4ro7ygqKl/RBwgqaDYJKxlRPzYk2tvRJEdtMU8gz3CMWCKnbDxaUhJO00sGn51KQLHZa90U8oLcOt7SLtUqDiYoOKd2LifsPiY1R5oPjXYYbFpgrulvMKsUpg3JDfpbJTucEuhHvqcAfCFEF9+MJQwHumB4yukzWppcBVp3/26AX5OwsI3aEdSgrGixisLY7QYYlNd+QZefHoiYxIlyne6J0+U5cGiDpFFf9dgugb2unr/Z5N6mvQT7525AUI9nrBxK56xZPWSS611h6o5Tm6JETFc+5o+Ktq+8s6ZvdXKd/p3PMj/0sSVmOgpRUVoOWMZm0S8qefQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LE3bZu6SpyRLgPQdyygfevvgh8MQdRo0am7aN6msCAk=; b=gEbdEiYptUqTvMsagpxiPNXQ/rdUm9Vy00q6Fv/SNrZEDwIVfWzUUqrVcyVUCByj4y7euh6wrexUaRAWz72AU1HlO+T1wa1vRmGxdUR/nh6O+kG2G0SJLP+nke9y9Lm7shORGGIU2aSPYmJ1ysztvSvPiUnC/fqH6GIYhH761vM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SA1PR12MB6917.namprd12.prod.outlook.com (2603:10b6:806:24c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.24; Sun, 22 Sep 2024 16:10:58 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.7982.022; Sun, 22 Sep 2024 16:10:58 +0000 Message-ID: <850ee1df-012f-4ecd-a81d-3513a0f147ef@amd.com> Date: Sun, 22 Sep 2024 17:10:49 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] ethdev: make parameters to TM node add fn constant To: "Xu, Rosen" , "Richardson, Bruce" , "dev@dpdk.org" Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra , Hemant Agrawal , Sachin Saxena , Jie Hai , Yisen Zhuang , "Wu, Jingjing" , Jiawen Wu , Jian Wang , "Dumitrescu, Cristian" , Thomas Monjalon , Andrew Rybchenko References: <20240806152417.3649745-1-bruce.richardson@intel.com> <20240806152417.3649745-2-bruce.richardson@intel.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0643.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::10) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SA1PR12MB6917:EE_ X-MS-Office365-Filtering-Correlation-Id: 549b4fff-f317-4f0a-91d7-08dcdb212504 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eDVyS2Vzb0FVZmdWSWlMcUpPT3hjWVpaRlhnWjFMemE1cmJHQ0tsN09SQnY2?= =?utf-8?B?bFp0QXhvUmRCTUJWQkU5RXliUFV6cWY4a1ZkSEtwZ0dUZG1IVSs0Z3JwVnhD?= =?utf-8?B?VHh0NHhTTWFCUk4yODR5RGRVNzdyZDVHckU5R2w0WklWMzFFamxJTGREOWkx?= =?utf-8?B?cjBzYXJuSkpxSWtoRml0QXdrTGVJb0lPaEFPaGhWMjN5SFJNbTNUQS8remQx?= =?utf-8?B?aTNHQXRqOFlXT1gvRDllUm10d1E3ampHSEZpMzFmOC8zL0pyRUQ2ZWlEMHpm?= =?utf-8?B?WDhSN0tMRjJIVFBNeUVGeE0xQUdGc0NuYXJNai93cndlWDFQZmdGU3NvZVVC?= =?utf-8?B?R01mQmJXNmNVMndFUm1mR3NZYTVLSURxTHA5Q0xacE9lZkNWUjl4VGhWYm80?= =?utf-8?B?eHlTNFcraU5rZFE4TDlHcnMwbGtNUitOUnU5Ny8rclJUZWNNYzNxR0xBb3NS?= =?utf-8?B?Z1d3dXA0bjlDenl6dDdsL0NrZU0vNC9ra05GNkY0M25maUVVa29EVGRKdXJB?= =?utf-8?B?Zjl5QkwzbjR1ZTF0OVo5ZkFYVjkvTHViOWV0K2NneFlvRUloaWw5TFNYa0tS?= =?utf-8?B?RXF6NzdzSWZBSVNMdjdvc1BwU2lJdG5kMHJsdk9IWWVMelM2RnViTVhLdFo1?= =?utf-8?B?WmVQRlVCNHY4Q1FSRy9FUm9LUGk1emNWTVh5dFZOMVpIMlJyYWhVLzJPTy9n?= =?utf-8?B?OUN3SGwvczJZNkxuTG9CNlB1N0lTT3FNa2t3d29hK3luMTZPT05wUFZQb0w5?= =?utf-8?B?cGRVc2ZUenI0RnFVc2w3RGRIWmpaTzBzWTBvZFVxdk5RdDlBVTUrc0E0Mngw?= =?utf-8?B?aGsvWkJ3Z0prdzlHVG1hSGF0VndpNmpZQW1FZ0R4VjdNUnNUNmZ1M09JK2hm?= =?utf-8?B?U1hjeW5KUC9CN0R0Mm9EOUk0VTJSNkcwdk9iZFNab3ZPY2t5b3g4WFRZVWZI?= =?utf-8?B?YlZZTnY5d1J5Y2tnQlkxd0NwS3JkWjR5VzZNZjAya0xiaVZGUU1DWWMwam0y?= =?utf-8?B?b0N4R3kwQkNDdTBDczlzY1VZWnM1YnVwa09pNUlTc2kyNFJBTmVKbXQ5YlNQ?= =?utf-8?B?TGRTRE11ZEdMeTVqclR3ZERDeTNMQjgyMDEwemhHQU9hNk9iRlRQSzZHL0wx?= =?utf-8?B?c0lHQURtUDFLQm52MkNTa0hUdnMrOGFDZE1iKzlpR0szRS9iTjhRUEVzWGJC?= =?utf-8?B?VEhQMGVJVDAxcTNLYnhWMjk2QWF2Qis2Z0VmbEE0a2ROU1FhV3I0VzVqT3d5?= =?utf-8?B?QlFkQ25XTEg4OUxpc3lwNTV3UVdpQVgrbjZ0MW5VVWVIYUtrV3pSbSswaVBv?= =?utf-8?B?WVNnNE5zNHNjVVlHLzVuUzdtMit0Z3dsSVBhSEV3TjVwMmorc3VyYSs5YndH?= =?utf-8?B?UnIxYkRoSXhKMVI1RGY0djZBbjV5cDNGK000MUpEeDZZR1lDaGFWQWxiSndH?= =?utf-8?B?NUF4SURyc0kwYUlKZ1VtT05TZGMwYWJkZllQVFVNbkU1MVhnZnRKNzltTVB3?= =?utf-8?B?bDdKK1IyWHNOWGFZUCswNmlFWkxxcFZndXlJWkNOOVRSUCsxNHl5Y0w1dVRQ?= =?utf-8?B?NjdvWWthRDllUldmZmhLb3YzR0srdGwraldyZ2RsOHBXQkdFL25kUlVNOVZB?= =?utf-8?B?ekR2NEJKL2k2YlZVTFpKKzg4MnJqVGsvOUtBTUFBMHRYSUljUGk4c0xSYTBt?= =?utf-8?B?VkZnc3ZSUFNTVmg2QytMZTZqTmwvM3FiZTNTdC9vOTR5NGlXWGN1N1M3dUNH?= =?utf-8?B?N2xWdGhSRmJsMFhtRHV0bWNGdUdKMUYrK0FqclB4TnVKT0ZkQVMzMXprU1RI?= =?utf-8?B?R2dnZVVkeEIvOHBGSXovZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUNxSVZNaUlMMHZ1MVJmMEVWVWFUNmRyZUJudTRrUlVINmlmQUxyMGpVRllk?= =?utf-8?B?YzRDcjNxY1ZCb0RUaW4zVzN3NGwvS25qZlRyUHJmTU1TOTI5ZytPOUYxc0Mz?= =?utf-8?B?M1FsVE5waUUrdjJISWtaUGNXelBtdmw4bGxQT3ZDREl6T2ZNQ2lHMUtPUllL?= =?utf-8?B?MGp1ekRIWERaanc5Y2I3SXNPU1Q1czdyOFFMdVdjbGVmaHpHOVNiWWZJbmpk?= =?utf-8?B?eFQwb2I4RkJNbDR3ekxZYlltSXRxc0RnMDBFNlFYMnNoL2RkaUhjbHBWckJB?= =?utf-8?B?QXNvTXhvZzgvUTcxd0xCeitkRnhkWU5Ybmh4MXNDNS9CemQvb2h0TjJ6NmxK?= =?utf-8?B?a1pjMy9jOWZrQ1NLalJvVkFUbk1STU5ETlpuZ1lyVDhzZDBFNGxQanRpZlhw?= =?utf-8?B?TXphTllaeWZPR0tMMG5kazZPKytMdFp6Sk5VY1lTUW5MS0h6QW02emZGZ2t3?= =?utf-8?B?VFZTbmhSRFJyVkVHT1FQTGJldTVvYW0zWlFYeWNTODFUdll0N1BIbEcwaHM5?= =?utf-8?B?RzJDc2NGRUh6ZzB3cTNyT0p5RkRLSXdCNCtxSzAvbkZVNW9JcEJxL3JCbTdx?= =?utf-8?B?cHd6aXZSd0dRcXlDdWJZWVdrYm8rcFVsNEhmQTV1S0QxTzE4TVJvOEZHcE0v?= =?utf-8?B?cXhXeUhFQkg3Yms2WWQ5VWlyWXY4Lyt0Mm5mNFNQbE9ydnZjT1JUempRWkhZ?= =?utf-8?B?a3ZGeFBBWVZrdVBteXpuU09iUmtZM1ZJUXdEams0b0dZY1hnZmRQajV3eFNI?= =?utf-8?B?cHJYaGh0bzNBdUJqcVhLZkhWcTdCSXB0d2J2MEV4alcvYzQyRCtkQ0Z4ODlk?= =?utf-8?B?ZU9NcVp4Njc0VDZYR0Uvei8yblErcUdWRVIwbWV4OG9adWZPUGlEdTdyd2xj?= =?utf-8?B?Ty8xZUlPcHFVVEE1RE5kY0krZ3dXSW8rZ1plSm9udmlKdWFKbmVjR3MxRGc2?= =?utf-8?B?R3BMcFg1N3ZRUTRMSmR4c0JwRG01R3JnSnRmVEllY0lUVklmTEdGU0xuQ0c1?= =?utf-8?B?UWZDdytHamJJMWJmUUwwVjE2di9OQithYitWdUJDNlVUblBwKzdjWnhXRVhS?= =?utf-8?B?d2FuRDhCdTJXaURhTXhQZ0pYMkJ0am9FYjZXMXFnTHRaVFhmekwvdnVMNEh1?= =?utf-8?B?b0Z3OWFGVEo2NlVpS25td2J1bHpvZEdkdkZLUTNGSnVsV0RPRWdVaUk2VTFp?= =?utf-8?B?NWhEemRDUXQ2QXVvdWVvSWNBMHRSTXI1ck5vM2dmL3pjblQxNStFeThSdzdq?= =?utf-8?B?NFV1Z1Q3cS9lMkl2WURrYlJFZ3VnbnNvanVMQ01JVURRVFRBMHp2cFp6cHk2?= =?utf-8?B?Y0Q2YW1GYXJuM0tVc1NBSldnR3dxc3ZVYVE2ZXZWUC8vREd5d1FzYzBSVnFj?= =?utf-8?B?aU11V24zc09qSU9hRU9nQ2RJVXdDZnA4Q2poUXdraG4zMEdsRlFkazZBOEtw?= =?utf-8?B?MWM4dHhtTk1qQjY0bElZZEtKSXlQazhqTnoyYmJUU0dXbGhRWEtmVjVpcitG?= =?utf-8?B?T1cxdnZodUQ1RmxJRE5ZNDlkalNWa2tKN0w0VHV2eEJBVzcySGV1cHFoQlhE?= =?utf-8?B?emV2dUtibnh1aDlNUnRmUWhNbHNPS0NuNWpzSnRtc1N1U2tTUythY1hCZUxZ?= =?utf-8?B?dXBkNzlzVm81ZkZpb2h5Z3BCaFZzdVR3L1g1U0tZN2pKakYyZVdLNVJWK2cx?= =?utf-8?B?WWxDN21HR2t6UWNOWVNCOFZUR0wybUsvaVpScFNqOHNoUWNRYzg3amZFWjRm?= =?utf-8?B?aDhMSGV0NldhWGJsbXg1RGhPVk53VG1XT2pjZUtCRWtxUk1oR0lRRERPNDFx?= =?utf-8?B?a05HZjJVNFYvZy80R1lUYVZLUk5GamwvREF5bld4WkZzUGJKS3Zob2lCdE5i?= =?utf-8?B?Y0xDUEtBdkdTd0MwMmVIUXlsMGJSNFJsUERGSkFKWkd4ZU0zZkNiNFd4RGMy?= =?utf-8?B?VGJYSWh0MlZoRS91RFJhZEpuQmVrUW8zZXZ4RnpUTWQrZE5yM0k0MnF5WUYv?= =?utf-8?B?OU1LSFJjMFFWMFAxTWNvbmVDVEdHSEJHVTFHbkVFM0NmSFR4Qm5TZFRuMEdN?= =?utf-8?B?blB2YXN6ZEVTeUpjM1JpVGFwWmwxTTlPYk5jUjRYVHFYcEcyNHQ5ZmRJQXBH?= =?utf-8?Q?EMFRHsBGw4IYuoeCKrIsrfMVE?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 549b4fff-f317-4f0a-91d7-08dcdb212504 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2024 16:10:58.3392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tzfn0kRm0Ip595LcX2xl4zULkoWynMWIY2RHrl2SwX4XrMRMA46RwPg20VuBfQiV X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6917 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/7/2024 8:27 AM, Xu, Rosen wrote: > Hi, > >> -----Original Message----- <...> >> Subject: [PATCH 1/4] ethdev: make parameters to TM node add fn constant >> >> The function to add a new scheduling node in rte_tm should not (and does >> not) modify the actual node parameters passed in via struct pointer. We >> should guarantee this by marking the parameter pointer as const. This allows >> SW to create multiple scheduling nodes using the same parameter struct >> without having to reset it each time. >> >> Signed-off-by: Bruce Richardson >> --- >> drivers/net/ipn3ke/ipn3ke_tm.c | 4 ++-- >> diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c >> b/drivers/net/ipn3ke/ipn3ke_tm.c index 0260227900..cffe1fdaa4 100644 >> --- a/drivers/net/ipn3ke/ipn3ke_tm.c >> +++ b/drivers/net/ipn3ke/ipn3ke_tm.c >> @@ -1010,7 +1010,7 @@ ipn3ke_tm_tdrop_profile_delete(struct >> rte_eth_dev *dev, static int >> ipn3ke_tm_node_add_check_parameter(uint32_t tm_id, >> uint32_t node_id, uint32_t parent_node_id, uint32_t priority, >> - uint32_t weight, uint32_t level_id, struct rte_tm_node_params >> *params, >> + uint32_t weight, uint32_t level_id, const struct rte_tm_node_params >> +*params, >> struct rte_tm_error *error) >> { >> uint32_t level_of_node_id; >> @@ -1168,7 +1168,7 @@ ipn3ke_tm_node_add_check_mount(uint32_t >> tm_id, static int ipn3ke_tm_node_add(struct rte_eth_dev *dev, >> uint32_t node_id, uint32_t parent_node_id, uint32_t priority, >> - uint32_t weight, uint32_t level_id, struct rte_tm_node_params >> *params, >> + uint32_t weight, uint32_t level_id, const struct rte_tm_node_params >> +*params, >> struct rte_tm_error *error) >> { >> struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev); diff -- >> /** @internal Traffic manager node delete */ >> -- >> 2.43.0 > > Reviewed-by: Rosen Xu > Acked-by: Ferruh Yigit