DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type
@ 2014-06-24 14:41 Pablo de Lara
  2014-06-24 14:46 ` Ananyev, Konstantin
  0 siblings, 1 reply; 6+ messages in thread
From: Pablo de Lara @ 2014-06-24 14:41 UTC (permalink / raw)
  To: dev

From: Pablo de Lara <pablo.de.lara.guarch@intel.com>

This was previosly solved in commit 60a70d4e042350ca0f9200334b341063438be89b,
but this alternative fix solves the same issue, but without modifying
the ixgbe shared code.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c  |    3 --
 lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c |   35 ++++++++++++++++++----------
 2 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
index 93c4e35..ed97ad9 100644
--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
@@ -537,9 +537,6 @@ enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw)
 	case IXGBE_DEV_ID_82599_SFP_SF2:
 	case IXGBE_DEV_ID_82599_SFP_SF_QP:
 	case IXGBE_DEV_ID_82599EN_SFP:
-#ifdef RTE_NIC_BYPASS 
-	case IXGBE_DEV_ID_82599_BYPASS:
-#endif
 		media_type = ixgbe_media_type_fiber;
 		break;
 	case IXGBE_DEV_ID_82599_CX4:
diff --git a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
index 27a5f70..6748ea4 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
@@ -256,19 +256,6 @@ out:
 	return status;
 }
 
-/*
- * Wrapper around ND functions to support BYPASS nic.
- */
-s32
-ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw)
-{
-	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
-		hw->mac.type = ixgbe_mac_82599EB;
-	}
-
-	return (ixgbe_init_shared_code(hw));
-}
-
 static enum ixgbe_media_type
 ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)
 {
@@ -284,6 +271,28 @@ ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)
 	return (media_type);
 }
 
+/*
+ * Wrapper around ND functions to support BYPASS nic.
+ */
+s32
+ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw)
+{
+	s32 ret_val;
+
+	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
+		hw->mac.type = ixgbe_mac_82599EB;
+	}
+
+	ret_val = ixgbe_init_shared_code(hw);
+	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
+		hw->mac.ops.get_media_type = &ixgbe_bypass_get_media_type;
+		ixgbe_init_mac_link_ops_82599(hw);
+	}
+
+	return ret_val;
+}
+
+
 s32
 ixgbe_bypass_init_hw(struct ixgbe_hw *hw)
 {
-- 
1.7.0.7

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type
  2014-06-24 14:41 [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type Pablo de Lara
@ 2014-06-24 14:46 ` Ananyev, Konstantin
  2014-06-24 15:22   ` Zhang, Helin
  2014-06-26 12:24   ` Thomas Monjalon
  0 siblings, 2 replies; 6+ messages in thread
From: Ananyev, Konstantin @ 2014-06-24 14:46 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, dev


> This was previosly solved in commit 60a70d4e042350ca0f9200334b341063438be89b,
> but this alternative fix solves the same issue, but without modifying
> the ixgbe shared code.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c  |    3 --
>  lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c |   35 ++++++++++++++++++----------
>  2 files changed, 22 insertions(+), 16 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> index 93c4e35..ed97ad9 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> @@ -537,9 +537,6 @@ enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw)
>  	case IXGBE_DEV_ID_82599_SFP_SF2:
>  	case IXGBE_DEV_ID_82599_SFP_SF_QP:
>  	case IXGBE_DEV_ID_82599EN_SFP:
> -#ifdef RTE_NIC_BYPASS
> -	case IXGBE_DEV_ID_82599_BYPASS:
> -#endif
>  		media_type = ixgbe_media_type_fiber;
>  		break;
>  	case IXGBE_DEV_ID_82599_CX4:
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> index 27a5f70..6748ea4 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> @@ -256,19 +256,6 @@ out:
>  	return status;
>  }
> 
> -/*
> - * Wrapper around ND functions to support BYPASS nic.
> - */
> -s32
> -ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw)
> -{
> -	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> -		hw->mac.type = ixgbe_mac_82599EB;
> -	}
> -
> -	return (ixgbe_init_shared_code(hw));
> -}
> -
>  static enum ixgbe_media_type
>  ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)
>  {
> @@ -284,6 +271,28 @@ ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)
>  	return (media_type);
>  }
> 
> +/*
> + * Wrapper around ND functions to support BYPASS nic.
> + */
> +s32
> +ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw)
> +{
> +	s32 ret_val;
> +
> +	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> +		hw->mac.type = ixgbe_mac_82599EB;
> +	}
> +
> +	ret_val = ixgbe_init_shared_code(hw);
> +	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> +		hw->mac.ops.get_media_type = &ixgbe_bypass_get_media_type;
> +		ixgbe_init_mac_link_ops_82599(hw);
> +	}
> +
> +	return ret_val;
> +}
> +
> +
>  s32
>  ixgbe_bypass_init_hw(struct ixgbe_hw *hw)
>  {
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type
  2014-06-24 14:46 ` Ananyev, Konstantin
@ 2014-06-24 15:22   ` Zhang, Helin
  2014-06-24 15:30     ` Ananyev, Konstantin
  2014-06-26 12:24   ` Thomas Monjalon
  1 sibling, 1 reply; 6+ messages in thread
From: Zhang, Helin @ 2014-06-24 15:22 UTC (permalink / raw)
  To: Ananyev, Konstantin, De Lara Guarch, Pablo; +Cc: dev

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstantin
Sent: Tuesday, June 24, 2014 10:47 PM
To: De Lara Guarch, Pablo; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type


> This was previosly solved in commit 
> 60a70d4e042350ca0f9200334b341063438be89b,
> but this alternative fix solves the same issue, but without modifying 
> the ixgbe shared code.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c  |    3 --
>  lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c |   35 ++++++++++++++++++----------
>  2 files changed, 22 insertions(+), 16 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c 
> b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> index 93c4e35..ed97ad9 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> @@ -537,9 +537,6 @@ enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw)
>  	case IXGBE_DEV_ID_82599_SFP_SF2:
>  	case IXGBE_DEV_ID_82599_SFP_SF_QP:
>  	case IXGBE_DEV_ID_82599EN_SFP:
> -#ifdef RTE_NIC_BYPASS
> -	case IXGBE_DEV_ID_82599_BYPASS:
> -#endif
>  		media_type = ixgbe_media_type_fiber;
>  		break;
>  	case IXGBE_DEV_ID_82599_CX4:
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c 
> b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> index 27a5f70..6748ea4 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> @@ -256,19 +256,6 @@ out:
>  	return status;
>  }
> 
> -/*
> - * Wrapper around ND functions to support BYPASS nic.
> - */
> -s32
> -ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw) -{
> -	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> -		hw->mac.type = ixgbe_mac_82599EB;
> -	}
> -
> -	return (ixgbe_init_shared_code(hw));
> -}
> -
>  static enum ixgbe_media_type
>  ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)  { @@ -284,6 +271,28 
> @@ ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)
>  	return (media_type);
>  }
> 
> +/*
> + * Wrapper around ND functions to support BYPASS nic.
> + */
> +s32
> +ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw) {
> +	s32 ret_val;
> +
> +	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> +		hw->mac.type = ixgbe_mac_82599EB;
> +	}
> +
> +	ret_val = ixgbe_init_shared_code(hw);
> +	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> +		hw->mac.ops.get_media_type = &ixgbe_bypass_get_media_type;
> +		ixgbe_init_mac_link_ops_82599(hw);
> +	}
> +
> +	return ret_val;
> +}
> +
> +
>  s32
>  ixgbe_bypass_init_hw(struct ixgbe_hw *hw)  {
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

--------------------------------------------------------------------------------------------------------

Hi Pablo

It seems that you modified ixgbe_82599.c. Do we really need to do that modification in ixgbe_82599.c? Generally we try to avoid doing that.

Regards,
Helin

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type
  2014-06-24 15:22   ` Zhang, Helin
@ 2014-06-24 15:30     ` Ananyev, Konstantin
  2014-06-24 15:34       ` Zhang, Helin
  0 siblings, 1 reply; 6+ messages in thread
From: Ananyev, Konstantin @ 2014-06-24 15:30 UTC (permalink / raw)
  To: Zhang, Helin, De Lara Guarch, Pablo; +Cc: dev

Hi Helin,

> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, June 24, 2014 4:23 PM
> To: Ananyev, Konstantin; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type
> 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstantin
> Sent: Tuesday, June 24, 2014 10:47 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type
> 
> 
> > This was previosly solved in commit
> > 60a70d4e042350ca0f9200334b341063438be89b,
> > but this alternative fix solves the same issue, but without modifying
> > the ixgbe shared code.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> >  lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c  |    3 --
> >  lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c |   35 ++++++++++++++++++----------
> >  2 files changed, 22 insertions(+), 16 deletions(-)
> >
> > diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> > b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> > index 93c4e35..ed97ad9 100644
> > --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> > @@ -537,9 +537,6 @@ enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw)
> >  	case IXGBE_DEV_ID_82599_SFP_SF2:
> >  	case IXGBE_DEV_ID_82599_SFP_SF_QP:
> >  	case IXGBE_DEV_ID_82599EN_SFP:
> > -#ifdef RTE_NIC_BYPASS
> > -	case IXGBE_DEV_ID_82599_BYPASS:
> > -#endif
> >  		media_type = ixgbe_media_type_fiber;
> >  		break;
> >  	case IXGBE_DEV_ID_82599_CX4:
> > diff --git a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> > b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> > index 27a5f70..6748ea4 100644
> > --- a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> > @@ -256,19 +256,6 @@ out:
> >  	return status;
> >  }
> >
> > -/*
> > - * Wrapper around ND functions to support BYPASS nic.
> > - */
> > -s32
> > -ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw) -{
> > -	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> > -		hw->mac.type = ixgbe_mac_82599EB;
> > -	}
> > -
> > -	return (ixgbe_init_shared_code(hw));
> > -}
> > -
> >  static enum ixgbe_media_type
> >  ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)  { @@ -284,6 +271,28
> > @@ ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)
> >  	return (media_type);
> >  }
> >
> > +/*
> > + * Wrapper around ND functions to support BYPASS nic.
> > + */
> > +s32
> > +ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw) {
> > +	s32 ret_val;
> > +
> > +	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> > +		hw->mac.type = ixgbe_mac_82599EB;
> > +	}
> > +
> > +	ret_val = ixgbe_init_shared_code(hw);
> > +	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> > +		hw->mac.ops.get_media_type = &ixgbe_bypass_get_media_type;
> > +		ixgbe_init_mac_link_ops_82599(hw);
> > +	}
> > +
> > +	return ret_val;
> > +}
> > +
> > +
> >  s32
> >  ixgbe_bypass_init_hw(struct ixgbe_hw *hw)  {
> > --
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> --------------------------------------------------------------------------------------------------------
> 
> Hi Pablo
> 
> It seems that you modified ixgbe_82599.c. Do we really need to do that modification in ixgbe_82599.c? Generally we try to avoid doing
> that.
> 
> Regards,
> Helin

Actually that's the purpose of that patch: fix the problem without modifying shared code.
So he removing previous modifications in the shared code.
Konstantin

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type
  2014-06-24 15:30     ` Ananyev, Konstantin
@ 2014-06-24 15:34       ` Zhang, Helin
  0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Helin @ 2014-06-24 15:34 UTC (permalink / raw)
  To: Ananyev, Konstantin, De Lara Guarch, Pablo; +Cc: dev



-----Original Message-----
From: Ananyev, Konstantin 
Sent: Tuesday, June 24, 2014 11:31 PM
To: Zhang, Helin; De Lara Guarch, Pablo
Cc: dev@dpdk.org
Subject: RE: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type

Hi Helin,

> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, June 24, 2014 4:23 PM
> To: Ananyev, Konstantin; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 
> Bypass NIC, getting incorrect media type
> 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, 
> Konstantin
> Sent: Tuesday, June 24, 2014 10:47 PM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 
> Bypass NIC, getting incorrect media type
> 
> 
> > This was previosly solved in commit
> > 60a70d4e042350ca0f9200334b341063438be89b,
> > but this alternative fix solves the same issue, but without 
> > modifying the ixgbe shared code.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> >  lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c  |    3 --
> >  lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c |   35 ++++++++++++++++++----------
> >  2 files changed, 22 insertions(+), 16 deletions(-)
> >
> > diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> > b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> > index 93c4e35..ed97ad9 100644
> > --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c
> > @@ -537,9 +537,6 @@ enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw)
> >  	case IXGBE_DEV_ID_82599_SFP_SF2:
> >  	case IXGBE_DEV_ID_82599_SFP_SF_QP:
> >  	case IXGBE_DEV_ID_82599EN_SFP:
> > -#ifdef RTE_NIC_BYPASS
> > -	case IXGBE_DEV_ID_82599_BYPASS:
> > -#endif
> >  		media_type = ixgbe_media_type_fiber;
> >  		break;
> >  	case IXGBE_DEV_ID_82599_CX4:
> > diff --git a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> > b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> > index 27a5f70..6748ea4 100644
> > --- a/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c
> > @@ -256,19 +256,6 @@ out:
> >  	return status;
> >  }
> >
> > -/*
> > - * Wrapper around ND functions to support BYPASS nic.
> > - */
> > -s32
> > -ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw) -{
> > -	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> > -		hw->mac.type = ixgbe_mac_82599EB;
> > -	}
> > -
> > -	return (ixgbe_init_shared_code(hw));
> > -}
> > -
> >  static enum ixgbe_media_type
> >  ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)  { @@ -284,6 
> > +271,28 @@ ixgbe_bypass_get_media_type(struct ixgbe_hw *hw)
> >  	return (media_type);
> >  }
> >
> > +/*
> > + * Wrapper around ND functions to support BYPASS nic.
> > + */
> > +s32
> > +ixgbe_bypass_init_shared_code(struct ixgbe_hw *hw) {
> > +	s32 ret_val;
> > +
> > +	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> > +		hw->mac.type = ixgbe_mac_82599EB;
> > +	}
> > +
> > +	ret_val = ixgbe_init_shared_code(hw);
> > +	if (hw->device_id == IXGBE_DEV_ID_82599_BYPASS) {
> > +		hw->mac.ops.get_media_type = &ixgbe_bypass_get_media_type;
> > +		ixgbe_init_mac_link_ops_82599(hw);
> > +	}
> > +
> > +	return ret_val;
> > +}
> > +
> > +
> >  s32
> >  ixgbe_bypass_init_hw(struct ixgbe_hw *hw)  {
> > --
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> ----------------------------------------------------------------------
> ----------------------------------
> 
> Hi Pablo
> 
> It seems that you modified ixgbe_82599.c. Do we really need to do that 
> modification in ixgbe_82599.c? Generally we try to avoid doing that.
> 
> Regards,
> Helin

Actually that's the purpose of that patch: fix the problem without modifying shared code.
So he removing previous modifications in the shared code.
Konstantin

----------------------------------------------------------------------------------------------------------------------------------
Hi Konstantin

OK. I got it. It is a roll-back. Thanks!

Regards,
Helin

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type
  2014-06-24 14:46 ` Ananyev, Konstantin
  2014-06-24 15:22   ` Zhang, Helin
@ 2014-06-26 12:24   ` Thomas Monjalon
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2014-06-26 12:24 UTC (permalink / raw)
  To: De Lara Guarch, Pablo; +Cc: dev

> > This was previosly solved in commit
> > 60a70d4e042350ca0f9200334b341063438be89b, but this alternative fix solves
> > the same issue, but without modifying the ixgbe shared code.
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied for version 1.7.0.

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-06-26 12:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-24 14:41 [dpdk-dev] [PATCH] ixgbe: Alternative fix for 82599 Bypass NIC, getting incorrect media type Pablo de Lara
2014-06-24 14:46 ` Ananyev, Konstantin
2014-06-24 15:22   ` Zhang, Helin
2014-06-24 15:30     ` Ananyev, Konstantin
2014-06-24 15:34       ` Zhang, Helin
2014-06-26 12:24   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git