From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E371A00C5; Thu, 15 Sep 2022 12:18:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19E514021D; Thu, 15 Sep 2022 12:18:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 57B0240156 for ; Thu, 15 Sep 2022 12:18:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663237096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nrpGzotwRAFS8ZIVK8xC/s6sB+h96k2/mnWt5hik/Wg=; b=ATL7s9bLAQSC8YJOcPhBh6L8zpIY98pDAKby9Gk8wfGeSA/CPLOYDVW+8TXODV9XmLFSX0 Tx1s9xTeyPhBK9qG3FPldaAkm/1yIh+35wjp+Dd8q0aCgnUf8/DhmqZJO9ZswiDVjvIa4M pVMqwZaoIhOCr/F/kEI/QmC/APOYyZg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-47-5ygs2bSuOR28Gw1fmxEzQA-1; Thu, 15 Sep 2022 06:18:13 -0400 X-MC-Unique: 5ygs2bSuOR28Gw1fmxEzQA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 56F718027EA; Thu, 15 Sep 2022 10:18:13 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 243C140C6EC2; Thu, 15 Sep 2022 10:18:11 +0000 (UTC) Message-ID: <85273414-3d82-453c-04fe-8800e19249f6@redhat.com> Date: Thu, 15 Sep 2022 12:18:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 27/37] baseband/acc100: store FCW from first CB descriptor To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-28-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-28-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Store the descriptor from the first code block from a transport block. > Copy the LDPC FCW from the first descriptor into the rest of the CBs in > that TB. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 36455d5338..69de204293 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -3872,6 +3872,7 @@ enqueue_ldpc_dec_one_op_tb(struct acc100_queue *q, struct rte_bbdev_dec_op *op, > uint16_t total_enqueued_cbs, uint8_t cbs_in_tb) > { > union acc100_dma_desc *desc = NULL; > + union acc100_dma_desc *desc_first = NULL; Minor nit, but NULL assignment looks unncessary. > int ret; > uint8_t r, c; > uint32_t in_offset, h_out_offset, > @@ -3890,6 +3891,7 @@ enqueue_ldpc_dec_one_op_tb(struct acc100_queue *q, struct rte_bbdev_dec_op *op, > uint16_t desc_idx = ((q->sw_ring_head + total_enqueued_cbs) > & q->sw_ring_wrap_mask); > desc = q->ring_addr + desc_idx; > + desc_first = desc; > uint64_t fcw_offset = (desc_idx << 8) + ACC100_DESC_FCW_OFFSET; > union acc100_harq_layout_data *harq_layout = q->d->harq_layout; > q->d->fcw_ld_fill(op, &desc->req.fcw_ld, harq_layout); > @@ -3915,6 +3917,8 @@ enqueue_ldpc_dec_one_op_tb(struct acc100_queue *q, struct rte_bbdev_dec_op *op, > & q->sw_ring_wrap_mask); > desc->req.data_ptrs[0].address = q->ring_addr_iova + fcw_offset; > desc->req.data_ptrs[0].blen = ACC100_FCW_LD_BLEN; > + rte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld, > + ACC100_FCW_LD_BLEN); > ret = acc100_dma_desc_ld_fill(op, &desc->req, &input, > h_output, &in_offset, &h_out_offset, > &h_out_length, Reviewed-by: Maxime Coquelin Thanks, Maxime