From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3B4AA04DC; Mon, 19 Oct 2020 16:11:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EEACC8DA; Mon, 19 Oct 2020 16:11:27 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 22FB02D41 for ; Mon, 19 Oct 2020 16:11:25 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id B1D795C01AB; Mon, 19 Oct 2020 10:11:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 10:11:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= OoNiOMostJPXOv+vuCtCKGXsuc0s0LrLTOj3q7phDPk=; b=dMSO7ID7tlUsf6nh 3MNUHhIhG2MQK++LZLZ2+zzbtGPnDsw37cxbToo0JBW3+SDiPLj/o75UqkJtbdHx kdCsVND/Qn77340hQzB2EXeXjU0n87UZqz4CGCJj0VQuji7p+13xkYIfV4+Guvmz 9N2oHso+3DDrxx/br9m40/7mXqNYWxGgwDhIdlI4t/vZRtyGbVGtFWfbZHRzwFqo 5dpdeqzCSdEffee07W69BB5bdutlkLka0CJC7sYBatRwoNGYknAtqiOO7z2fsZ/1 qs7y61xWA8fGyZM6YXdSoExM7HGTSn4pjtJ9L54hZls+qEr9z3in+kB3CrnwUbaz 64UzQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=OoNiOMostJPXOv+vuCtCKGXsuc0s0LrLTOj3q7phD Pk=; b=adm9ZN16y8amBDqbohAwrZGq1uGnjKeOHUDfqkUcb5cBDlrvuhwTArzIB hI9Z08jCp1jNoG6bZJjSeLpIG1Rs9XzlWmRDNKZf5gY94Mr+2eO1nATGJPh1ta7Z xA6QmhQ+jub+2qxisiPC8utKLU3gnoaytGz7tWaZoZBK8H1DJZEBspHTtC77oSlm CsWL6Y88iGqwSrr1OLwB2VFnw9JYmcacZf1yJ0x5d7iVRIO5eZ9U+Xkr3yFCStAs 3LdafXf1EOxwte78DNUhmFJoyWz/y7F0kytF8KbGC1Cyy9Lv/tcsB0uPtFAUGtD2 aM95ytowBlglTeXofa1F9bfokizhA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedugdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A94ED306467D; Mon, 19 Oct 2020 10:11:21 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Dmitry Kozlyuk , Stephen Hemminger Cc: dev@dpdk.org, david.marchand@redhat.com, olivier.matz@6wind.com Date: Mon, 19 Oct 2020 16:11:19 +0200 Message-ID: <8528402.suE0oRMLcd@thomas> In-Reply-To: <20200817081137.3b00fd39@hermes.lan> References: <20200814173441.23086-1-stephen@networkplumber.org> <20200817103740.GA496@bricha3-MOBL.ger.corp.intel.com> <20200817081137.3b00fd39@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: add option to put timestamp on console output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There was no ack or conclusion for this patch. 17/08/2020 17:11, Stephen Hemminger: > On Mon, 17 Aug 2020 11:37:40 +0100 > Bruce Richardson wrote: > > > On Fri, Aug 14, 2020 at 12:20:28PM -0700, Stephen Hemminger wrote: > > > On Fri, 14 Aug 2020 22:09:11 +0300 > > > Dmitry Kozlyuk wrote: > > > > > > > On Fri, 14 Aug 2020 11:45:49 -0700, Stephen Hemminger wrote: > > > > > On Fri, 14 Aug 2020 21:39:29 +0300 > > > > > Dmitry Kozlyuk wrote: > > > > [...] > > > > > FreeBsd doesn't go through the same log code. > > > > > > > > Then --log-timestamp shouldn't appear on FreeBSD if it's unsupported. > > > > > > Was using same ifdef that is already there. There are several options already > > > (like syslog facility) which do nothing on FreeBSD anyway. > > > > > While that is correct, I think that we really should support this on > > FreeBSD also, since I don't think there is any technical reason we can't do > > so, right? Even a sub-optimal solution where the timestamp write and log > > write are non-atomic would be better than nothing. > > > > /Bruce > > FreeBSD now just uses default log stream (stdout). > Linux has log stream to syslog and stdout. > > There is nothing Linux specific in the old or new code. > The Linux code could just be moved to common, and both could use it. > That is a separate patch, and someone with expertise and build setup for FreeBSD needs to do it. >