DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org, Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] mk: fix linker script when re-building
Date: Thu, 17 Mar 2016 21:48:09 +0100	[thread overview]
Message-ID: <8528444.vnvGEzYpHh@xps13> (raw)
In-Reply-To: <56EA7ADE.70009@redhat.com>

2016-03-17 11:37, Panu Matilainen:
> On 03/17/2016 01:22 AM, Sergio Gonzalez Monroy wrote:
> > The linker script is generated by simply finding all libraries in
> > RTE_OUTPUT/lib.
> >
> > The issue shows up when re-building the DPDK, hence already having a
> > linker script in that directory, resulting in the linker script
> > including itself.
> >
> > That does not play well with the linker.
> >
> > Simply filtering the linker script from all the found libraries solves
> > the problem.
> >
> > Fixes: 948fd64befc3 ("mk: replace the combined library with a linker script")
> >
> > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> 
> Oops, thanks for spotting.
> 
> Acked-by: Panu Matilainen <pmatilai@redhat.com>

Applied, thanks

      reply	other threads:[~2016-03-17 20:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 23:22 Sergio Gonzalez Monroy
2016-03-17  9:37 ` Panu Matilainen
2016-03-17 20:48   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8528444.vnvGEzYpHh@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).