From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C9D7A0350; Tue, 22 Feb 2022 17:50:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6835340DF6; Tue, 22 Feb 2022 17:50:09 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D9D8640DF4 for ; Tue, 22 Feb 2022 17:50:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645548608; x=1677084608; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=eLW6dBWMI9u9pwYLiR1DAi9gKDX34fG367s/NH5a1o8=; b=d2D6GIo/hw0h2Wwt2RA5N4W350yIemqLGmZbAHsc2cuzglPqqAvJE0yY hfspuWgB/df9JgJBzaVv69oHXr7gG+0rf9+lslg78uuojWXaaeNIiE3V/ ecF4cPSb2dUbiHEJYUFgMr6NcJ/7M+vGbMSf7WCB/3IHoAFZVu/chgMNa ktv+B+q/UNsPB3Q6RUafeFTzM59FUeldF0fDPXSK0bKmDtcqDZWL+mASF H9LC2ssC00kDuWk2P1Q82XcLJsn94L7yGaYblMAdYVO5ePJFCLqXEb4a+ dghAOC3i9sp9UGpJZtO4EdVJgEAE8eR0Pbjtnk1jjnlLjW4wqhHtayTKP w==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="231725471" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="231725471" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 08:50:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="638969628" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 22 Feb 2022 08:50:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 22 Feb 2022 08:50:05 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 22 Feb 2022 08:50:05 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 22 Feb 2022 08:50:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X9LHAvyXdtNa3lNLSZpp2mLKT8BpacS5CjvWsUrDTucCgcnLk94yxK3UQfoBk2RT3XVqe1wFIWmCLAOoQ8XWqIWHRhZX65ACFfdDlITTG0pg9b4ECIsuvkjZldC2Una7Lj1fc2XnMHDpyGCci7yQEssyYUiih9cyroH6NST7KYpdHzPFMfCKtwbm18aResBilyj7dgxFEhuC6ulk76x3mxxqYhHtvgT5jT6lQrlAQt4zkLDlMhCzNsKGwEn1ZKVUfHBb3soVgXeZ9WUzVNTbEY2WiRcmE95rJSJ45GZr1PuPBKr882WgVqqXUhBA2fclXeUbZ7qTWhJadpoV19Ql3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NakoI/Z39ULJcZVJbIeNpe0M8K76fz19lwyWrDHsur4=; b=ZJeVQk7FfSXKtras+YUapg76+pSzzkg5WBgJYFaD4wAQgzpl5VLoPJ3P15Rhpn0p+HR6Ew6zGK0uf5JBylFP906m/PuySuJhk877YUFc/5WAXb5RCX4lRcjifUs1uFjVSYMja4q3rs6CgSQYD0/XrWCHQ7I+C7lYaXjeVt9SRhq/6NmPM48pvBAh7NOy43pE3UT3KJBuQvd5l1y7OaRadMcWbYZrx44+TPVbvts8S39L/qi7tqj7iLUwwASjRe60QLG1mCVSGjNpMXh73dUiYWvxyaUCO4Z0tX36V4/OFk+s+IQ4Q2/K6SB2N0/8a5CyQFN3eK8LqIiPKJ0JP8dzjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR11MB1595.namprd11.prod.outlook.com (2603:10b6:4:c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Tue, 22 Feb 2022 16:50:03 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022 16:50:03 +0000 Message-ID: <85310cb6-75c0-dbc9-ec4e-13f15362d33f@intel.com> Date: Tue, 22 Feb 2022 16:49:55 +0000 Subject: Re: [PATCH v8 00/10] ethdev: datapath-focused flow rules management Content-Language: en-US From: Ferruh Yigit To: Alexander Kozyrev , , CC: , , , , , , , References: <20220219041144.2145380-1-akozyrev@nvidia.com> <20220220034409.2226860-1-akozyrev@nvidia.com> <1ebbb3cb-a041-6d14-88f0-72eedbaddbdc@intel.com> X-User: ferruhy In-Reply-To: <1ebbb3cb-a041-6d14-88f0-72eedbaddbdc@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0072.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::36) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 154407d0-587f-4d6b-7ba4-08d9f6235ed4 X-MS-TrafficTypeDiagnostic: DM5PR11MB1595:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AMaNAsYaF6HNB/hLkLOfzWn4M0hIzvohM9aJ6LbtAJAa0ko3vuTbFdHKpuwSMleiIh6v7eITuPlWdyymwOvP3+Zyd8yfx6eyWJjJU9ahbxXX9yvzuHHx7Feix5TbCi23RZCj/mM9A/cLA+xEftMp3HiIUvjHelIjIyLADce6xWqZggQZabu06Px4WqveXu7JhNBwqMfyjs5Snfk7WugYGM9wWmqp1HSJRxEIE1LtOMAFl66uwA3dhoUFDxtYhwzWuwCOrxQVU0p7ROzZOCM45aunbhxZ8+d25+krb07wo4k2kX+8VzPsL1xHT6pcnUkB6AZ+2J2cgR4z7xZcFrJD+yCzJxl86hwW9o3F++Vl993CUzXhtJACXiwDm7w9dRzNTo5hvjg4wLhjYyqDLL85YeIhwivZfFDzlnjisX7PQga3nVwcAy/NutWIGOm3qhzanxelWUoeVfQEJsll9rxm9WrFkDGvJlMdKPsLqNcfU4N052+CwvTp0YRZ1bY4c5wSFFQLl8frvwMQbDLN+GjekJGrpWaZXHAP8bJaOTnB1ePyfm0fQqFixbZiOubRFoWAGcUr6MGfJ7s5BjJKtn1J56sDttkQB+dmg7fbulB4n0rwzvaiIe/K9uKfAqCrvJ3U0BpNMDwVYDs5tn2ZrML0/e8aoewzLcK2lHrm0ahaS3wF+VaODzhStJT8ru+aRn1cBGR/nhV4rjkHsDdYndXkOwoCdlqswPsEn2Xx5XIEQzyz1vnxKKS36/qEYmPhO4I4xKf52Zv7fIwIQtHRVFMtj+rikc1mPPxag+EKrWGGqKrwy1Kw9xq8h02iolOK90sMKpfyatN+FrWl4zXbAFxz9xNljWks8u/Cn3gGesTJWJDbxt+tn5/UFB+bX0zGbmCT X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(53546011)(26005)(66946007)(6512007)(66556008)(66476007)(2616005)(107886003)(6506007)(966005)(6486002)(31696002)(508600001)(316002)(6666004)(86362001)(82960400001)(8676002)(83380400001)(4326008)(38100700002)(5660300002)(8936002)(31686004)(2906002)(36756003)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZW5UOXN3bDJEVmtERmxkZWR1d2xMdTh2Um1zNmF2d3lINy9SN0VBd20rUFdq?= =?utf-8?B?UkFjUVMvYTBjUE5IRDFKd25EWC9oSEo5UzRQQm16R2dFa0hWVWhPT2RpcDBw?= =?utf-8?B?bi9qdmVXZ1N5YnFScGpMM3BUVkZ2dVJsZjYvc2gwWDlJTEVtRGltUXlSMndr?= =?utf-8?B?R2pQZGtJRjNKblVQTG1jWjdodWVsQVBYTFVEclh6cmpiTDVtVzc0NTJCTGRG?= =?utf-8?B?dHFLVUFpVEF5eFUxOWpYQTFISWFBSjFPZEo2TVZHd1IrZ0ZVNnFSTXViM3Yz?= =?utf-8?B?T2NwNE1jQVZ4emtEc3JvalVKS3BkS1d1MzhOMEl2aHZwUGxScXFjTE5QMUZW?= =?utf-8?B?cWtxVGhLUlMzN3FOcEwrSFN0TDdIeVd1aWdQcXROeVdhbkUvZTJZaGJLYW4x?= =?utf-8?B?SWxSV3laZDVVOEZULzM1bXRhQ3B5YmUzWGs5Rld3WkNkcGtPdjRPck9aVndT?= =?utf-8?B?Y2hNTVZRUHJNdThZVldSTVhpM3V5V0JnVVF0N2xWWjd2TWFoZVRVY2k0TVZ3?= =?utf-8?B?aFpHSWwrMjhBOVd2L3o3RVhUc215NVkvQkdMVTN4K1JRKzlORDZuVEVrZTll?= =?utf-8?B?VTIyNmlPRGVCOFhiaGZPb21XZWZJVDJ4bmpNSnE3Tk1qeERsNHA1Vk1SN1J4?= =?utf-8?B?U3dCdy83c200WUZKTUZ4UStvQ0N3NW02Nk5sQVp2SHZSZE9LM1Z2ZENkYW1C?= =?utf-8?B?cjRvYzFUZkN6YmQrTk5XMzIvQUFKS251cm1FOFpJenMra1JKa2Nob1U0QW9n?= =?utf-8?B?ZjJWUm1IaXlnL2FYTU5EaTUvb284eXBqUCtaSGlDckZ5SGNXS082eGd0eU9P?= =?utf-8?B?NTA0V1FKemorY0Z6aHJldkdNUW84THk1MnNiVDR1UXJBT3hqN28ydnZWRkJh?= =?utf-8?B?dDJ3dW9qOTVxbG54MTBPeFd4cGVSclJST2ZCTlF4SU1YZE0zbm1Gb1VsdDNC?= =?utf-8?B?MkVLdXE5MFovQVlqcnM0YnZoSlpEazRsZnVhak04dXBINmhYajdqSCttNm5S?= =?utf-8?B?dU5tN0RTWGJwRjZBckR5TUk0SDcxVW82TlpJOHJWamRuZjBrNXEvY1ZBMno0?= =?utf-8?B?VjJQaGs3d1dSVjFzNWpnZVZKZkdHTk5RUXBIL0tmRUxxNUNSMisvODZsSlgy?= =?utf-8?B?WFhKMTB0bFFuMGd6UzUzY2FyL2JWTFFYL3p3ZkVCdEhUdnpqd0xXU1JpUmdV?= =?utf-8?B?SVlqZ1g5eDlmOVh3SVRadG42ZEFDNnp4VTRRVTVNZVdBa2lvQVpvTi9XeTVQ?= =?utf-8?B?ZGRRamZFMTM0YmRYMTB4VXhPV3N6RHVuQSt2bXBhQkFDeS8vL0RHQmRsZGoy?= =?utf-8?B?bTFuUWZPaUo4Qnc4SzJncEJTSktwOG5RKzlvWXcreWVGeDZPUXhWazFlOWMw?= =?utf-8?B?S1p2V25RN0JHcXVBV1R5ZkxTbHN4VFRnVXp5WGsrMjFIMkJmcVBuVlVKa2VS?= =?utf-8?B?RkRMOG5GdDgxSzY4WE8zTzJ6dTZpVUo1UU8rdTR4L1NjUUdYQWRkYU1hQ0Z1?= =?utf-8?B?L3NWM0NqMXBKcWtISGlQbUxadktES0Z6ZVZCQlpWMHBzd0NSbThTenIwTFlm?= =?utf-8?B?aWV6QnJrSWU4d3VjWGJGVWUzT0F4Z29ZajZZOGxIOURJTTlLZFVlV0tVSVRy?= =?utf-8?B?QmZQVkYzalY2Njd2eDVRb1gzU3NQQmY3bWZ4WGFSNTNCS1ZsSHhxczdIRnh6?= =?utf-8?B?bUh5S0l0cWlSV25QcG1XWUNUMmZ6US9BNG5lQ0cyQXhjdTdpZzBmWEtCdUVB?= =?utf-8?B?dE52NmJwTzk3RUNqSmpWZlZ6WFlWUGpiUmpRV1lvOXduUGEraWNOalE5U1RE?= =?utf-8?B?WTdjbDNYTjhFaGxVcTQwYXFMd25iK3FkSkw3Q0tBeUJWV1FrZysweFFKVkE4?= =?utf-8?B?VHB5bkxxdlBDSktSbGVUNlNqQ0dRb0NrL081cGU1VmlzVGVHQU1jTVByQ2Zw?= =?utf-8?B?KzF2aVgxTWtyR3I3THJiRE5qNmhXa2pKcUl3UEtWbUxmUGRiNE96enV0RjRO?= =?utf-8?B?Y1NiL2RoSG85eE0zVlh6bDFYSnhHWVR1bkVOdERsSFRVN1hZODk0N0c4QU1R?= =?utf-8?B?L05wSnJKOW1KYjNIdTA0ZUYvdHFYeUhyNW4zTG1FeER4VzluZURIdjFhells?= =?utf-8?B?RTc2KzlzLzBjelh2dmd0eEp2T1JhOWRMbXU4NFMyVkpqeEsvL0UxMEpKS3RV?= =?utf-8?Q?Ra3D96s6kovBYWR4i6dnvCw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 154407d0-587f-4d6b-7ba4-08d9f6235ed4 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 16:50:02.9281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1U2FQqjkSJEAW9NNWHVhJCF3Ul/lDVpAd1IP/j2TFZ6F6buT2vq2bTgDwYAi31hbjqiC2TR3jAfUrSB0u+LOaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1595 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/22/2022 4:41 PM, Ferruh Yigit wrote: > On 2/20/2022 3:43 AM, Alexander Kozyrev wrote: >> Three major changes to a generic RTE Flow API were implemented in order >> to speed up flow rule insertion/destruction and adapt the API to the >> needs of a datapath-focused flow rules management applications: >> >> 1. Pre-configuration hints. >> Application may give us some hints on what type of resources are needed. >> Introduce the configuration routine to prepare all the needed resources >> inside a PMD/HW before any flow rules are created at the init stage. >> >> 2. Flow grouping using templates. >> Use the knowledge about which flow rules are to be used in an application >> and prepare item and action templates for them in advance. Group flow rules >> with common patterns and actions together for better resource management. >> >> 3. Queue-based flow management. >> Perform flow rule insertion/destruction asynchronously to spare the datapath >> from blocking on RTE Flow API and allow it to continue with packet processing. >> Enqueue flow rules operations and poll for the results later. >> >> testpmd examples are part of the patch series. PMD changes will follow. >> >> RFC:https://patchwork.dpdk.org/project/dpdk/cover/20211006044835.3936226-1-akozyrev@nvidia.com/ >> >> Signed-off-by: Alexander Kozyrev >> Acked-by: Ori Kam >> Acked-by: Ajit Khaparde > > Since these are new APIs and won't impact existing code, I think > can be OK to get with -rc2, only concern may be testing. > > @Andrew, can you please review this version too, if it is good > for you, we can proceed. And this supposed to be a reply to v9, please review it: https://patches.dpdk.org/user/todo/dpdk/?series=21774