From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Qiu, Michael" <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build
Date: Thu, 05 Mar 2015 10:51:57 +0100 [thread overview]
Message-ID: <8539092.UnIgVbWq12@xps13> (raw)
In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CEED33@SHSMSX101.ccr.corp.intel.com>
Hi Michael,
2015-03-05 09:13, Qiu, Michael:
> On 3/4/2015 6:24 AM, Thomas Monjalon wrote:
> >>> Compilation fails in some distributions because of missing unistd.h
> >>> needed for pread/pwrite (seen with Suse):
> >>> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:
> >>> error: implicit declaration of function ‘pread’
> >>>
> >>> Fixes: 4a499c649590 ("eal/linux: enable uio_pci_generic support")
> >>>
> >>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >> Acked-by: David Marchand <david.marchand@6wind.com>
> > Applied
>
> Hi, Thomas
>
> This patch may be need to be reverted, as the error still exists.
No I don't think it should be reverted. It must be completed.
[...]
> NAME
> pread, pwrite - read from or write to a file descriptor at a
> given offset
>
> SYNOPSIS
> #define _XOPEN_SOURCE 500
>
> #include <unistd.h>
[...]
> While I try to add marco #define _XOPEN_SOURCE 500
I think that the good thing to do.
> Other errors show up
Are they hard to fix?
> Who knows how to solve this issue?
prev parent reply other threads:[~2015-03-05 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 8:44 Thomas Monjalon
2015-03-03 9:12 ` David Marchand
2015-03-03 22:23 ` Thomas Monjalon
2015-03-05 9:13 ` Qiu, Michael
2015-03-05 9:28 ` Ananyev, Konstantin
2015-03-05 9:51 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8539092.UnIgVbWq12@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).